omap3: omap3530_beagle_per_uart_defconfig broken
Hi,
while just giving the omap3530 boot from internal sram a whirl, found that
commit 78104ae181f78d83664fdc7522eb632d9c3b2ec9
Author: Sascha Hauer <[email protected]> Date: Fri Apr 16 15:50:30 2010 +0200
arm: reimplement startup code in C
Lets translate the startup code to a language we all understand better. Tested on pcm038 (arm v5) and pcm043 (arm v6).
broke the support for OMAP3530 internal boot capability -> it looks like many of the V7Dcache skip logic got dropped off in the patch. will try to fix it ahead.. reverting this commit helps the barebox master..
Regards,
Nishanth Menon
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Quoted 9 lines · Nishanth Menon
Hi,
while just giving the omap3530 boot from internal sram a whirl, found thatcommit
78104ae181f78d83664fdc7522eb632d9c3b2ec9Author: Sascha Hauer <[email protected]> Date: Fri Apr 16 15:50:30 2010 +0200arm: reimplement startup code in C
Quoted 8 lines
Lets translate the startup code to a language we all understand better. Tested on pcm038 (arm v5) and pcm043 (arm v6).
Signed-off-by Sascha Hauer <[email protected]>broke the support for OMAP3530 internal boot capability -> it looks like many of the V7Dcache skip logic got dropped off in the patch. will try to fix it ahead.. reverting this commit helps the barebox master..
We worked on Omap lately. I remember that there was a problem with the call to arch_init_lowlevel. Michael, do you have input on this?
Sascha
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 13 lines · Sascha Hauer
Quoted 12 lines · Nishanth Menon
Hi,
while just giving the omap3530 boot from internal sram a whirl, found thatcommit
78104ae181f78d83664fdc7522eb632d9c3b2ec9Author: Sascha Hauer <[email protected]> Date: Fri Apr 16 15:50:30 2010 +0200arm: reimplement startup code in C
Lets translate the startup code to a language we all understand better. Tested on pcm038 (arm v5) and pcm043 (arm v6).
Quoted 8 lines
Quoted 5 lines
Signed-off-by Sascha Hauer <[email protected]>broke the support for OMAP3530 internal boot capability -> it looks like many of the V7Dcache skip logic got dropped off in the patch. will try to fix it ahead.. reverting this commit helps the barebox master..
We worked on Omap lately. I remember that there was a problem with the call to
arch_init_lowlevel. Michael, do you have input on this?
This commit indeed broke omap because the call to arch_init_lowlevel was missing afterwards. This got fixed with 3aa5c83. Maybe you have a different problem and stumbled upon this commit while bisecting. You could try checking out 78104ae181f78d83664fdc7522eb632d9c3b2ec9 and cherry-pick 3aa5c83. Does this work?
Sascha
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 20 lines · Sascha Hauer
Quoted 19 lines · Sascha Hauer
Quoted 17 lines · Nishanth Menon
Hi,
while just giving the omap3530 boot from internal sram a whirl, found thatcommit
78104ae181f78d83664fdc7522eb632d9c3b2ec9Author: Sascha Hauer<[email protected]> Date: Fri Apr 16 15:50:30 2010 +0200arm: reimplement startup code in C
Lets translate the startup code to a language we all understand better. Tested on pcm038 (arm v5) and pcm043 (arm v6).
Signed-off-by Sascha Hauer<[email protected]>broke the support for OMAP3530 internal boot capability -> it looks like many of the V7Dcache skip logic got dropped off in the patch. will try to fix it ahead.. reverting this commit helps the barebox master..
Quoted 8 lines
Quoted 2 lines
We worked on Omap lately. I remember that there was a problem with the call to
arch_init_lowlevel. Michael, do you have input on this?This commit indeed broke omap because the call to
arch_init_lowlevelwas missing afterwards. This got fixed with 3aa5c83. Maybe you have a different problem and stumbled upon this commit while bisecting. You could try checking out78104ae181f78d83664fdc7522eb632d9c3b2ec9and cherry-pick 3aa5c83. Does this work?
will try later tonight (but I doubt it - I had tried master and next - it did not build yesterday due to ehci/otg changes, but those have patches from Michael today), but to give an idea, attached is my revert patch I applied(against master), but if you see there are two parts between arch_init_lowlevel and board_init_lowlevel:
cache invalidate
and configuration of cache
Just glancing, cache invalidate logic that got introduced is the v4/v5(?) logic I guess, not the v7 logic. let me see later tonight if there is a cleaner way to do it..
Regards,
Nishanth Menon
From e58e78fde4b1b2ae20e895a14c675f80f951dc32 Mon Sep 17 00:00:00 2001
From: Nishanth Menon <[email protected]>
Date: Mon, 16 Aug 2010 22:46:04 -0500
Subject: [PATCH] Revert "arm: reimplement startup code in C"
This reverts commit 78104ae181f78d83664fdc7522eb632d9c3b2ec9.
Conflicts:
arch/arm/cpu/start.c
arch/arm/include/asm/barebox-arm.h
--- arch/arm/cpu/Makefile | 6 +- arch/arm/cpu/start-arm.S | 250 ++++++++++++++++++++++++++++++++++++++++++++ arch/arm/cpu/start.c | 114 -------------------- arch/arm/lib/barebox.lds.S | 2 +- 4 files changed, 256 insertions(+), 116 deletions(-) create mode 100644 arch/arm/cpu/start-arm.S delete mode 100644 arch/arm/cpu/start.c
arch/arm/cpu/Makefile +5 -1
@@ -1,11 +1,15 @@ obj-y += cpu.o obj-y += exceptions.o obj-y += interrupts.o -obj-y += start.o # # Any variants can be called as start-armxyz.S # +obj-$(CONFIG_CPU_ARM920T) += start-arm.o +obj-$(CONFIG_CPU_ARM926T) += start-arm.o +obj-$(CONFIG_CPU_V7) += start-arm.o +obj-$(CONFIG_ARCH_IMX31) += start-arm.o +obj-$(CONFIG_ARCH_IMX35) += start-arm.o obj-$(CONFIG_CMD_ARM_CPUINFO) += cpuinfo.o obj-$(CONFIG_MMU) += mmu.o obj-$(CONFIG_CPU_32v4T) += cache-armv4.o
arch/arm/cpu/start-arm.S new file +250 -0
250 lines not on this page · raw message
arch/arm/cpu/start.c deleted +0 -114
114 lines not on this page · raw message
arch/arm/lib/barebox.lds.S +1 -1
@@ -26,7 +26,7 @@ OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") OUTPUT_ARCH(arm) -ENTRY(exception_vectors) +ENTRY(_start) SECTIONS { . = TEXT_BASE;
Signature · 1 line
1.7.0.4
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Quoted 24 lines · Nishanth Menon
Quoted 23 lines · Sascha Hauer
Quoted 21 lines · Sascha Hauer
Quoted 9 lines · Nishanth Menon
Hi,
while just giving the omap3530 boot from internal sram a whirl, found thatcommit
78104ae181f78d83664fdc7522eb632d9c3b2ec9Author: Sascha Hauer<[email protected]> Date: Fri Apr 16 15:50:30 2010 +0200arm: reimplement startup code in C
Quoted 8 lines
Lets translate the startup code to a language we all understand better. Tested on pcm038 (arm v5) and pcm043 (arm v6).
Signed-off-by Sascha Hauer<[email protected]>broke the support for OMAP3530 internal boot capability -> it looks like many of the V7Dcache skip logic got dropped off in the patch. will try to fix it ahead.. reverting this commit helps the barebox master..
We worked on Omap lately. I remember that there was a problem with the call to
arch_init_lowlevel. Michael, do you have input on this?
Quoted 7 lines
Quoted 5 lines
This commit indeed broke omap because the call to
arch_init_lowlevelwas missing afterwards. This got fixed with 3aa5c83. Maybe you have a different problem and stumbled upon this commit while bisecting. You could try checking out78104ae181f78d83664fdc7522eb632d9c3b2ec9and cherry-pick 3aa5c83. Does this work?will try later tonight (but I doubt it - I had tried master and next -
The fixup patch already came in between v2010.06.0 and v2010.07.0. So there definitely is a window in which barebox was broken. Maybe you hit this while bisecting. Maybe there is a second one which is the real cause of your trouble here.
Quoted 9 lines
it did not build yesterday due to ehci/otg changes, but those have patches from Michael today), but to give an idea, attached is my revert patch I applied(against master), but if you see there are two parts between
arch_init_lowlevelandboard_init_lowlevel:
cache invalidate
and configuration of cacheJust glancing, cache invalidate logic that got introduced is the v4/v5(?) logic I guess, not the v7 logic.
Nope, we do have v7 logic.
Quoted 5 lines
let me see later tonight if
there is a cleaner way to do it..Regards,
Nishanth Menon
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox