netxen: remove firmware exports

RFC PATCH In review Amerigo Wang 2 participants 9 messages Aug 18, 2010 – Aug 20, 2010

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Amerigo Wang

author

2010-08-18 09:54 UTC #0 lore raw

RFC PATCH 1/1 netxen: remove firmware exports

netxen_nic driver can store firmwares on flash, and get them porperly and dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic still exports these firmwares via modinfo, this makes our script which parses modinfo output fail.

Probably netxen_nic has other way to export these firmwares, but not like other modules in a stardand way. I think we can just remove these exports, but I am not sure.

Signed-off-by WANG Cong <[email protected]>

Cc Amit Kumar Salecha <[email protected]>

Cc "David S. Miller" <[email protected]>

Cc Dhananjay Phadke <[email protected]>

Cc Narender Kumar <[email protected]>

---

drivers/net/netxen/netxen_nic_main.c +0 -4

index fd86e18..e8443af 100644
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"

Amit Salecha

2010-08-18 11:04 UTC #1 lore raw

If problem is firmware files are not present in /lib/firmware.
Then we can work with David Woodhouse and make these firmware available in /lib/firmware.

-----Original Message-----
From: Amerigo Wang [mailto:[email protected]]
Sent: Wednesday, August 18, 2010 3:25 PM
To: [email protected]
Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; [email protected]; David S. Miller; Amerigo Wang
Subject: [RFC Patch] netxen: remove firmware exports

Probably netxen_nic has other way to export these firmwares, but not like other modules in a stardand way. I think we can just remove these exports, but I am not sure.

Signed-off-by WANG Cong <[email protected]>

Cc Amit Kumar Salecha <[email protected]>

Cc "David S. Miller" <[email protected]>

Cc Dhananjay Phadke <[email protected]>

Cc Narender Kumar <[email protected]>

---

drivers/net/netxen/netxen_nic_main.c +0 -4

index fd86e18..e8443af 100644
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"

Cong Wang

author

2010-08-18 13:14 UTC #2 lore raw

Quoted 3 lines · Amit Salecha

If problem is firmware files are not present in /lib/firmware.
Then we can work with David Woodhouse and make these firmware available in /lib/firmware.

Oh, I thought we did this intentionally.
That would be nice then, please go ahead.

Thanks!

Signature · 2 lines

The opposite of love is not hate, it's indifference.
 - Elie Wiesel

Amit Salecha

2010-08-18 13:19 UTC #3 lore raw

Quoted 2 lines

Then we can work with David Woodhouse and make these firmware available in /lib/firmware

Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already submitted and its present in linux-firmware.git.

I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?

-----Original Message-----
From: Cong Wang [mailto:[email protected]]
Sent: Wednesday, August 18, 2010 6:49 PM
To: Amit Salecha
Cc: [email protected]; Dhananjay Phadke; Narender Kumar; [email protected]; David S. Miller; Ameen Rahman
Subject: Re: [RFC Patch] netxen: remove firmware exports

Quoted 3 lines · Amit Salecha

If problem is firmware files are not present in /lib/firmware.
Then we can work with David Woodhouse and make these firmware available in /lib/firmware.

Oh, I thought we did this intentionally.
That would be nice then, please go ahead.

Thanks!

Signature · 2 lines

The opposite of love is not hate, it's indifference.
  - Elie Wiesel

Cong Wang

author

2010-08-18 13:36 UTC #4 lore raw

Quoted 4 lines · Amit Salecha

Quoted 2 lines
Then we can work with David Woodhouse and make these firmware available in /lib/firmware
Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already submitted and its present in linux-firmware.git.

Good.

Quoted 3 lines

I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?

Ok, thanks a lot!

Signature · 2 lines

The opposite of love is not hate, it's indifference.
 - Elie Wiesel

Amit Salecha

2010-08-19 09:12 UTC #5 lore raw

In reply to Amerigo Wang

Quoted 4 lines

netxen_nic driver can store firmwares on flash, and get them porperly and dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic still exports these firmwares via modinfo, this makes our script which parses modinfo output fail.

NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.

Review

Quoted 3 lines

(quoted diff) +0 -3

-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);

It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE). I am leaving this upto David to decide about this patch.

-Amit

Probably netxen_nic has other way to export these firmwares, but not like other modules in a stardand way. I think we can just remove these exports, but I am not sure.

Signed-off-by WANG Cong <[email protected]>

Cc Amit Kumar Salecha <[email protected]>

Cc "David S. Miller" <[email protected]>

Cc Dhananjay Phadke <[email protected]>

Cc Narender Kumar <[email protected]>

---

drivers/net/netxen/netxen_nic_main.c +0 -4

index fd86e18..e8443af 100644
@@ -41,10 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";
 static char netxen_nic_driver_string[] = "QLogic/NetXen Network Driver v"

Cong Wang

author

2010-08-20 08:48 UTC #6 lore raw

Quoted 5 lines · Amit Salecha

Quoted 4 lines
netxen_nic driver can store firmwares on flash, and get them porperly and dynamically, so the firmwares may not appear in /lib/firmware/. However, netxen_nic still exports these firmwares via modinfo, this makes our script which parses modinfo output fail.

Quoted 9 lines

NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.
drivers/net/netxen/netxen_nic_main.c line 46
Quoted 3 lines
drivers/net/netxen/netxen_nic_main.c +0 -3
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
It's not compulsory to submit firmware files which are exported (MODULE_FIRMWARE). I am leaving this upto David to decide about this patch.

Okay. David, do you want me to submit an updated patch?

Thanks!

Signature · 2 lines

The opposite of love is not hate, it's indifference.
 - Elie Wiesel

Amit Salecha

2010-08-20 08:54 UTC #7 lore raw

Quoted 1 line

Okay. David, do you want me to submit an updated patch?

You have to submit updated patch.

-Amit

Quoted 36 lines

-----Original Message-----
From: Cong Wang [mailto:[email protected]]
Sent: Friday, August 20, 2010 2:22 PM
To: Amit Salecha
Cc: [email protected]; David S. Miller; Dhananjay Phadke; Narender Kumar; [email protected]
Subject: Re: [RFC Patch] netxen: remove firmware exports
Quoted 1 line · Amit Salecha
Quoted 1 line
netxen_nic driver can store firmwares on flash, and get them
porperly and
Quoted 1 line
Quoted 1 line
dynamically, so the firmwares may not appear in /lib/firmware/.
However, netxen_nic
Quoted 1 line
Quoted 1 line
still exports these firmwares via modinfo, this makes our script
which parses
Quoted 3 lines
Quoted 1 line
modinfo output fail.
NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we
won't submit any other fw files.
Quoted 6 lines
drivers/net/netxen/netxen_nic_main.c line 46
Quoted 4 lines
drivers/net/netxen/netxen_nic_main.c +0 -3
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
It's not compulsory to submit firmware files which are exported
(MODULE_FIRMWARE).
Quoted 2 lines
I am leaving this upto David to decide about this patch.
Okay. David, do you want me to submit an updated patch?
Thanks!
--
The opposite of love is not hate, it's indifference.
- Elie Wiesel

Cong Wang

author

2010-08-20 09:00 UTC #8 lore raw

In reply to Amit Salecha

Quoted 1 line · Amit Salecha

NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we won't submit any other fw files.

Based on above, remove the rest firmware exports.

Thanks!

Signature · 1 line

Signed-off-by: WANG Cong <[email protected]>

drivers/net/netxen/netxen_nic_main.c +0 -3

index fd86e18..2fedc3b 100644
@@ -41,9 +41,6 @@
 MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
 MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);
 
 char netxen_nic_driver_name[] = "netxen_nic";