Skip to contentSkip to conversation

xfstests 241: run parallel dbench

PATCH In review Eric Sandeen 2 participants 3 messages Aug 17, 2010 – Aug 18, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests 241: run parallel dbench

ext4 was corrupting inode table bitmaps due to a mishmash of atomic & nonatomic bitops. This got broken twice and fixed twice; let's add a test.

On a 4-way box this reliably ends up with a corrupted filesystem if we get it wrong (upstream as of 2.6.35 at least is fine again)

---

241 new file +60 -0
@@ -0,0 +1,60 @@
+#! /bin/bash
+# FS QA Test No. 241
+#
+# Run parallel dbench & check for filesystem corruption
+# This corrupted ext4 inode bitmaps due to races at one point
+#
+# Copyright (c) 2010 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+# creator
[email protected]
+
+seq=`basename $0`
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1        # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common.rc
+. ./common.filter
+
+_supported_fs generic
+_supported_os Linux
+
+[ "$DBENCH_PROG" = "" ] && _notrun "dbench not found"
+
+echo "Silence is golden."
+
+# real QA test starts here
+rm -f $seq.full
+
+rm -rf $TEST_DIR/dbench
+mkdir $TEST_DIR/dbench
+
+dbench -t 30 -D $TEST_DIR/dbench 4 >> $seq.full
+
+status=$?
+exit
common.config +1 -0
index 926846b..04bdcf6 100644
@@ -149,6 +149,7 @@ export XFS_PARALLEL_REPAIR64_PROG="`set_prog_path xfs_prepair64`"
 export XFSDUMP_PROG="`set_prog_path xfsdump`"
 export XFSRESTORE_PROG="`set_prog_path xfsrestore`"
 export XFSINVUTIL_PROG="`set_prog_path xfsinvutil`"
+export DBENCH_PROG="`set_prog_path dbench`"
 
 # Generate a comparable xfsprogs version number in the form of
 # major * 10000 + minor * 100 + release
common.dbench +1 -1
index 026acdf..b59be71 100755
@@ -17,7 +17,7 @@
 #
 
 #check dbench is installed
-if [ "`whereis dbench`" == "dbench:"]; then
+if [ "`whereis dbench`" == "dbench:" ]; then
         echo $0 error dbench not installed.
         exit
 fi
group +1 -0
index afe7614..2baa538 100644
@@ -354,3 +354,4 @@ deprecated
 238 auto quick metadata ioctl
 239 auto aio rw
 240 auto aio quick rw
+241 auto

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 8 lines · Eric Sandeen

ext4 was corrupting inode table bitmaps due to a mishmash of atomic & nonatomic bitops. This got broken twice and fixed twice; let's add a test.

On a 4-way box this reliably ends up with a corrupted filesystem if we get it wrong (upstream as of 2.6.35 at least is fine again)

Looks good, except it's missing a 241.out file for the golden output.

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#2 lore raw
Quoted 5 lines · Dave Chinner
Quoted 4 lines · Eric Sandeen

ext4 was corrupting inode table bitmaps due to a mishmash of atomic & nonatomic bitops. This got broken twice and fixed twice; let's add a test.

Quoted 7 lines
Quoted 4 lines

On a 4-way box this reliably ends up with a corrupted filesystem if we get it wrong (upstream as of 2.6.35 at least is fine again)

Looks good, except it's missing a 241.out file for the golden output.

grr "guilt add" :)

Thanks, will add that to the commit.

-Eric

Quoted 3 lines

Cheers,

Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs