t9155 fails since "git-svn: fix fetch with deleted tag" with svn < 1.5
t9155 fails on current next when running the testsuite on a Fedora Core 7 system. The reason is that FC7 comes with svn 1.4.4, while in commit 3235b70 the --parents option was introduced into t9155 which was added in svn 1.5.
What minimum svn version is required for git svn? I didn't find any information about that, but I might have overlooked something ...
Quoted 7 lines · Jens Lehmann
t9155 fails on current next when running the testsuite on a Fedora Core 7 system. The reason is that FC7 comes with svn 1.4.4, while in commit 3235b70 the --parents option was introduced into t9155 which was added in svn 1.5.
What minimum svn version is required for git svn? I didn't find any information about that, but I might have overlooked something ...
We currently require >= 1.1.0 of SVN::Core for the git-svn tests at least.
Quoted 5 lines · Ævar Arnfjörð Bjarmason
Quoted 4 lines · Jens Lehmann
t9155 fails on current next when running the testsuite on a Fedora Core 7 system. The reason is that FC7 comes with svn 1.4.4, while in commit 3235b70 the --parents option was introduced into t9155 which was added in svn 1.5.
The --parents option appears completely unnecessary in this case, so removing it should be safe. Patch coming...
Quoted 4 lines
Quoted 2 lines
What minimum svn version is required for git svn? I didn't find any information about that, but I might have overlooked something ...
We currently require >= 1.1.0 of
SVN::Corefor the git-svn tests at least.
That's still the only hard requirement I know of. While I haven't had a 1.1.x installation in years, reports of incompatibility have been few. So either people find it easier to upgrade to newer versions of SVN, don't care, or there just aren't that many incompatibilities.
I'd say we will continue to do our best to support whatever versions people care to report (preferably with patches :) incompatibilities for.
Signature · 1 line
Eric Wong
PATCH 1/1 t9155: fix compatibility with older SVN
The "--parents" option did not appear until SVN 1.5.x and is completely unnecessary in this case.
---
Also pushed up to git://git.bogomips.org/git-svn
t/t9155-git-svn-fetch-deleted-tag.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
t/t9155-git-svn-fetch-deleted-tag.sh +1 -1
@@ -12,7 +12,7 @@ test_expect_success 'setup svn repo' ' svn_cmd import -m "import for git svn" import "$svnrepo" && rm -rf import && - svn_cmd mkdir --parents -m "create mybranch directory" "$svnrepo/branches/mybranch" && + svn_cmd mkdir -m "create mybranch directory" "$svnrepo/branches/mybranch" && svn_cmd cp -m "create branch mybranch" "$svnrepo/trunk" "$svnrepo/branches/mybranch/trunk" && svn_cmd co "$svnrepo/trunk" svn_project &&
Signature · 1 line
Eric Wong
Re: [PATCH] t9155: fix compatibility with older SVN
Am 19.08.2010 21:15, schrieb Eric Wong:
Quoted 2 lines
The "--parents" option did not appear until SVN 1.5.x and is completely unnecessary in this case.
Thanks for the quick response! I'll test this patch on Monday when I have access to that FC7 machine again.
Jens Lehmann
Tested-byRe: [PATCH] t9155: fix compatibility with older SVN
Am 19.08.2010 21:40, schrieb Jens Lehmann:
Quoted 6 lines
Am 19.08.2010 21:15, schrieb Eric Wong:
Quoted 2 lines
The "--parents" option did not appear until SVN 1.5.x and is completely unnecessary in this case.
Thanks for the quick response! I'll test this patch on Monday when I have access to that FC7 machine again.
Just for the record:
Re: [PATCH] t9155: fix compatibility with older SVN
In reply to Eric WongQuoted 2 lines · Eric Wong
The "--parents" option did not appear until SVN 1.5.x and is completely unnecessary in this case.
At one point in development, I wasn't creating the branches directory on the initial import, which is why this was added. Thanks for fixing this!
Quoted 2 lines
Reported-by Jens Lehmann <[email protected]>Signed-off-by Eric Wong <[email protected]>
Ack.
Dave