Skip to contentSkip to conversation

cxgbi iscsi driver

PATCH In review [email protected] 2 participants 2 messages Aug 17, 2010 – Aug 19, 2010 1 message not in the archive

Subsystems (3)
Networking Network drivers SCSI
lore
Share & tools
lore

[email protected]

author
#0 lore raw

v5 cover cxgbi iscsi driver

[PATCH v5 0/3] cxgbi iscsi driver

From: Karen Xie <[email protected]>

This patchset includes:

1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
2. added cxgb4i iscsi initiator v5.
3. changed cxgb3i to use libcxgbi.

Version 5 changes:
- got rid of log_error/warn/info and used pr_<level> instead.
- "%zu" for printing out sizeof().
- made sure all printk messages have trailing "."

Version 4 changes:
- removed directory drivers/scsi/cxgb3i. The updated cxgb3i driver is under drivers/scsi/cxgbi/cxgb3i.

Version 3 changes:
- re-worked defines of xxx_log_error/warn/info/debug to get rid of double indirection.

Version 2 changes:
- Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i are built into the kernel.
- Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template(). The iscsi_transport and scsi_host_template are initialized in the drivers instead of being filled in by the library at runtime..
- Only register with iscsi class transport once per driver type.

Thanks.
Karen

Signature · 4 lines
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.

A message that is not in the archive (sent off-list or not yet received): 201008170355.o7H3trvW020987-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

Reviewed-by
#2 lore raw
Quoted 6 lines · On 08/16/2010 10:55 PM, [email protected] wrote:

[PATCH v5 0/3] cxgbi iscsi driver

From: Karen Xie<[email protected]>

This patchset includes:

Quoted 9 lines

1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
2. added cxgb4i iscsi initiator v5.
3. changed cxgb3i to use libcxgbi.

Version 5 changes:
- got rid of log_error/warn/info and used pr_<level> instead.
- "%zu" for printing out sizeof().
- made sure all printk messages have trailing "."

iSCSI and scsi parts look ok to me.

Reviewed-by Mike Christie <[email protected]>

I looked at the network code and it looks similar to what is in the cxgb3i driver upstream, so I think it should be ok, but I am not 100% sure so probably needs a netdev ack.

Signature · 4 lines
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected]
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.