Fix return code for mkdir calls

Hi,

This patch fixes the return value when the cgroup hierarchy for blkio control groups is deeper than two levels. Right now EINVAL is returned. This patch replaces EINVAL with more appropriate EPERM to align with mkdir system call return values. This was discussed between Vivek and Daniel sometime back. Please consider this patch for inclusion in 2.6.36.

Thanks
Ciju

From: Ciju Rajan K <[email protected]>
Date: Fri, 20 Aug 2010 12:02:45 +0530
Subject: blkio: Fix return code for mkdir calls

If the cgroup hierarchy for blkio control groups is deeper than two levels, kernel should not allow the creation of further levels. mkdir system call does not except EINVAL as a return value. This patch replaces EINVAL with more appropriate EPERM

---
 block/blk-cgroup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index a680964..2fef1ef 100644
@@ -966,7 +966,7 @@ blkiocg_create(struct cgroup_subsys *subsys, struct cgroup *cgroup)
 
 	/* Currently we do not support hierarchy deeper than two level (0,1) */
 	if (parent != cgroup->top_cgroup)
-		return ERR_PTR(-EINVAL);
+		return ERR_PTR(-EPERM);
 
 	blkcg = kzalloc(sizeof(*blkcg), GFP_KERNEL);
 	if (!blkcg)

1.6.0.6

Thank you!

Thanks, applied.

Jens Axboe