Skip to contentSkip to conversation

xl: fix compiler warning with fork_exec_bootloader

PATCH New Andre Przywara 1 participant 1 message Aug 20, 2010

lore
Share & tools
lore

Andre Przywara

author
#0 lore raw

PATCH 1/1 xl: fix compiler warning with fork_exec_bootloader

Hi,

at least one of my compilers complains about the broken const qualifier in the fork_exec_bootloader() call (despite the cast). Fix this properly by propagating the const attribute down the call stack.

Regards,
Andre.

Signed-off-by Andre Przywara <[email protected]>
Signature · 3 lines
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12
Quoted 1 line

From ad5d2d401741c3e23796072a3304f46ae0a4832e Mon Sep 17 00:00:00 2001

From: Andre Przywara <[email protected]>
Date: Fri, 20 Aug 2010 01:00:17 +0200
Subject: [PATCH 1/4] xl: fix compiler warning with fork_exec_bootloader

At least one of my compilers complains about the broken const qualifier in the fork_exec_bootloader() call (despite the cast). Fix this properly by propagating the const attribute down the call stack.

Signed-off-by Andre Przywara <[email protected]>
---
 tools/libxl/libxl_bootloader.c |    4 ++--
 tools/libxl/libxl_exec.c       |    3 ++-
 tools/libxl/libxl_internal.h   |    3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)
tools/libxl/libxl_bootloader.c +2 -2
index e7e88ce..50b9b17 100644
@@ -118,7 +118,7 @@ static int open_xenconsoled_pty(int *master, int *slave, char *slave_path, size_
     return 0;
 }
 
-static pid_t fork_exec_bootloader(int *master, char *arg0, char **args)
+static pid_t fork_exec_bootloader(int *master, const char *arg0, char **args)
 {
     struct termios termattr;
     pid_t pid = forkpty(master, NULL, NULL, NULL);

@@ -386,7 +386,7 @@ int libxl_run_bootloader(libxl_ctx *ctx,
     dom_console_xs_path = libxl_sprintf(&gc, "%s/serial/0/tty", libxl_xs_get_dompath(&gc, domid));
     libxl_xs_write(&gc, XBT_NULL, dom_console_xs_path, "%s", dom_console_slave_tty_path);
 
-    pid = fork_exec_bootloader(&bootloader_fd, (char *)info->u.pv.bootloader, args);
+    pid = fork_exec_bootloader(&bootloader_fd, info->u.pv.bootloader, args);
     if (pid < 0) {
         goto out_close;
     }
tools/libxl/libxl_exec.c +2 -1
index 5210c4f..0796f49 100644
@@ -35,7 +35,8 @@ static int call_waitpid(pid_t (*waitpid_cb)(pid_t, int *, int), pid_t pid, int *
     return (waitpid_cb) ? waitpid_cb(pid, status, options) : waitpid(pid, status, options);
 }
 
-void libxl_exec(int stdinfd, int stdoutfd, int stderrfd, char *arg0, char **args)
+void libxl_exec(int stdinfd, int stdoutfd, int stderrfd, const char *arg0,
+                char **args)
      /* call this in the child */
 {
     int i;
tools/libxl/libxl_internal.h +2 -1
index 2f81acc..bab576c 100644
@@ -228,7 +228,8 @@ _hidden int libxl_spawn_check(libxl_ctx *ctx,
 
  /* low-level stuff, for synchronous subprocesses etc. */
 
-_hidden void libxl_exec(int stdinfd, int stdoutfd, int stderrfd, char *arg0, char **args); // logs errors, never returns
+_hidden void libxl_exec(int stdinfd, int stdoutfd, int stderrfd,
+               const char *arg0, char **args); // logs errors, never returns
 _hidden void libxl_log_child_exitstatus(libxl_gc *gc,
                                 const char *what, pid_t pid, int status);
Signature · 1 line
1.6.4

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel