Skip to contentSkip to conversation

ARM: SAMSUNG: Fix on build warning regarding VMALLOC_END type

PATCH New Kukjin Kim 2 participants 3 messages Aug 21, 2010 – Aug 23, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix on build warning regarding VMALLOC_END type

Fix this warning:

arch/arm/mm/init.c: In function 'mem_init':
arch/arm/mm/init.c:644: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'

Reported-by Kyungmin Park <[email protected]>
Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>
---
 arch/arm/mach-s3c2410/include/mach/vmalloc.h |    2 +-
 arch/arm/mach-s3c64xx/include/mach/vmalloc.h |    2 +-
 arch/arm/mach-s5p6440/include/mach/vmalloc.h |    2 +-
 arch/arm/mach-s5p6442/include/mach/vmalloc.h |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-s3c2410/include/mach/vmalloc.h +1 -1
index 315b007..dc3b34c 100644
@@ -15,6 +15,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
arch/arm/mach-s3c64xx/include/mach/vmalloc.h +1 -1
index 7411ef3..f0a0fa2 100644
@@ -15,6 +15,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
arch/arm/mach-s5p6440/include/mach/vmalloc.h +1 -1
index 16df257..8217b99 100644
@@ -12,6 +12,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
arch/arm/mach-s5p6442/include/mach/vmalloc.h +1 -1
index be33336..b9fd9aa 100644
@@ -12,6 +12,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix on build warning regarding VMALLOC_END type

Hello.

Quoted 9 lines · Kukjin Kim

Fix this warning:

arch/arm/mm/init.c: In function 'mem_init':
arch/arm/mm/init.c:644: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'

Reported-by Kyungmin Park <[email protected]>
Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>

[...]

Quoted 41 lines
arch/arm/mach-s3c2410/include/mach/vmalloc.h +1 -1
index 315b007..dc3b34c 100644
@@ -15,6 +15,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
arch/arm/mach-s3c64xx/include/mach/vmalloc.h +1 -1
index 7411ef3..f0a0fa2 100644
@@ -15,6 +15,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
arch/arm/mach-s5p6440/include/mach/vmalloc.h +1 -1
index 16df257..8217b99 100644
@@ -12,6 +12,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
arch/arm/mach-s5p6442/include/mach/vmalloc.h +0 -0
index be33336..b9fd9aa 100644

arch/arm/mach-s5p6442/include/mach/vmalloc.h line 17

Quoted 7 lines
arch/arm/mach-s5p6442/include/mach/vmalloc.h +1 -1
@@ -12,6 +12,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
 
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */

Could eliminate the useless parens while at it...

WBR, Sergei

author
#2 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix on build warning regarding VMALLOC_END type

Quoted 3 lines · Sergei Shtylyov

Hello.

Hi ;-)

Quoted 8 lines
Quoted 5 lines · Kukjin Kim

Fix this warning:

arch/arm/mm/init.c: In function 'mem_init':
arch/arm/mm/init.c:644: warning: format '%08lx' expects type 'long unsigned int', but argument 12 has type 'unsigned int'

Quoted 7 lines
Quoted 3 lines
Reported-by Kyungmin Park <[email protected]>
Signed-off-by Kukjin Kim <[email protected]>
Cc Ben Dooks <[email protected]>

[...]

Review

Quoted 1 line
(quoted diff) +0 -0

b/arch/arm/mach-

Quoted 8 lines

s3c2410/include/mach/vmalloc.h

Quoted 7 lines

index 315b007..dc3b34c 100644

arch/arm/mach-s3c2410/include/mach/vmalloc.h +0 -0
@@ -15,6 +15,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
Quoted 5 lines

Review

Quoted 5 lines
arch/arm/mach-s3c2410/include/mach/vmalloc.h +1 -1
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
(quoted diff) +0 -0

b/arch/arm/mach-

Quoted 8 lines

s3c64xx/include/mach/vmalloc.h

Quoted 7 lines

index 7411ef3..f0a0fa2 100644

arch/arm/mach-s3c64xx/include/mach/vmalloc.h +0 -0
@@ -15,6 +15,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
Quoted 5 lines

Review

Quoted 5 lines
arch/arm/mach-s3c64xx/include/mach/vmalloc.h +1 -1
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
(quoted diff) +0 -0

b/arch/arm/mach-

Quoted 8 lines

s5p6440/include/mach/vmalloc.h

Quoted 7 lines

index 16df257..8217b99 100644

arch/arm/mach-s5p6440/include/mach/vmalloc.h +0 -0
@@ -12,6 +12,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
Quoted 5 lines

Review

Quoted 5 lines
arch/arm/mach-s5p6440/include/mach/vmalloc.h +1 -1
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */
(quoted diff) +0 -0

b/arch/arm/mach-

Quoted 8 lines

s5p6442/include/mach/vmalloc.h

Quoted 7 lines

index be33336..b9fd9aa 100644

arch/arm/mach-s5p6442/include/mach/vmalloc.h +0 -0
@@ -12,6 +12,6 @@
 #ifndef __ASM_ARCH_VMALLOC_H
 #define __ASM_ARCH_VMALLOC_H
Quoted 7 lines

arch/arm/mach-s5p6442/include/mach/vmalloc.h line 17

Quoted 4 lines
arch/arm/mach-s5p6442/include/mach/vmalloc.h +1 -1
-#define VMALLOC_END	  (0xE0000000)
+#define VMALLOC_END	(0xE0000000UL)
 
 #endif /* __ASM_ARCH_VMALLOC_H */

Could eliminate the useless parens while at it...

Sure, it's no problem.
Will re-send soon with fix it.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.