Skip to contentSkip to conversation

pm_qos: Fix inline documentation.

PATCH Applied Saravana Kannan 3 participants 4 messages Aug 26, 2010 – Aug 27, 2010 Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pm_qos: Fix inline documentation.

Change-Id I32f95b5a7e92236931b38fc4f1474f46ad22e298
---
 kernel/pm_qos_params.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
kernel/pm_qos_params.c +6 -4
index 996a4de..132471f 100644
@@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
 
 /**
  * pm_qos_add_request - inserts new qos request into the list
- * @pm_qos_class: identifies which list of qos request to us
+ * @dep: pointer to a preallocated handle
+ * @pm_qos_class: identifies which list of qos request to use
  * @value: defines the qos request
  *
  * This function inserts a new entry in the pm_qos_class list of requested qos
  * performance characteristics.  It recomputes the aggregate QoS expectations
- * for the pm_qos_class of parameters, and returns the pm_qos_request list
- * element as a handle for use in updating and removal.  Call needs to save
- * this handle for later use.
+ * for the pm_qos_class of parameters and initializes the pm_qos_request_list
+ * handle.  Caller needs to save this handle for later use in updates and
+ * removal.
  */
+
 void pm_qos_add_request(struct pm_qos_request_list *dep,
 			int pm_qos_class, s32 value)
 {
Signature · 4 lines
1.7.1.1
---
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Acked-by on v1 1/1
#1 lore raw

thanks!

--mgross

Quoted 37 lines · Saravana Kannan
Change-Id I32f95b5a7e92236931b38fc4f1474f46ad22e298
---
 kernel/pm_qos_params.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
kernel/pm_qos_params.c +6 -4
index 996a4de..132471f 100644
@@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
 
 /**
  * pm_qos_add_request - inserts new qos request into the list
- * @pm_qos_class: identifies which list of qos request to us
+ * @dep: pointer to a preallocated handle
+ * @pm_qos_class: identifies which list of qos request to use
  * @value: defines the qos request
  *
  * This function inserts a new entry in the pm_qos_class list of requested qos
  * performance characteristics.  It recomputes the aggregate QoS expectations
- * for the pm_qos_class of parameters, and returns the pm_qos_request list
- * element as a handle for use in updating and removal.  Call needs to save
- * this handle for later use.
+ * for the pm_qos_class of parameters and initializes the pm_qos_request_list
+ * handle.  Caller needs to save this handle for later use in updates and
+ * removal.
  */
+
 void pm_qos_add_request(struct pm_qos_request_list *dep,
 			int pm_qos_class, s32 value)
 {
Signature · 4 lines
1.7.1.1
---
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
#2 lore raw
Quoted 1 line · mark gross

Applied to suspend-2.6/pm-fixes .

Thanks,
Rafael

Quoted 40 lines · Saravana Kannan
Quoted 22 lines
Change-Id I32f95b5a7e92236931b38fc4f1474f46ad22e298
---
 kernel/pm_qos_params.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
kernel/pm_qos_params.c +2 -2
index 996a4de..132471f 100644
@@ -212,15 +212,17 @@ EXPORT_SYMBOL_GPL(pm_qos_request_active);
 
 /**
  * pm_qos_add_request - inserts new qos request into the list
- * @pm_qos_class: identifies which list of qos request to us
+ * @dep: pointer to a preallocated handle
+ * @pm_qos_class: identifies which list of qos request to use
  * @value: defines the qos request
  *
  * This function inserts a new entry in the pm_qos_class list of requested qos
  * performance characteristics.  It recomputes the aggregate QoS expectations
- * for the pm_qos_class of parameters, and returns the pm_qos_request list

kernel/pm_qos_params.c EXPORT_SYMBOL_GPL(pm_qos_request_active); · line 228

Quoted 10 lines
kernel/pm_qos_params.c +4 -2
- * element as a handle for use in updating and removal.  Call needs to save
- * this handle for later use.
+ * for the pm_qos_class of parameters and initializes the pm_qos_request_list
+ * handle.  Caller needs to save this handle for later use in updates and
+ * removal.
  */
+
 void pm_qos_add_request(struct pm_qos_request_list *dep,
 			int pm_qos_class, s32 value)
 {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw
Quoted 8 lines · Rafael J. Wysocki
Quoted 1 line · mark gross

Applied to suspend-2.6/pm-fixes .

Thanks,
Rafael

Mark,
No probs. I was confused for a while due to the comment. Didn't want to repeat it when I come back to it the next time.

Rafael,
So suspend-2.6/pm-fixes is the one that Linus pulls in for the next release? So, I'm done at this point?

-Saravana

Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.