davinci: Add MityDSP-L138/MityARM-1808 SOM support
Subsystems (3)
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
This patch adds support for the MityDSP-L138 and MityARM-1808 system on
module (SOM) under the registered machine "mityomapl138". These SOMs are based on the da850 davinci CPU architecture. Information on these SOMs may be found at http://www.mitydsp.com.
---
This patch is against Kevin's tree, but is dependent on the following patch, which is queued for 2.6.36:
Changes since v3 patch was submitted:
* renamed ATAG_PERIPHERALS to ATAG_MITYDSPL138
* removed unused header files
* renamed config structure items to remove camel case naming
* don't use GPIO if resources aren't acquired
* don't use device_initcall on emac config
* handle upcoming patch to platform sound config
* clean up mcasp configuration
* misc cleanup per comments
arch/arm/configs/da8xx_omapl_defconfig | 291 ++++++- arch/arm/include/asm/setup.h | 5 + arch/arm/mach-davinci/Kconfig | 8 + arch/arm/mach-davinci/Makefile | 1 + arch/arm/mach-davinci/board-mityomapl138.c | 806 ++++++++++++++++++++ .../mach-davinci/include/mach/cb-mityomapl138.h | 120 +++ arch/arm/mach-davinci/include/mach/da8xx.h | 1 + arch/arm/mach-davinci/include/mach/uncompress.h | 1 + 8 files changed, 1190 insertions(+), 43 deletions(-)
arch/arm/configs/da8xx_omapl_defconfig +248 -43
@@ -1,13 +1,15 @@ # # Automatically generated make config: don't edit -# Linux kernel version: 2.6.32-rc5 -# Thu Oct 22 12:19:19 2009 +# Linux kernel version: 2.6.35-rc3 +# Tue Jul 20 08:30:23 2010 # CONFIG_ARM=y CONFIG_SYS_SUPPORTS_APM_EMULATION=y CONFIG_GENERIC_GPIO=y CONFIG_GENERIC_TIME=y +# CONFIG_ARCH_USES_GETTIMEOFFSET is not set CONFIG_GENERIC_CLOCKEVENTS=y +CONFIG_HAVE_PROC_CPU=y CONFIG_GENERIC_HARDIRQS=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y
@@ -20,6 +22,7 @@ CONFIG_ARCH_HAS_CPUFREQ=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_ZONE_DMA=y +CONFIG_NEED_DMA_MAP_STATE=y CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ=y CONFIG_VECTORS_BASE=0xffff0000 CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
@@ -32,8 +35,16 @@ CONFIG_EXPERIMENTAL=y CONFIG_BROKEN_ON_SMP=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 +CONFIG_CROSS_COMPILE="" CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y +CONFIG_HAVE_KERNEL_GZIP=y +CONFIG_HAVE_KERNEL_LZMA=y +CONFIG_HAVE_KERNEL_LZO=y +CONFIG_KERNEL_GZIP=y +# CONFIG_KERNEL_BZIP2 is not set +# CONFIG_KERNEL_LZMA is not set +# CONFIG_KERNEL_LZO is not set # CONFIG_SWAP is not set CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y
@@ -48,6 +59,7 @@ CONFIG_POSIX_MQUEUE_SYSCTL=y # CONFIG_TREE_RCU=y # CONFIG_TREE_PREEMPT_RCU is not set +# CONFIG_TINY_RCU is not set # CONFIG_RCU_TRACE is not set CONFIG_RCU_FANOUT=32 # CONFIG_RCU_FANOUT_EXACT is not set
@@ -55,11 +67,6 @@ CONFIG_RCU_FANOUT=32 CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_LOG_BUF_SHIFT=14 -CONFIG_GROUP_SCHED=y -CONFIG_FAIR_GROUP_SCHED=y -# CONFIG_RT_GROUP_SCHED is not set -CONFIG_USER_SCHED=y -# CONFIG_CGROUP_SCHED is not set # CONFIG_CGROUPS is not set # CONFIG_SYSFS_DEPRECATED_V2 is not set # CONFIG_RELAY is not set
@@ -69,6 +76,7 @@ CONFIG_INITRAMFS_SOURCE="" CONFIG_RD_GZIP=y # CONFIG_RD_BZIP2 is not set # CONFIG_RD_LZMA is not set +# CONFIG_RD_LZO is not set CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_SYSCTL=y CONFIG_ANON_INODES=y
@@ -90,10 +98,14 @@ CONFIG_TIMERFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_AIO=y +CONFIG_HAVE_PERF_EVENTS=y +CONFIG_PERF_USE_VMALLOC=y # # Kernel Performance Events And Counters # +# CONFIG_PERF_EVENTS is not set +# CONFIG_PERF_COUNTERS is not set CONFIG_VM_EVENT_COUNTERS=y CONFIG_SLUB_DEBUG=y CONFIG_COMPAT_BRK=y
@@ -131,14 +143,41 @@ CONFIG_LBDAF=y # IO Schedulers # CONFIG_IOSCHED_NOOP=y -CONFIG_IOSCHED_AS=y # CONFIG_IOSCHED_DEADLINE is not set # CONFIG_IOSCHED_CFQ is not set -CONFIG_DEFAULT_AS=y # CONFIG_DEFAULT_DEADLINE is not set # CONFIG_DEFAULT_CFQ is not set -# CONFIG_DEFAULT_NOOP is not set -CONFIG_DEFAULT_IOSCHED="anticipatory" +CONFIG_DEFAULT_NOOP=y +CONFIG_DEFAULT_IOSCHED="noop" +# CONFIG_INLINE_SPIN_TRYLOCK is not set +# CONFIG_INLINE_SPIN_TRYLOCK_BH is not set +# CONFIG_INLINE_SPIN_LOCK is not set +# CONFIG_INLINE_SPIN_LOCK_BH is not set +# CONFIG_INLINE_SPIN_LOCK_IRQ is not set +# CONFIG_INLINE_SPIN_LOCK_IRQSAVE is not set +# CONFIG_INLINE_SPIN_UNLOCK is not set +# CONFIG_INLINE_SPIN_UNLOCK_BH is not set +# CONFIG_INLINE_SPIN_UNLOCK_IRQ is not set +# CONFIG_INLINE_SPIN_UNLOCK_IRQRESTORE is not set +# CONFIG_INLINE_READ_TRYLOCK is not set +# CONFIG_INLINE_READ_LOCK is not set +# CONFIG_INLINE_READ_LOCK_BH is not set +# CONFIG_INLINE_READ_LOCK_IRQ is not set +# CONFIG_INLINE_READ_LOCK_IRQSAVE is not set +# CONFIG_INLINE_READ_UNLOCK is not set +# CONFIG_INLINE_READ_UNLOCK_BH is not set +# CONFIG_INLINE_READ_UNLOCK_IRQ is not set +# CONFIG_INLINE_READ_UNLOCK_IRQRESTORE is not set +# CONFIG_INLINE_WRITE_TRYLOCK is not set +# CONFIG_INLINE_WRITE_LOCK is not set +# CONFIG_INLINE_WRITE_LOCK_BH is not set +# CONFIG_INLINE_WRITE_LOCK_IRQ is not set +# CONFIG_INLINE_WRITE_LOCK_IRQSAVE is not set +# CONFIG_INLINE_WRITE_UNLOCK is not set +# CONFIG_INLINE_WRITE_UNLOCK_BH is not set +# CONFIG_INLINE_WRITE_UNLOCK_IRQ is not set +# CONFIG_INLINE_WRITE_UNLOCK_IRQRESTORE is not set +# CONFIG_MUTEX_SPIN_ON_OWNER is not set # CONFIG_FREEZER is not set #
@@ -149,8 +188,11 @@ CONFIG_MMU=y # CONFIG_ARCH_INTEGRATOR is not set # CONFIG_ARCH_REALVIEW is not set # CONFIG_ARCH_VERSATILE is not set +# CONFIG_ARCH_VEXPRESS is not set # CONFIG_ARCH_AT91 is not set +# CONFIG_ARCH_BCMRING is not set # CONFIG_ARCH_CLPS711X is not set +# CONFIG_ARCH_CNS3XXX is not set # CONFIG_ARCH_GEMINI is not set # CONFIG_ARCH_EBSA110 is not set # CONFIG_ARCH_EP93XX is not set
@@ -159,7 +201,6 @@ CONFIG_MMU=y # CONFIG_ARCH_STMP3XXX is not set # CONFIG_ARCH_NETX is not set # CONFIG_ARCH_H720X is not set -# CONFIG_ARCH_NOMADIK is not set # CONFIG_ARCH_IOP13XX is not set # CONFIG_ARCH_IOP32X is not set # CONFIG_ARCH_IOP33X is not set
@@ -167,6 +208,7 @@ CONFIG_MMU=y # CONFIG_ARCH_IXP2000 is not set # CONFIG_ARCH_IXP4XX is not set # CONFIG_ARCH_L7200 is not set +# CONFIG_ARCH_DOVE is not set # CONFIG_ARCH_KIRKWOOD is not set # CONFIG_ARCH_LOKI is not set # CONFIG_ARCH_MV78XX0 is not set
@@ -175,20 +217,27 @@ CONFIG_MMU=y # CONFIG_ARCH_KS8695 is not set # CONFIG_ARCH_NS9XXX is not set # CONFIG_ARCH_W90X900 is not set +# CONFIG_ARCH_NUC93X is not set # CONFIG_ARCH_PNX4008 is not set # CONFIG_ARCH_PXA is not set # CONFIG_ARCH_MSM is not set +# CONFIG_ARCH_SHMOBILE is not set # CONFIG_ARCH_RPC is not set # CONFIG_ARCH_SA1100 is not set # CONFIG_ARCH_S3C2410 is not set # CONFIG_ARCH_S3C64XX is not set -# CONFIG_ARCH_S5PC1XX is not set +# CONFIG_ARCH_S5P6440 is not set +# CONFIG_ARCH_S5P6442 is not set +# CONFIG_ARCH_S5PC100 is not set +# CONFIG_ARCH_S5PV210 is not set # CONFIG_ARCH_SHARK is not set # CONFIG_ARCH_LH7A40X is not set # CONFIG_ARCH_U300 is not set +# CONFIG_ARCH_U8500 is not set +# CONFIG_ARCH_NOMADIK is not set CONFIG_ARCH_DAVINCI=y # CONFIG_ARCH_OMAP is not set -# CONFIG_ARCH_BCMRING is not set +# CONFIG_PLAT_SPEAR is not set CONFIG_CP_INTC=y #
@@ -205,18 +254,18 @@ CONFIG_ARCH_DAVINCI_DA830=y CONFIG_ARCH_DAVINCI_DA850=y CONFIG_ARCH_DAVINCI_DA8XX=y # CONFIG_ARCH_DAVINCI_DM365 is not set +# CONFIG_ARCH_DAVINCI_TNETV107X is not set # # DaVinci Board Type # CONFIG_MACH_DAVINCI_DA830_EVM=y -CONFIG_DA830_UI=y CONFIG_DA830_UI_LCD=y # CONFIG_DA830_UI_NAND is not set CONFIG_MACH_DAVINCI_DA850_EVM=y -CONFIG_DA850_UI_EXP=y CONFIG_DA850_UI_NONE=y # CONFIG_DA850_UI_RMII is not set +CONFIG_MACH_MITYOMAPL138=y CONFIG_DAVINCI_MUX=y # CONFIG_DAVINCI_MUX_DEBUG is not set # CONFIG_DAVINCI_MUX_WARNINGS is not set
@@ -270,6 +319,7 @@ CONFIG_PREEMPT=y CONFIG_HZ=100 CONFIG_AEABI=y # CONFIG_OABI_COMPAT is not set +CONFIG_ARCH_HAS_HOLES_MEMORYMODEL=y # CONFIG_ARCH_SPARSEMEM_DEFAULT is not set # CONFIG_ARCH_SELECT_MEMORY_MODEL is not set # CONFIG_HIGHMEM is not set
@@ -280,13 +330,11 @@ CONFIG_FLATMEM_MANUAL=y CONFIG_FLATMEM=y CONFIG_FLAT_NODE_MEM_MAP=y CONFIG_PAGEFLAGS_EXTENDED=y -CONFIG_SPLIT_PTLOCK_CPUS=4096 +CONFIG_SPLIT_PTLOCK_CPUS=999999 # CONFIG_PHYS_ADDR_T_64BIT is not set CONFIG_ZONE_DMA_FLAG=1 CONFIG_BOUNCE=y CONFIG_VIRT_TO_BUS=y -CONFIG_HAVE_MLOCK=y -CONFIG_HAVE_MLOCKED_PAGE_BIT=y # CONFIG_KSM is not set CONFIG_DEFAULT_MMAP_MIN_ADDR=4096 CONFIG_LEDS=y
@@ -354,7 +402,6 @@ CONFIG_NET=y # Networking options # CONFIG_PACKET=y -# CONFIG_PACKET_MMAP is not set CONFIG_UNIX=y CONFIG_XFRM=y # CONFIG_XFRM_USER is not set
@@ -404,6 +451,7 @@ CONFIG_INET6_XFRM_MODE_TUNNEL=m CONFIG_INET6_XFRM_MODE_BEET=m # CONFIG_INET6_XFRM_MODE_ROUTEOPTIMIZATION is not set CONFIG_IPV6_SIT=m +# CONFIG_IPV6_SIT_6RD is not set CONFIG_IPV6_NDISC_NODETYPE=y # CONFIG_IPV6_TUNNEL is not set # CONFIG_IPV6_MULTIPLE_TABLES is not set
@@ -440,6 +488,7 @@ CONFIG_NETFILTER_ADVANCED=y # CONFIG_RDS is not set # CONFIG_TIPC is not set # CONFIG_ATM is not set +# CONFIG_L2TP is not set # CONFIG_BRIDGE is not set # CONFIG_NET_DSA is not set # CONFIG_VLAN_8021Q is not set
@@ -465,10 +514,21 @@ CONFIG_NETFILTER_ADVANCED=y # CONFIG_IRDA is not set # CONFIG_BT is not set # CONFIG_AF_RXRPC is not set -# CONFIG_WIRELESS is not set +CONFIG_WIRELESS=y +# CONFIG_CFG80211 is not set +# CONFIG_LIB80211 is not set + +# +# CFG80211 needs to be enabled for MAC80211 +# + +# +# Some wireless drivers require a rate control algorithm +# # CONFIG_WIMAX is not set # CONFIG_RFKILL is not set # CONFIG_NET_9P is not set +# CONFIG_CAIF is not set # # Device Drivers
@@ -486,12 +546,110 @@ CONFIG_PREVENT_FIRMWARE_BUILD=y # CONFIG_DEBUG_DEVRES is not set # CONFIG_SYS_HYPERVISOR is not set # CONFIG_CONNECTOR is not set -# CONFIG_MTD is not set +CONFIG_MTD=y +# CONFIG_MTD_DEBUG is not set +# CONFIG_MTD_TESTS is not set +CONFIG_MTD_CONCAT=y +CONFIG_MTD_PARTITIONS=y +# CONFIG_MTD_REDBOOT_PARTS is not set +# CONFIG_MTD_CMDLINE_PARTS is not set +# CONFIG_MTD_AFS_PARTS is not set +# CONFIG_MTD_AR7_PARTS is not set + +# +# User Modules And Translation Layers +# +# CONFIG_MTD_CHAR is not set +CONFIG_MTD_BLKDEVS=y +CONFIG_MTD_BLOCK=y +CONFIG_FTL=y +# CONFIG_NFTL is not set +# CONFIG_INFTL is not set +# CONFIG_RFD_FTL is not set +# CONFIG_SSFDC is not set +# CONFIG_SM_FTL is not set +# CONFIG_MTD_OOPS is not set + +# +# RAM/ROM/Flash chip drivers +# +CONFIG_MTD_CFI=y +# CONFIG_MTD_JEDECPROBE is not set +CONFIG_MTD_GEN_PROBE=y +# CONFIG_MTD_CFI_ADV_OPTIONS is not set +CONFIG_MTD_MAP_BANK_WIDTH_1=y +CONFIG_MTD_MAP_BANK_WIDTH_2=y +CONFIG_MTD_MAP_BANK_WIDTH_4=y +# CONFIG_MTD_MAP_BANK_WIDTH_8 is not set +# CONFIG_MTD_MAP_BANK_WIDTH_16 is not set +# CONFIG_MTD_MAP_BANK_WIDTH_32 is not set +CONFIG_MTD_CFI_I1=y +CONFIG_MTD_CFI_I2=y +# CONFIG_MTD_CFI_I4 is not set +# CONFIG_MTD_CFI_I8 is not set +# CONFIG_MTD_CFI_INTELEXT is not set +# CONFIG_MTD_CFI_AMDSTD is not set +CONFIG_MTD_CFI_STAA=y +CONFIG_MTD_CFI_UTIL=y +# CONFIG_MTD_RAM is not set +# CONFIG_MTD_ROM is not set +# CONFIG_MTD_ABSENT is not set + +# +# Mapping drivers for chip access +# +# CONFIG_MTD_COMPLEX_MAPPINGS is not set +# CONFIG_MTD_PHYSMAP is not set +# CONFIG_MTD_ARM_INTEGRATOR is not set +# CONFIG_MTD_PLATRAM is not set + +# +# Self-contained MTD device drivers +# +# CONFIG_MTD_SLRAM is not set +# CONFIG_MTD_PHRAM is not set +# CONFIG_MTD_MTDRAM is not set +# CONFIG_MTD_BLOCK2MTD is not set + +# +# Disk-On-Chip Device Drivers +# +# CONFIG_MTD_DOC2000 is not set +# CONFIG_MTD_DOC2001 is not set +# CONFIG_MTD_DOC2001PLUS is not set +CONFIG_MTD_NAND_ECC=y +# CONFIG_MTD_NAND_ECC_SMC is not set +CONFIG_MTD_NAND=y +# CONFIG_MTD_NAND_VERIFY_WRITE is not set +# CONFIG_MTD_SM_COMMON is not set +# CONFIG_MTD_NAND_MUSEUM_IDS is not set +CONFIG_MTD_NAND_DENALI_SCRATCH_REG_ADDR=0xFF108018 +# CONFIG_MTD_NAND_GPIO is not set +CONFIG_MTD_NAND_IDS=y +# CONFIG_MTD_NAND_DISKONCHIP is not set +# CONFIG_MTD_NAND_NANDSIM is not set +# CONFIG_MTD_NAND_PLATFORM is not set +CONFIG_MTD_NAND_DAVINCI=y +# CONFIG_MTD_ONENAND is not set + +# +# LPDDR flash memory drivers +# +# CONFIG_MTD_LPDDR is not set + +# +# UBI - Unsorted block images +# +# CONFIG_MTD_UBI is not set # CONFIG_PARPORT is not set CONFIG_BLK_DEV=y # CONFIG_BLK_DEV_COW_COMMON is not set CONFIG_BLK_DEV_LOOP=m # CONFIG_BLK_DEV_CRYPTOLOOP is not set + +# +# DRBD disabled because PROC_FS, INET or CONNECTOR not selected +# # CONFIG_BLK_DEV_NBD is not set CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_COUNT=1
@@ -501,9 +659,12 @@ CONFIG_BLK_DEV_RAM_SIZE=32768 # CONFIG_ATA_OVER_ETH is not set # CONFIG_MG_DISK is not set CONFIG_MISC_DEVICES=y +# CONFIG_AD525X_DPOT is not set # CONFIG_ICS932S401 is not set # CONFIG_ENCLOSURE_SERVICES is not set # CONFIG_ISL29003 is not set +# CONFIG_SENSORS_TSL2550 is not set +# CONFIG_DS1682 is not set # CONFIG_C2PORT is not set #
@@ -519,6 +680,7 @@ CONFIG_HAVE_IDE=y # # SCSI device support # +CONFIG_SCSI_MOD=m # CONFIG_RAID_ATTRS is not set CONFIG_SCSI=m CONFIG_SCSI_DMA=y
@@ -583,6 +745,7 @@ CONFIG_LXT_PHY=y # CONFIG_NATIONAL_PHY is not set # CONFIG_STE10XP is not set CONFIG_LSI_ET1011C_PHY=y +# CONFIG_MICREL_PHY is not set # CONFIG_FIXED_PHY is not set # CONFIG_MDIO_BITBANG is not set CONFIG_NET_ETHERNET=y
@@ -608,8 +771,7 @@ CONFIG_TI_DAVINCI_EMAC=y # CONFIG_NETDEV_1000 is not set # CONFIG_NETDEV_10000 is not set CONFIG_WLAN=y -# CONFIG_WLAN_PRE80211 is not set -# CONFIG_WLAN_80211 is not set +# CONFIG_HOSTAP is not set # # Enable WiMAX (Networking options) to see the WiMAX drivers
@@ -631,6 +793,7 @@ CONFIG_NET_POLL_CONTROLLER=y CONFIG_INPUT=y # CONFIG_INPUT_FF_MEMLESS is not set # CONFIG_INPUT_POLLDEV is not set +# CONFIG_INPUT_SPARSEKMAP is not set # # Userland interfaces
@@ -652,6 +815,7 @@ CONFIG_KEYBOARD_ATKBD=m # CONFIG_QT2160 is not set # CONFIG_KEYBOARD_LKKBD is not set CONFIG_KEYBOARD_GPIO=y +# CONFIG_KEYBOARD_TCA6416 is not set # CONFIG_KEYBOARD_MATRIX is not set # CONFIG_KEYBOARD_MAX7359 is not set # CONFIG_KEYBOARD_NEWTON is not set
@@ -665,6 +829,8 @@ CONFIG_KEYBOARD_XTKBD=m CONFIG_INPUT_TOUCHSCREEN=y # CONFIG_TOUCHSCREEN_AD7879_I2C is not set # CONFIG_TOUCHSCREEN_AD7879 is not set +# CONFIG_TOUCHSCREEN_DYNAPRO is not set +# CONFIG_TOUCHSCREEN_HAMPSHIRE is not set # CONFIG_TOUCHSCREEN_EETI is not set # CONFIG_TOUCHSCREEN_FUJITSU is not set # CONFIG_TOUCHSCREEN_GUNZE is not set
@@ -680,6 +846,7 @@ CONFIG_INPUT_TOUCHSCREEN=y # CONFIG_TOUCHSCREEN_TOUCHIT213 is not set # CONFIG_TOUCHSCREEN_TSC2007 is not set # CONFIG_TOUCHSCREEN_W90X900 is not set +# CONFIG_TOUCHSCREEN_TPS6507X is not set # CONFIG_INPUT_MISC is not set #
@@ -689,6 +856,7 @@ CONFIG_SERIO=y CONFIG_SERIO_SERPORT=y CONFIG_SERIO_LIBPS2=y # CONFIG_SERIO_RAW is not set +# CONFIG_SERIO_ALTERA_PS2 is not set # CONFIG_GAMEPORT is not set #
@@ -701,6 +869,7 @@ CONFIG_HW_CONSOLE=y # CONFIG_VT_HW_CONSOLE_BINDING is not set CONFIG_DEVKMEM=y # CONFIG_SERIAL_NONSTANDARD is not set +# CONFIG_N_GSM is not set # # Serial drivers
@@ -716,6 +885,9 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=3 # CONFIG_SERIAL_CORE=y CONFIG_SERIAL_CORE_CONSOLE=y +# CONFIG_SERIAL_TIMBERDALE is not set +# CONFIG_SERIAL_ALTERA_JTAGUART is not set +# CONFIG_SERIAL_ALTERA_UART is not set CONFIG_UNIX98_PTYS=y # CONFIG_DEVPTS_MULTIPLE_INSTANCES is not set CONFIG_LEGACY_PTYS=y
@@ -726,6 +898,7 @@ CONFIG_HW_RANDOM=m # CONFIG_R3964 is not set # CONFIG_RAW_DRIVER is not set # CONFIG_TCG_TPM is not set +# CONFIG_RAMOOPS is not set CONFIG_I2C=y CONFIG_I2C_BOARDINFO=y CONFIG_I2C_COMPAT=y
@@ -743,7 +916,9 @@ CONFIG_I2C_DAVINCI=y # CONFIG_I2C_DESIGNWARE is not set # CONFIG_I2C_GPIO is not set # CONFIG_I2C_OCORES is not set +# CONFIG_I2C_PCA_PLATFORM is not set # CONFIG_I2C_SIMTEC is not set +# CONFIG_I2C_XILINX is not set # # External I2C/SMBus adapter drivers
@@ -754,18 +929,10 @@ CONFIG_I2C_DAVINCI=y # # Other I2C/SMBus bus drivers # -# CONFIG_I2C_PCA_PLATFORM is not set # CONFIG_I2C_STUB is not set - -# -# Miscellaneous I2C Chip support -# -# CONFIG_DS1682 is not set -# CONFIG_SENSORS_TSL2550 is not set # CONFIG_I2C_DEBUG_CORE is not set # CONFIG_I2C_DEBUG_ALGO is not set # CONFIG_I2C_DEBUG_BUS is not set -# CONFIG_I2C_DEBUG_CHIP is not set # CONFIG_SPI is not set #
@@ -780,13 +947,17 @@ CONFIG_GPIOLIB=y # # Memory mapped GPIO expanders: # +# CONFIG_GPIO_IT8761E is not set # # I2C GPIO expanders: # +# CONFIG_GPIO_MAX7300 is not set # CONFIG_GPIO_MAX732X is not set CONFIG_GPIO_PCA953X=y +# CONFIG_GPIO_PCA953X_IRQ is not set CONFIG_GPIO_PCF857X=y +# CONFIG_GPIO_ADP5588 is not set # # PCI GPIO expanders:
@@ -799,6 +970,10 @@ CONFIG_GPIO_PCF857X=y # # AC97 GPIO expanders: # + +# +# MODULbus GPIO expanders: +# # CONFIG_W1 is not set # CONFIG_POWER_SUPPLY is not set # CONFIG_HWMON is not set
@@ -811,42 +986,50 @@ CONFIG_WATCHDOG=y # # CONFIG_SOFT_WATCHDOG is not set # CONFIG_DAVINCI_WATCHDOG is not set +# CONFIG_MAX63XX_WATCHDOG is not set CONFIG_SSB_POSSIBLE=y # # Sonics Silicon Backplane # # CONFIG_SSB is not set - -# -# Multifunction device drivers -# +CONFIG_MFD_SUPPORT=y # CONFIG_MFD_CORE is not set +# CONFIG_MFD_88PM860X is not set # CONFIG_MFD_SM501 is not set # CONFIG_MFD_ASIC3 is not set # CONFIG_HTC_EGPIO is not set # CONFIG_HTC_PASIC3 is not set +# CONFIG_HTC_I2CPLD is not set # CONFIG_TPS65010 is not set +# CONFIG_TPS6507X is not set # CONFIG_TWL4030_CORE is not set +# CONFIG_MFD_TC35892 is not set # CONFIG_MFD_TMIO is not set # CONFIG_MFD_T7L66XB is not set # CONFIG_MFD_TC6387XB is not set # CONFIG_MFD_TC6393XB is not set # CONFIG_PMIC_DA903X is not set +# CONFIG_PMIC_ADP5520 is not set +# CONFIG_MFD_MAX8925 is not set # CONFIG_MFD_WM8400 is not set # CONFIG_MFD_WM831X is not set # CONFIG_MFD_WM8350_I2C is not set +# CONFIG_MFD_WM8994 is not set # CONFIG_MFD_PCF50633 is not set -# CONFIG_AB3100_CORE is not set +# CONFIG_ABX500_CORE is not set CONFIG_REGULATOR=y # CONFIG_REGULATOR_DEBUG is not set +# CONFIG_REGULATOR_DUMMY is not set # CONFIG_REGULATOR_FIXED_VOLTAGE is not set # CONFIG_REGULATOR_VIRTUAL_CONSUMER is not set # CONFIG_REGULATOR_USERSPACE_CONSUMER is not set # CONFIG_REGULATOR_BQ24022 is not set # CONFIG_REGULATOR_MAX1586 is not set +# CONFIG_REGULATOR_MAX8649 is not set +# CONFIG_REGULATOR_MAX8660 is not set # CONFIG_REGULATOR_LP3971 is not set -# CONFIG_REGULATOR_TPS65023 is not set +CONFIG_REGULATOR_TPS65023=y CONFIG_REGULATOR_TPS6507X=y # CONFIG_MEDIA_SUPPORT is not set
@@ -950,10 +1133,6 @@ CONFIG_RTC_LIB=y # CONFIG_DMADEVICES is not set # CONFIG_AUXDISPLAY is not set # CONFIG_UIO is not set - -# -# TI VLYNQ -# # CONFIG_STAGING is not set #
@@ -1033,6 +1212,22 @@ CONFIG_MISC_FILESYSTEMS=y # CONFIG_BEFS_FS is not set # CONFIG_BFS_FS is not set # CONFIG_EFS_FS is not set +CONFIG_JFFS2_FS=y +CONFIG_JFFS2_FS_DEBUG=0 +CONFIG_JFFS2_FS_WRITEBUFFER=y +# CONFIG_JFFS2_FS_WBUF_VERIFY is not set +# CONFIG_JFFS2_SUMMARY is not set +# CONFIG_JFFS2_FS_XATTR is not set +CONFIG_JFFS2_COMPRESSION_OPTIONS=y +CONFIG_JFFS2_ZLIB=y +# CONFIG_JFFS2_LZO is not set +CONFIG_JFFS2_RTIME=y +# CONFIG_JFFS2_RUBIN is not set +# CONFIG_JFFS2_CMODE_NONE is not set +CONFIG_JFFS2_CMODE_PRIORITY=y +# CONFIG_JFFS2_CMODE_SIZE is not set +# CONFIG_JFFS2_CMODE_FAVOURLZO is not set +# CONFIG_LOGFS is not set CONFIG_CRAMFS=y # CONFIG_SQUASHFS is not set # CONFIG_VXFS_FS is not set
@@ -1062,6 +1257,7 @@ CONFIG_SUNRPC=y # CONFIG_RPCSEC_GSS_SPKM3 is not set CONFIG_SMB_FS=m # CONFIG_SMB_NLS_DEFAULT is not set +# CONFIG_CEPH_FS is not set # CONFIG_CIFS is not set # CONFIG_NCP_FS is not set # CONFIG_CODA_FS is not set
@@ -1184,6 +1380,7 @@ CONFIG_DEBUG_BUGVERBOSE=y # CONFIG_BACKTRACE_SELF_TEST is not set # CONFIG_DEBUG_BLOCK_EXT_DEVT is not set # CONFIG_DEBUG_FORCE_WEAK_PER_CPU is not set +# CONFIG_LKDTM is not set # CONFIG_FAULT_INJECTION is not set # CONFIG_LATENCYTOP is not set # CONFIG_SYSCTL_SYSCALL_CHECK is not set
@@ -1205,6 +1402,7 @@ CONFIG_BRANCH_PROFILE_NONE=y # CONFIG_WORKQUEUE_TRACER is not set # CONFIG_BLK_DEV_IO_TRACE is not set # CONFIG_DYNAMIC_DEBUG is not set +# CONFIG_ATOMIC64_SELFTEST is not set # CONFIG_SAMPLES is not set CONFIG_HAVE_ARCH_KGDB=y # CONFIG_KGDB is not set
@@ -1213,6 +1411,7 @@ CONFIG_DEBUG_USER=y CONFIG_DEBUG_ERRORS=y # CONFIG_DEBUG_STACK_USAGE is not set # CONFIG_DEBUG_LL is not set +# CONFIG_OC_ETM is not set # # Security options
@@ -1220,7 +1419,11 @@ CONFIG_DEBUG_ERRORS=y # CONFIG_KEYS is not set # CONFIG_SECURITY is not set # CONFIG_SECURITYFS is not set -# CONFIG_SECURITY_FILE_CAPABILITIES is not set +# CONFIG_DEFAULT_SECURITY_SELINUX is not set +# CONFIG_DEFAULT_SECURITY_SMACK is not set +# CONFIG_DEFAULT_SECURITY_TOMOYO is not set +CONFIG_DEFAULT_SECURITY_DAC=y +CONFIG_DEFAULT_SECURITY="" CONFIG_CRYPTO=y #
@@ -1323,9 +1526,11 @@ CONFIG_CRC32=y # CONFIG_CRC7 is not set # CONFIG_LIBCRC32C is not set CONFIG_ZLIB_INFLATE=y +CONFIG_ZLIB_DEFLATE=y CONFIG_DECOMPRESS_GZIP=y CONFIG_GENERIC_ALLOCATOR=y CONFIG_HAS_IOMEM=y CONFIG_HAS_IOPORT=y CONFIG_HAS_DMA=y CONFIG_NLATTR=y +CONFIG_GENERIC_ATOMIC64=y
arch/arm/include/asm/setup.h +5 -0
@@ -143,6 +143,11 @@ struct tag_memclk {__u32 fmemclk; }; +/** MityDSP-L138 peripheral configuration info, +* see arch/arm/mach-davinci/include/mach/cb-mityomapl138.h +*/ +#define ATAG_MITYDSPL138 0x42000101 +struct tag {struct tag_header hdr;union {
arch/arm/mach-davinci/Kconfig +8 -0
@@ -178,6 +178,14 @@ config DA850_UI_RMII endchoice +config MACH_MITYOMAPL138 + bool "Critical Link MityDSP-L138/MityARM-1808 SoM" + depends on ARCH_DAVINCI_DA850 + help + Say Y here to select the Critical Link MityDSP-L138/MityARM-1808 + System on Module. Information on this SoM may be found at + http://www.mitydsp.com. + config MACH_TNETV107X bool "TI TNETV107X Reference Platform" default ARCH_DAVINCI_TNETV107X
arch/arm/mach-davinci/Makefile +1 -0
@@ -32,6 +32,7 @@ obj-$(CONFIG_MACH_DAVINCI_DM6467_EVM) += board-dm646x-evm.o cdce949.o obj-$(CONFIG_MACH_DAVINCI_DM365_EVM) += board-dm365-evm.o obj-$(CONFIG_MACH_DAVINCI_DA830_EVM) += board-da830-evm.o obj-$(CONFIG_MACH_DAVINCI_DA850_EVM) += board-da850-evm.o +obj-$(CONFIG_MACH_MITYOMAPL138) += board-mityomapl138.o obj-$(CONFIG_MACH_TNETV107X) += board-tnetv107x-evm.o # Power Management
arch/arm/mach-davinci/board-mityomapl138.c new file +806 -0
806 lines not on this page · raw message
arch/arm/mach-davinci/include/mach/cb-mityomapl138.h new file +120 -0
120 lines not on this page · raw message
arch/arm/mach-davinci/include/mach/da8xx.h +1 -0
@@ -41,6 +41,7 @@ extern void __iomem *da8xx_syscfg1_base;#define DA8XX_SYSCFG0_BASE (IO_PHYS + 0x14000)#define DA8XX_SYSCFG0_VIRT (x) (da8xx_syscfg0_base + (x))#define DA8XX_JTAG_ID_REG 0x18 +#define DA8XX_MSTPRI2_REG 0x118#define DA8XX_CFGCHIP0_REG 0x17c#define DA8XX_CFGCHIP2_REG 0x184#define DA8XX_CFGCHIP3_REG 0x188
arch/arm/mach-davinci/include/mach/uncompress.h +1 -0
@@ -88,6 +88,7 @@ static inline void __arch_decomp_setup(unsigned long arch_id)/* DA8xx boards */ DEBUG_LL_DA8XX (davinci_da830_evm,2 );DEBUG_LL_DA8XX (davinci_da850_evm,2 ); +DEBUG_LL_DA8XX (mityomapl138,1 );/* TNETV107x boards */ DEBUG_LL_TNETV107X (tnetv107x,1 );
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Quoted 11 lines · Michael Williamson
This patch adds support for the MityDSP-L138 and MityARM-1808 system on
module (SOM) under the registered machine "mityomapl138". These SOMs are based on the da850 davinci CPU architecture. Information on these SOMs may be found at http://www.mitydsp.com.Signed-off-by Michael Williamson <[email protected]>---
This patch is against Kevin's tree, but is dependent on the following patch, which is queued for 2.6.36:
Running this patch through scripts/checkpatch.pl, I get:
total: 268 errors, 586 warnings, 1632 lines checked
Please fix all errors and warnings.
For future reference, normally, I don't even read the rest of a patch if there are any checkpatch errors.
Quoted 2 lines
Changes since v3 patch was submitted:
* renamedATAG_PERIPHERALStoATAG_MITYDSPL138
This new ATAG should be a separate patch.
However, as I mentioned in earlier versions, new ATAGs are not welcome upstream, and I will not merge this. Other suggestions have been proposed to solve this.
If you insist, after the bare board support is merged, you can post your ATAG patch to linux-arm-kernel and see if Russell is willing to merge this, but I doubt it.
Quoted 9 lines
* removed unused header files
* renamed config structure items to remove camel case naming
* don't use GPIO if resources aren't acquired
* don't usedevice_initcallon emac config
* handle upcoming patch to platform sound config
* clean up mcasp configuration
* misc cleanup per commentsarch/arm/configs/da8xx_omapl_defconfig | 291 ++++++-
The defconfig change needs to be redone against current tree, since some major changes where done here for 2.6.36.
Quoted 8 lines
arch/arm/include/asm/setup.h | 5 + arch/arm/mach-davinci/Kconfig | 8 + arch/arm/mach-davinci/Makefile | 1 + arch/arm/mach-davinci/board-mityomapl138.c | 806 ++++++++++++++++++++ .../mach-davinci/include/mach/cb-mityomapl138.h | 120 +++ arch/arm/mach-davinci/include/mach/da8xx.h | 1 + arch/arm/mach-davinci/include/mach/uncompress.h | 1 + 8 files changed, 1190 insertions(+), 43 deletions(-)
Normally, I like to see new board support broken down more. It's rather difficult to do a good review of new board file when everything is added in a single patch.
Typically, a basic patch that just supports basic boot (typically to UART console) is the first patch. Then additional patches are added to add peripheral support (display, MMC, SPI, flash, regulators, ...)
Breaking things up this way helps reviewers and maintainers greatly.
[...]
arch/arm/include/asm/setup.h struct tag_memclk { · line 146
Quoted 9 lines
arch/arm/include/asm/setup.h +1
-0@@ -143,6 +143,11 @@ struct tag_memclk {__u32 fmemclk; }; +/** MityDSP-L138 peripheral configuration info,
please fix multi-line comment style. search for 'multi-line' in Documentation/CodingStytle. There are several instances of this problem in the patch.
Quoted 54 lines
arch/arm/include/asm/setup.h +4
-0+* see arch/arm/mach-davinci/include/mach/cb-mityomapl138.h +*/ +#define ATAG_MITYDSPL138 0x42000101 +struct tag {struct tag_header hdr;union {arch/arm/mach-davinci/Kconfig +8
-0@@ -178,6 +178,14 @@ config DA850_UI_RMII endchoice +config MACH_MITYOMAPL138 + bool "Critical Link MityDSP-L138/MityARM-1808 SoM" + depends on ARCH_DAVINCI_DA850 + help + Say Y here to select the Critical Link MityDSP-L138/MityARM-1808 + System on Module. Information on this SoM may be found at + http://www.mitydsp.com. + config MACH_TNETV107X bool "TI TNETV107X Reference Platform" default ARCH_DAVINCI_TNETV107Xarch/arm/mach-davinci/Makefile +1
-0@@ -32,6 +32,7 @@ obj-$(CONFIG_MACH_DAVINCI_DM6467_EVM) += board-dm646x-evm.o cdce949.o obj-$(CONFIG_MACH_DAVINCI_DM365_EVM) += board-dm365-evm.o obj-$(CONFIG_MACH_DAVINCI_DA830_EVM) += board-da830-evm.o obj-$(CONFIG_MACH_DAVINCI_DA850_EVM) += board-da850-evm.o +obj-$(CONFIG_MACH_MITYOMAPL138) += board-mityomapl138.o obj-$(CONFIG_MACH_TNETV107X) += board-tnetv107x-evm.o # Power Managementarch/arm/mach-davinci/board-mityomapl138.c new file +10
-0@@ -0,0 +1,806 @@ +/* +* Critical Link MityOMAP-L138 SoM +* +* Copyright (C) 2010 Critical Link LLC - http://www.criticallink.com +* +* Derived from board-da850-evm.c +* Original Copyrights follow: +* +* Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/ +*
arch/arm/mach-davinci/board-mityomapl138.c line 20
Quoted 10 lines
arch/arm/mach-davinci/board-mityomapl138.c new file +10
-0+* Derived from: arch/arm/mach-davinci/board-da830-evm.c +* Original Copyrights follow: +* +* 2007, 2009 (c) MontaVista Software, Inc. This file is licensed under +* the terms of the GNU General Public License version 2. This program +* is licensed "as is" without any warranty of any kind, whether express +* or implied. +*/ + +#define pr_fmt (fmt) "%s: " fmt, __func__
I don't find any users of this in the patch. Please remove.
arch/arm/mach-davinci/board-mityomapl138.c line 26
Quoted 5 lines
arch/arm/mach-davinci/board-mityomapl138.c new file +5
-0+#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/console.h> +#include <linux/i2c.h> +#include <linux/i2c/at24.h>
I don't think you need at24.h here. Please remove any headers that you are not actually using.
[...]
Kevin
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Hi Kevin,
Quoted 15 lines · Kevin Hilman
Quoted 5 lines · Michael Williamson
This patch adds support for the MityDSP-L138 and MityARM-1808 system on
module (SOM) under the registered machine "mityomapl138". These SOMs are based on the da850 davinci CPU architecture. Information on these SOMs may be found at http://www.mitydsp.com.Quoted 7 lines
Signed-off-by Michael Williamson<[email protected]>---
This patch is against Kevin's tree, but is dependent on the following patch, which is queued for 2.6.36:
Quoted 10 lines
Running this patch through
scripts/checkpatch.pl, I get:total: 268 errors, 586 warnings, 1632 lines checkedPlease fix all errors and warnings.
For future reference, normally, I don't even read the rest of a patch if there are any checkpatch errors.
As expected. At the time I submitted this (before your comments came in on V3, actually), I had run a checkpatch.pl and it had passed. That was prior to the 2.6.35 merge when you got back from vacation. Given your comments on V3, I had withdrawn the submission. This submission should have been dropped. I'm sorry if I generated extra reviewing work for you. I didn't catch that our thread of discussion was on the V3 submission.
Please drop all submissions relating to this subject. If there was something
more I should have done, please let me know.
Quoted 5 lines
Quoted 3 lines
Changes since v3 patch was submitted:
* renamedATAG_PERIPHERALStoATAG_MITYDSPL138This new ATAG should be a separate patch.
Quoted 8 lines
However, as I mentioned in earlier versions, new ATAGs are not welcome upstream, and I will not merge this. Other suggestions have been proposed to solve this.
If you insist, after the bare board support is merged, you can post your ATAG patch to linux-arm-kernel and see if Russell is willing to merge this, but I doubt it.
Understood. Not trying to use this ATAG patch for the mainline anymore, trying other techniques but not ready for resubmission.
Quoted 9 lines
Quoted 9 lines
* removed unused header files
* renamed config structure items to remove camel case naming
* don't use GPIO if resources aren't acquired
* don't usedevice_initcallon emac config
* handle upcoming patch to platform sound config
* clean up mcasp configuration
* misc cleanup per comments
Quoted 5 lines
Quoted 2 lines
arch/arm/configs/da8xx_omapl_defconfig | 291 ++++++-The defconfig change needs to be redone against current tree, since some major changes where done here for 2.6.36.
I saw that go by. If I get around to a resubmission, I'll be sure to sync up.
Quoted 14 lines
Quoted 10 lines
arch/arm/include/asm/setup.h | 5 + arch/arm/mach-davinci/Kconfig | 8 + arch/arm/mach-davinci/Makefile | 1 + arch/arm/mach-davinci/board-mityomapl138.c | 806 ++++++++++++++++++++ .../mach-davinci/include/mach/cb-mityomapl138.h | 120 +++ arch/arm/mach-davinci/include/mach/da8xx.h | 1 + arch/arm/mach-davinci/include/mach/uncompress.h | 1 + 8 files changed, 1190 insertions(+), 43 deletions(-)Normally, I like to see new board support broken down more. It's rather difficult to do a good review of new board file when everything is added in a single patch.
Quoted 8 lines
Typically, a basic patch that just supports basic boot (typically to UART console) is the first patch. Then additional patches are added to add peripheral support (display, MMC, SPI, flash, regulators, ...)
Breaking things up this way helps reviewers and maintainers greatly.
[...]
OK. Most of the board file is a large cut-and-paste of the da850 EVM. It seems unlikely that I'll have any measure of success here, but if I get time I might try again.
Quoted 9 lines
Quoted 9 lines
arch/arm/include/asm/setup.h +0
-0@@ -143,6 +143,11 @@ struct tag_memclk {__u32 fmemclk; };
Quoted 7 lines
arch/arm/include/asm/setup.h struct tag_memclk { · line 147
Quoted 2 lines
arch/arm/include/asm/setup.h +1
-0+/** MityDSP-L138 peripheral configuration info, please fix multi-line comment style. search for 'multi-line' in
Documentation/CodingStytle. There are several instances of this problem in the patch.
OK. I'll watch for that if I resubmit. Thanks.
Quoted 58 lines
Quoted 58 lines
arch/arm/include/asm/setup.h +4
-0+* see arch/arm/mach-davinci/include/mach/cb-mityomapl138.h +*/ +#define ATAG_MITYDSPL138 0x42000101 +struct tag {struct tag_header hdr;union {arch/arm/mach-davinci/Kconfig +8
-0@@ -178,6 +178,14 @@ config DA850_UI_RMII endchoice +config MACH_MITYOMAPL138 + bool "Critical Link MityDSP-L138/MityARM-1808 SoM" + depends on ARCH_DAVINCI_DA850 + help + Say Y here to select the Critical Link MityDSP-L138/MityARM-1808 + System on Module. Information on this SoM may be found at + http://www.mitydsp.com. + config MACH_TNETV107X bool "TI TNETV107X Reference Platform" default ARCH_DAVINCI_TNETV107Xarch/arm/mach-davinci/Makefile +1
-0@@ -32,6 +32,7 @@ obj-$(CONFIG_MACH_DAVINCI_DM6467_EVM) += board-dm646x-evm.o cdce949.o obj-$(CONFIG_MACH_DAVINCI_DM365_EVM) += board-dm365-evm.o obj-$(CONFIG_MACH_DAVINCI_DA830_EVM) += board-da830-evm.o obj-$(CONFIG_MACH_DAVINCI_DA850_EVM) += board-da850-evm.o +obj-$(CONFIG_MACH_MITYOMAPL138) += board-mityomapl138.o obj-$(CONFIG_MACH_TNETV107X) += board-tnetv107x-evm.o # Power Managementarch/arm/mach-davinci/board-mityomapl138.c new file +14
-0@@ -0,0 +1,806 @@ +/* +* Critical Link MityOMAP-L138 SoM +* +* Copyright (C) 2010 Critical Link LLC - http://www.criticallink.com +* +* Derived from board-da850-evm.c +* Original Copyrights follow: +* +* Copyright (C) 2009 Texas Instruments Incorporated - http://www.ti.com/ +* +* Derived from: arch/arm/mach-davinci/board-da830-evm.c +* Original Copyrights follow: +* +* 2007, 2009 (c) MontaVista Software, Inc. This file is licensed under
Quoted 10 lines
arch/arm/mach-davinci/board-mityomapl138.c line 20
Quoted 7 lines
arch/arm/mach-davinci/board-mityomapl138.c new file +6
-0+* the terms of the GNU General Public License version 2. This program +* is licensed "as is" without any warranty of any kind, whether express +* or implied. +*/ + +#define pr_fmt (fmt) "%s: " fmt, __func__I don't find any users of this in the patch. Please remove.
OK. Thanks (I had another comment recommending I use that).
Quoted 9 lines
arch/arm/mach-davinci/board-mityomapl138.c line 25
Quoted 6 lines
arch/arm/mach-davinci/board-mityomapl138.c new file +5
-0+#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/console.h> +#include <linux/i2c.h> +#include <linux/i2c/at24.h> I don't think you need
at24.hhere. Please remove any headers that you are not actually using.
Quoted 4 lines
[...]
Kevin
Thanks.
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Quoted 26 lines · Michael Williamson
Hi Kevin,
Quoted 23 lines · Kevin Hilman
Quoted 6 lines · Michael Williamson
This patch adds support for the MityDSP-L138 and MityARM-1808
system on
module (SOM) under the registered machine "mityomapl138". These SOMs are based on the da850 davinci CPU architecture. Information on these SOMs may be found at http://www.mitydsp.com.Quoted 9 lines
Signed-off-by Michael Williamson<[email protected]>---
This patch is against Kevin's tree, but is dependent on the following patch,
which is queued for 2.6.36:Running this patch through
scripts/checkpatch.pl, I get:total: 268 errors, 586 warnings, 1632 lines checkedPlease fix all errors and warnings.
Quoted 7 lines
Quoted 3 lines
For future reference, normally, I don't even read the rest of a patch if there are any checkpatch errors.
As expected. At the time I submitted this (before your comments came in on V3, actually), I had run a checkpatch.pl and it had passed. That was prior to the 2.6.35 merge when you got back from vacation.
That should have read 2.6.36. I also must have blown the checkpatch as well.
-Mike
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
In reply to Michael WilliamsonQuoted 8 lines · Michael Williamson
Quoted 8 lines
Normally, I like to see new board support broken down more. It's rather difficult to do a good review of new board file when everything is added in a single patch.
Typically, a basic patch that just supports basic boot (typically to UART console) is the first patch. Then additional patches are added to add peripheral support (display, MMC, SPI, flash, regulators, ...)
Quoted 7 lines
Quoted 4 lines
Breaking things up this way helps reviewers and maintainers greatly.
[...]
OK. Most of the board file is a large cut-and-paste of the da850 EVM. It seems unlikely that I'll have any measure of success here, but if I get time I might try again.
OK, if it's mostly a cut-and-paste of da850, then maybe just break it up into two patches, 1) the cut, paste & rename patch and 2) a separate patch for things that are different on your board.
Thanks,
Kevin
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Quoted 20 lines · Kevin Hilman
Quoted 8 lines · Michael Williamson
Quoted 8 lines
Normally, I like to see new board support broken down more. It's rather difficult to do a good review of new board file when everything is added in a single patch.
Typically, a basic patch that just supports basic boot (typically to UART console) is the first patch. Then additional patches are added to add peripheral support (display, MMC, SPI, flash, regulators, ...)
Quoted 9 lines
Quoted 5 lines
Breaking things up this way helps reviewers and maintainers greatly.
[...]
OK. Most of the board file is a large cut-and-paste of the da850 EVM. It seems unlikely that I'll have any measure of success here, but if I get time I might try again.
Quoted 8 lines
OK, if it's mostly a cut-and-paste of da850, then maybe just break it up into two patches, 1) the cut, paste& rename patch and 2) a separate patch for things that are different on your board.
Thanks,
Kevin
I think I am going to try again. I intend to basically start over, leaving the console UART, NAND, and EMAC (hardcoded to MII interface for now). This is the minimum set of devices I need to get one of our base boards to boot and mount a root filesystem and run some tests here.
I will remove all the ATAG garbage and anything that is runtime configurable as well as the LCD, McASP, SPI, SPI-NOR, and I2C based peripherals. If the patch is OK, then I'll add them back one by one for review.
Would this be a reasonable approach? And should I post it as a v5 to this series or create a different series (given the large change of code)?
Should I pull the general ARM mailing list off the distribution as this should
now be specific only to mach-davinci?
Thanks again for any insight.
-Mike
PATCH v4 1/1 davinci: Add MityDSP-L138/MityARM-1808 SOM support
Quoted 35 lines · Michael Williamson
Quoted 20 lines · Kevin Hilman
Quoted 8 lines · Michael Williamson
Quoted 8 lines
Normally, I like to see new board support broken down more. It's rather difficult to do a good review of new board file when everything is added in a single patch.
Typically, a basic patch that just supports basic boot (typically to UART console) is the first patch. Then additional patches are added to add peripheral support (display, MMC, SPI, flash, regulators, ...)
Quoted 9 lines
Quoted 5 lines
Breaking things up this way helps reviewers and maintainers greatly.
[...]
OK. Most of the board file is a large cut-and-paste of the da850 EVM. It seems unlikely that I'll have any measure of success here, but if I get time I might try again.
Quoted 8 lines
OK, if it's mostly a cut-and-paste of da850, then maybe just break it up into two patches, 1) the cut, paste& rename patch and 2) a separate patch for things that are different on your board.
Thanks,
Kevin
I think I am going to try again. I intend to basically start over, leaving the console UART, NAND, and EMAC (hardcoded to MII interface for now). This is the minimum set of devices I need to get one of our base boards to boot and mount a root filesystem and run some tests here.
Quoted 5 lines
I will remove all the ATAG garbage and anything that is runtime configurable as well as the LCD, McASP, SPI, SPI-NOR, and I2C based peripherals. If the patch is OK, then I'll add them back one by one for review.
Would this be a reasonable approach?
Yes, perfect!
Quoted 2 lines
And should I post it as a v5 to this
series or create a different series (given the large change of code)?
A new series is fine.
Quoted 2 lines
Should I pull the general ARM mailing list off the distribution as this should now be specific only to mach-davinci?
Keeping linux-arm-kernel in copy is good.
Kevin
mmc over SPI on DM6467 based board. card not detected.
Hi all,
I am trying to mount SD-Card over SPI on our custom DM6467
board. davinci spi controller driver and mmc over spi drver are selected in the menuconfig. i am using davinci-PSP.03-XX-00-37 kernel. I have also edited board initialization file to probe the MMC card under SPI as below:
static struct spi_board_info dm646x_spi_info[] __initconst = {
#ifdef CONFIG_MMC_SPI
{
.modalias = "mmc_spi",
.max_speed_hz = (750 * 1000 ), /* max spi clock (SCK)
speed in HZ */
.bus_num = 0,
.chip_select =
0,
/* CS0 */
.mode = SPI_MODE_0,
},
#endif
The kernel boots with following log
spi_davinci spi_davinci.0: DaVinci SPI driver in EDMA mode
Using RX channel = 17 , TX channel = 16 and event queue = 3
spi_davinci spi_davinci.0:
Controller at 0xfec66800
?????
????..
mmc_spi spi0.0: ASSUMING SPI bus stays unshared!
mmc_spi spi0.0: ASSUMING 3.2-3.4 V slot power
mmc0: clock 0Hz busmode 0 powermode 0 cs 0 Vdd 0 width 0 timing 0
mmc_spi spi0.0: SD/MMC host mmc0, no WP, no poweroff
mmc0: clock 0Hz busmode 2 powermode 1 cs 1 Vdd 21 width 0 timing 0
mmc_spi spi0.0: mmc_spi: power up
(21)
mmc0: Minimum clock frequency too high for identification mode
mmc0: clock 750000Hz busmode 2 powermode 2 cs 1 Vdd 21 width 0 timing 0
mmc_spi spi0.0: mmc_spi: power on
(21)
mmc_spi spi0.0: can't change chip-select polarity 1
mmc0: starting CMD52 arg 80000c08 flags 00000015
mmc_spi spi0.0: bogus command
Backtrace:
[<c002a7d0>]
(dump_backtrace+0x0/0x114) from [<c023f5e4>] (dump_stack+0x18/0x1c)
r7:ce0bf400 r6:ce0bf400
r5:ce0bf5c0 r4:00000000
[<c023f5cc>]
(dump_stack+0x0/0x1c) from [<c01af3f0>] (mmc_spi_request+0xa8/0x9d8)
[<c01af348>] (mmc_spi_request+0x0/0x9d8) from [<c01a75f8>] (mmc_wait_for_req+0x1f4/0x21c)
[<c01a7404>]
(mmc_wait_for_req+0x0/0x21c) from [<c01a768c>] (mmc_wait_for_cmd+0x6c/0x7c)
r7:00000000 r6:ce0bf400
r5:ce091f1c r4:ce091ee4
[<c01a7620>]
(mmc_wait_for_cmd+0x0/0x7c) from [<c01ab4f0>] (mmc_reset_sdio+0x5c/0x6c)
r7:ce090000 r6:ce0bf550
r5:ce0bf400 r4:ce091f1c
[<c01ab494>]
(mmc_reset_sdio+0x0/0x6c) from [<c01a71f0>] (mmc_rescan+0x24c/0x2ec)
r5:60000013 r4:ce0bf400
[<c01a6fa4>]
(mmc_rescan+0x0/0x2ec) from [<c004eb28>] (worker_thread+0x138/0x1f8)
r6:ce092de0 r5:ce0bf550
r4:ce0bf554
[<c004e9f0>]
(worker_thread+0x0/0x1f8) from [<c0052904>] (kthread+0x88/0x90)
[<c005287c>] (kthread+0x0/0x90) from [<c003f9b8>] (do_exit+0x0/0x684)
r7:00000000 r6:00000000
r5:00000000 r4:00000000
mmc0: req done (CMD52): -22:
00000000 00000000 00000000 00000000
mmc0: starting CMD0 arg 00000000 flags 000000c0
mmc_spi spi0.0: mmc_spi:
CMD0, resp R1
I am not able to identify the micro SD card. Is there
anything which i am missing?
Regards,
Sumesh.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100828/1ca3b06c/attachment-0001.html>
mmc over SPI on DM6467 based board. card not detected.
Quoted 38 lines · Sumesh Kaana
Hi all,
I am trying to mount SD-Card over SPI on our custom DM6467 board. davinci spi controller driver and mmc over spi drver are selected in the menuconfig. i am using davinci-PSP.03-XX-00-37 kernel.
I have also edited board initialization file to probe the MMC card under SPI as below:
static struct
spi_board_infodm646x_spi_info[]__initconst= {#ifdef
CONFIG_MMC_SPI??????? {
??????????????? .modalias = "
mmc_spi",??????????????? .max_speed_hz = (750 * 1000 ),???? /* max spi clock (SCK) speed in HZ */
??????????????? .bus_num = 0,
??????????????? .chip_select = 0,?????????????????????? /* CS0 */
??????????????? .mode?????????? =
SPI_MODE_0,??????? },
#endif
The kernel boots with following log
...
Quoted 1 line
mmc0: Minimum clock frequency too high for identification mode
...
Have you tried lower the clock frequency?
Steve
mmc over SPI on DM6467 based board. card not detected.
Quoted 33 lines · Steve Chen
Quoted 32 lines · Sumesh Kaana
I am trying to mount SD-Card over SPI on our custom DM6467 board. davinci spi controller driver and mmc over spi drver are selected in the menuconfig. i am using davinci-PSP.03-XX-00-37 kernel.
I have also edited board initialization file to probe the MMC card under SPI as below:
static struct
spi_board_infodm646x_spi_info[]__initconst= {#ifdef
CONFIG_MMC_SPI{ .modalias = "mmc_spi", .max_speed_hz = (750 * 1000 ), /* max spi clock (SCK)speed in HZ */
.bus_num = 0,
.chip_select = 0, /* CS0 */
.mode =
SPI_MODE_0,},
#endif
Quoted 7 lines
Quoted 2 lines
The kernel boots with following log
...
Quoted 1 line
mmc0: Minimum clock frequency too high for identification mode
...
Have you tried lower the clock frequency?
The initial card identification should be done at 400kHz. If that is successful, the following commands can be sent at your maximum rate.
M
mmc over SPI on DM6467 based board. card not detected.
In reply to Sumesh KaanaQuoted 10 lines · Sumesh Kaana
Hi all,
I am trying to mount SD-Card over SPI on our custom DM6467 board. davinci spi controller driver and mmc over spi drver are selected in the menuconfig. i am using davinci-PSP.03-XX-00-37 kernel.
I have also edited board initialization file to probe the MMC card under SPI as below:
First, make sure
a) you provide 3.3v and ground properly.
b) the slot, card and connections are OK by using spi_gpio driver to run the same pins,
if the SPI controller pins could be muxed into GPIO mode(usually
they could be).
Probably the source clock doesn't allow for scaling down to within 400KHz, give it a closer look.