e4defrag: relevant file fragmentation: fix arithmetic error as non-root
PATCH 1/1 e4defrag: relevant file fragmentation: fix arithmetic error as non-root
hi Kazuya Mio,
I found a bug on your patch "[RFC][PATCH V2 5/5] e4defrag: add solving relevant file fragmentation mode"
The variable "blocks_per_group" is only initialized as root cause of restrict access to the super-block. As a non root user this cause an arithmetic error in function relevant_balloc.
misc/e4defrag.c +0 -2
@@ -1662,14 +1662,15 @@ static int relevant_balloc(const char *file, int donor_fd,/* Allocating all blocks in an extent group */ while (rest >0 ) { -int grp_offset; - grp_offset = (pi.pi_pstart - first_data_block) % bpg;
Hi Andreas,
I will send the patch "[RFC][PATCH V2 5/5] e4defrag: add solving relevant file fragmentation mode" includes your patches next time.
Quoted 4 lines · Andreas Rid
I found a bug on your patch "[RFC][PATCH V2 5/5] e4defrag: add solving relevant file fragmentation mode"
The variable "
blocks_per_group" is only initialized as root cause of restrict access to the super-block. As a non root user this cause an arithmetic error in functionrelevant_balloc
You're right. Thanks.
Regards,
Kazuya Mio