Ncurses and --disable-static

A little question for anyone out there:

The makefile for ncurses contains the following:

    ifneq ($(BR2_PACKAGE_NCURSES_TARGET_HEADERS),y)
    NCURSES_CONF_OPT += --disable-static
    endif

but BR2_PACKAGE_NCURSES_TARGET_HEADERS is no longer defined in the ncurses' Config.in, this was removed in a change to using BR2_HAVE_DEVFILES to decide to install headers in the target (see commit 58508f3 by Peter Korsgaard).

Now as a result of this ncurses is now always configured with --disable-static, even when BR2_HAVE_DEVFILES is set to "y".

So my question is should "--disable-stable" be added to NCURSES_CONF_OPT:

1. always,
2. never, or
3. when BR2_HAVE_DEVFILES is "y" (instead of using BR2_PACKAGE_NCURSES_TARGET_HEADERS).

Regards,

Ian.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100830/a6627f69/attachment.html>

Ian> A little question for anyone out there:
Ian> The makefile for ncurses contains the following:

 Ian>     ifneq ($(BR2_PACKAGE_NCURSES_TARGET_HEADERS),y)
 Ian>     NCURSES_CONF_OPT += --disable-static
 Ian>     endif

Ian> but BR2_PACKAGE_NCURSES_TARGET_HEADERS is no longer defined in the ncurses' Ian> Config.in, this was removed in a change to using BR2_HAVE_DEVFILES to decide to Ian> install headers in the target (see commit 58508f3 by Peter Korsgaard).

Ian> Now as a result of this ncurses is now always configured with Ian> --disable-static, even when BR2_HAVE_DEVFILES is set to "y".

Thanks for informing us.

Ian> So my question is should "--disable-stable" be added to NCURSES_CONF_OPT:

 Ian>  1. always,
 Ian>  2. never, or
 Ian>  3. when BR2_HAVE_DEVFILES is "y" (instead of using

Ian> BR2_PACKAGE_NCURSES_TARGET_HEADERS).

Either always or never. We have a mix of enable/disable-static in the tree, so we don't have a clear winner, but as we have been using always for almost 1 year now, and it cuts down on compilation time I'm going to go with "always".

Thanks.

Bye, Peter Korsgaard