Skip to contentSkip to conversation

1/1] Allow unconfined domains to mmap low conditionally.

PATCH New Dominick Grift 3 participants 5 messages Sep 1, 2010 – Sep 3, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 1/1] Allow unconfined domains to mmap low conditionally.

Allow unconfined domains to mmap low conditionally.

---
:100644 100644 416e668... a1bfac5... M policy/modules/system/unconfined.if

 policy/modules/system/unconfined.if |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
policy/modules/system/unconfined.if +1 -0
index 416e668..a1bfac5 100644
@@ -37,6 +37,7 @@ interface(`unconfined_domain_noaudit',`
 	kernel_unconfined($1)
 	corenet_unconfined($1)
 	dev_unconfined($1)
+	domain_mmap_low($1)
 	domain_unconfined($1)
 	domain_dontaudit_read_all_domains_state($1)
 	domain_dontaudit_ptrace_all_domains($1)
Signature · 9 lines
1.7.2.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100901/67528464/attachment.bin 
#1 lore raw

PATCH 1/1 1/1] Allow unconfined domains to mmap low conditionally.

Quoted 1 line · Dominick Grift

Allow unconfined domains to mmap low conditionally.

I'm very concerned about adding this to all unconfined domains, even if its conditional.

Is this from the Fedora policy?

Quoted 18 lines

---
:100644 100644 416e668... a1bfac5... M policy/modules/system/unconfined.if

  policy/modules/system/unconfined.if |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
policy/modules/system/unconfined.if +1 -0
index 416e668..a1bfac5 100644
@@ -37,6 +37,7 @@ interface(`unconfined_domain_noaudit',`
  	kernel_unconfined($1)
  	corenet_unconfined($1)
  	dev_unconfined($1)
+	domain_mmap_low($1)
  	domain_unconfined($1)
  	domain_dontaudit_read_all_domains_state($1)
  	domain_dontaudit_ptrace_all_domains($1)
Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
#2 lore raw

PATCH 1/1 1/1] Allow unconfined domains to mmap low conditionally.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 14 lines · Christopher J. PeBenito
Quoted 1 line · Dominick Grift

Allow unconfined domains to mmap low conditionally.

I'm very concerned about adding this to all unconfined domains, even if its conditional.

Is this from the Fedora policy?

Quoted 6 lines

---
:100644 100644 416e668... a1bfac5... M policy/modules/system/unconfined.if

  policy/modules/system/unconfined.if |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 13 lines

policy/modules/system/unconfined.if interface(`unconfined_domain_noaudit',` · line 43

Quoted 12 lines
policy/modules/system/unconfined.if +1 -0
index 416e668..a1bfac5 100644
@@ -37,6 +37,7 @@ interface(`unconfined_domain_noaudit',`
  	kernel_unconfined($1)
  	corenet_unconfined($1)
  	dev_unconfined($1)
+	domain_mmap_low($1)
  	domain_unconfined($1)
  	domain_dontaudit_read_all_domains_state($1)
  	domain_dontaudit_ptrace_all_domains($1)

Yes. The problem is not adding it, proves to be useless. Since an unconfined domain can do

Download mmap_zero_breakin /tmp/
chcon -t wine_exec_t /tmp/mmap_zero_breakin
/tmp/mmap_zero_breakin

Removing this line will just cause AVC's from random wine apps and add no security.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyBDJ4ACgkQrlYvE4MpobPSBwCfXPwVcpNDSzXaqshzPD95Tr9J HuYAnipz0i0ey2+08mmEcxw465ti3Z7I
=1iju
-----END PGP SIGNATURE-----

#3 lore raw

PATCH 1/1 1/1] Allow unconfined domains to mmap low conditionally.

Quoted 35 lines · Daniel J Walsh

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 14 lines · Christopher J. PeBenito
Quoted 1 line · Dominick Grift

Allow unconfined domains to mmap low conditionally.

I'm very concerned about adding this to all unconfined domains, even if its conditional.

Is this from the Fedora policy?

Quoted 6 lines

---
:100644 100644 416e668... a1bfac5... M policy/modules/system/unconfined.if

   policy/modules/system/unconfined.if |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 13 lines

policy/modules/system/unconfined.if interface(`unconfined_domain_noaudit',` · line 43

Quoted 12 lines
policy/modules/system/unconfined.if +1 -0
index 416e668..a1bfac5 100644
@@ -37,6 +37,7 @@ interface(`unconfined_domain_noaudit',`
   	kernel_unconfined($1)
   	corenet_unconfined($1)
   	dev_unconfined($1)
+	domain_mmap_low($1)
   	domain_unconfined($1)
   	domain_dontaudit_read_all_domains_state($1)
   	domain_dontaudit_ptrace_all_domains($1)

Yes. The problem is not adding it, proves to be useless. Since an unconfined domain can do

Quoted 6 lines

Download mmap_zero_breakin /tmp/
chcon -t wine_exec_t /tmp/mmap_zero_breakin
/tmp/mmap_zero_breakin

Removing this line will just cause AVC's from random wine apps and add no security.

Thats true, assuming any of the 3 domains that have the permission are in the policy. However, it's legitimate uses are so uncommon that I'm not willing to add it to unconfined. As for wine, if I recall correctly, you told me wine only needs it for 16bit DOS apps, so random wine apps hitting this seems unlikely.

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
#4 lore raw

PATCH 1/1 1/1] Allow unconfined domains to mmap low conditionally.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 42 lines · Christopher J. PeBenito
Quoted 41 lines · Daniel J Walsh

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 15 lines · Christopher J. PeBenito
Quoted 1 line · Dominick Grift

Allow unconfined domains to mmap low conditionally.

I'm very concerned about adding this to all unconfined domains, even if its conditional.

Is this from the Fedora policy?

Quoted 7 lines

---
:100644 100644 416e668... a1bfac5... M
policy/modules/system/unconfined.if

   policy/modules/system/unconfined.if |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 14 lines

policy/modules/system/unconfined.if interface(`unconfined_domain_noaudit',` · line 43

Quoted 13 lines
policy/modules/system/unconfined.if +1 -0
index 416e668..a1bfac5 100644
@@ -37,6 +37,7 @@ interface(`unconfined_domain_noaudit',`
       kernel_unconfined($1)
       corenet_unconfined($1)
       dev_unconfined($1)
+    domain_mmap_low($1)
       domain_unconfined($1)
       domain_dontaudit_read_all_domains_state($1)
       domain_dontaudit_ptrace_all_domains($1)

Yes. The problem is not adding it, proves to be useless. Since an unconfined domain can do

Download mmap_zero_breakin /tmp/
chcon -t wine_exec_t /tmp/mmap_zero_breakin
/tmp/mmap_zero_breakin

Quoted 9 lines
Quoted 2 lines

Removing this line will just cause AVC's from random wine apps and add no security.

Thats true, assuming any of the 3 domains that have the permission are in the policy. However, it's legitimate uses are so uncommon that I'm not willing to add it to unconfined. As for wine, if I recall correctly, you told me wine only needs it for 16bit DOS apps, so random wine apps hitting this seems unlikely.

Every wine app complains about it, but it seems lots work without it. Well as well as wine apps work, after fighting with itunes for my son the other night, I remember why I hate wine...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkyBHWUACgkQrlYvE4MpobNGwQCg4Zv6XZzU7xpLVQyLmEIAdWhY FZwAoIS/3/RZNuCnQ9VDJv1nm/yzZxBp
=m+Bx
-----END PGP SIGNATURE-----