libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement
PATCH 1/1 libvendor/osm_vendor_ibumad_sa.c: remove useless "if" statement
Content of p_query_req_copy is used in the function, so no point checking if it's NULL before the free().
--- opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
opensm/libvendor/osm_vendor_ibumad_sa.c +1 -2
@@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw)if ((p_query_req_copy->flags &OSM_SA_FLAGS_SYNC ) ==OSM_SA_FLAGS_SYNC )cl_event_signal (&p_bind->sync_event); -if (p_query_req_copy) -free (p_query_req_copy); +free (p_query_req_copy);OSM_LOG_EXIT (p_bind->p_log); }
Signature · 6 lines
1.6.2.4 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 4C8656B0.5050104-VPRAkNaXOzVS1MOuV/[email protected]
Quoted 6 lines · Yevgeny Kliteynik
Content of
p_query_req_copyis used in the function, so no point checking if it's NULL before thefree().Signed-off-by Yevgeny Kliteynik <[email protected]>---
opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +--
Same change could be done for osm_vendor_mlx_sa.c too.
-- Hal
Quoted 19 lines
1 files changed, 1 insertions(+), 2 deletions(-)opensm/libvendor/osm_vendor_ibumad_sa.c +1
-3@@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw) if ((p_query_req_copy->flags & OSM_SA_FLAGS_SYNC) == OSM_SA_FLAGS_SYNC) cl_event_signal(&p_bind->sync_event); - if (p_query_req_copy) - free(p_query_req_copy); + free(p_query_req_copy); OSM_LOG_EXIT(p_bind->p_log); } --1.6.2.4
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): AANLkTingExvAshGM6uOQhy3TNFwH7dSrF6fWXYzGxke4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 10 lines · Hal Rosenstock
Quoted 6 lines · Yevgeny Kliteynik
Content of
p_query_req_copyis used in the function, so no point checking if it's NULL before thefree().Signed-off-by Yevgeny Kliteynik<[email protected]>--- opensm/libvendor/osm_vendor_ibumad_sa.c | 3 +--Same change could be done for
osm_vendor_mlx_sa.ctoo.
Sure, thanks.
-- Yevgeny
Quoted 18 lines
-- Hal
Quoted 16 lines
1 files changed, 1 insertions(+), 2 deletions(-)opensm/libvendor/osm_vendor_ibumad_sa.c +1
-2@@ -199,8 +199,7 @@ static void __osmv_sa_mad_err_cb(IN void *bind_context, IN osm_madw_t * p_madw)if ((p_query_req_copy->flags&OSM_SA_FLAGS_SYNC ) ==OSM_SA_FLAGS_SYNC )cl_event_signal (&p_bind->sync_event); -if (p_query_req_copy) -free (p_query_req_copy); +free (p_query_req_copy);OSM_LOG_EXIT (p_bind->p_log); }
Quoted 9 lines
Quoted 8 lines
--
1.6.2.4--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Sasha Khapyorsky
AppliedQuoted 4 lines · Yevgeny Kliteynik
Content of
p_query_req_copyis used in the function, so no point checking if it's NULL before thefree().Signed-off-by Yevgeny Kliteynik <[email protected]>
Applied. Thanks.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html