serial: Update parameters after load
PATCH 1/1 serial: Update parameters after load
Hi,
this is the patch to update serial port parameters after guest is already loaded.
--- hw/serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
hw/serial.c +1 -0
@@ -674,6 +674,7 @@ static int serial_post_load(void *opaque, int version_id) }/* Initialize fcr via setter to perform essential side-effects */ serial_ioport_write (s,0x02 , s->fcr_vmstate); +serial_update_parameters (s);return 0 ; }
Signature · 1 line
1.7.2.3
Quoted 4 lines · Michal Novotny
Hi,
this is the patch to update serial port parameters after guest is already loaded.
Hi
This patch didn't apply:
% git am -s ~/.maildir/minovotn/
Applying: serial: Update parameters after load
error: patch failed: hw/serial.c:674
error: hw/serial.c: patch does not apply
Patch failed at 0001 serial: Update parameters after load When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort"
Quoted 2 lines
Signed-off-by Michal Novotny<[email protected]>
^^^^
missing spaceI manually fixed both errors and applied it.
Cheers,
Edgar
Quoted 18 lines
--- hw/serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)hw/serial.c +1
-0@@ -674,6 +674,7 @@ static int serial_post_load(void *opaque, int version_id) }/* Initialize fcr via setter to perform essential side-effects */ serial_ioport_write (s,0x02 , s->fcr_vmstate); +serial_update_parameters (s);return 0 ; }Signature · 1 line
1.7.2.3
Quoted 21 lines · Edgar E. Iglesias
Quoted 5 lines · Michal Novotny
Hi,
this is the patch to update serial port parameters after guest is already loaded.
Hi
This patch didn't apply:
% git am -s ~/.maildir/minovotn/
Applying: serial: Update parameters after load
error: patch failed:hw/serial.c:674
error:hw/serial.c: patch does not apply
Patch failed at 0001 serial: Update parameters after load When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort"
Quoted 5 lines
Quoted 2 lines
Signed-off-by Michal Novotny<[email protected]>^^^^ missing space
Hi, thanks. Nevetheless should there be a space between name and e-mail address? I didn't know what's right so if there should be a space please tell me to take care of it next time.
Thanks for applying the patch.
Regards,
Michal
Quoted 27 lines
I manually fixed both errors and applied it.
Cheers,
EdgarQuoted 19 lines
--- hw/serial.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)hw/serial.c +1
-0@@ -674,6 +674,7 @@ static int serial_post_load(void *opaque, int version_id) }/* Initialize fcr via setter to perform essential side-effects */ serial_ioport_write (s,0x02 , s->fcr_vmstate); +serial_update_parameters (s);return 0 ; }Signature · 1 line
1.7.2.3
Signature · 2 lines
Michal Novotny<[email protected]>, RHCE Virtualization Team (xen userspace), Red Hat
Quoted 24 lines · Michal Novotny
Quoted 23 lines · Edgar E. Iglesias
Quoted 5 lines · Michal Novotny
Hi,
this is the patch to update serial port parameters after guest is already loaded.
Hi
This patch didn't apply:
% git am -s ~/.maildir/minovotn/
Applying: serial: Update parameters after load
error: patch failed:hw/serial.c:674
error:hw/serial.c: patch does not apply
Patch failed at 0001 serial: Update parameters after load When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort"Quoted 2 lines
Signed-off-by Michal Novotny<[email protected]>
Quoted 7 lines
Quoted 3 lines
^^^^ missing spaceHi, thanks. Nevetheless should there be a space between name and e-mail address? I didn't know what's right so if there should be a space please tell me to take care of it next time.
Hi Michal,
If you setup your git environment with your name and email, you can pass the -s flag to commit or set the format.signoff config option and git will generate the SoB line for you.
Cheers
Quoted 39 lines · Edgar E. Iglesias
Quoted 29 lines · Michal Novotny
Quoted 27 lines · Edgar E. Iglesias
Quoted 6 lines · Michal Novotny
Hi,
this is the patch to update serial port parameters after guest is already loaded.
Hi
This patch didn't apply:
% git am -s ~/.maildir/minovotn/
Applying: serial: Update parameters after load
error: patch failed:hw/serial.c:674
error:hw/serial.c: patch does not apply
Patch failed at 0001 serial: Update parameters after load When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort"Quoted 3 lines
Signed-off-by Michal Novotny<[email protected]>Quoted 8 lines
Quoted 4 lines
^^^^ missing spaceHi, thanks. Nevetheless should there be a space between name and e-mail address? I didn't know what's right so if there should be a space please tell me to take care of it next time.
Quoted 8 lines
Hi Michal,
If you setup your git environment with your name and email, you can pass the -s flag to commit or set the format.signoff config option and git will generate the SoB line for you.
Cheers
Ok, thanks. I'm already having it but I didn't know about the format.signoff option.
Thanks,
Michal
Signature · 2 lines
Michal Novotny<[email protected]>, RHCE Virtualization Team (xen userspace), Red Hat