Skip to contentSkip to conversation

Buffer allocation question

DISCUSSION Ian Molton 2 participants 3 messages Sep 13, 2010 – Sep 14, 2010

lore
Share & tools
lore

Ian Molton

author
#0 lore raw

Hi,

I need to allocate some fairly large buffers which will be transferred via virtio to a hypervisor.

the pages dont have to be contiguous physically and aside from the first page int he transfer, the kernel wont really care about the contents of the buffer.

the pages do need to be mapped into userspace contiguously, however. They are also often dynamically resized.

the buffers can be quite large, and there can be several in flight at a given time. They must always be present in physical space (or virtio gets upset)

Obviously kmalloc() is out of the question, and given the size / quantity of the buffers, vmalloc() space is getting tight.

I'm struggling to find a good example of how this should be done.

the buffers will usually be filled all in one go, so it seems silly to fault them in a page at a time.

my first thought (before realising how limited vmalloc space is) was to vmalloc() them in my mmap() function, but this approach ran into trouble when I discovered that the mmap() call does not get called if the vma grows, so I cant then hook in and allocate more vmalloc() space.

It seems like it would be sensible to let userspace allocate the memory and then mmap() that range, but I've been told this is a bad idea.

Whats the best approach here? With the buffers being large I dont really want to transmit them in tiny bits either.

-Ian

#1 lore raw
Quoted 8 lines · Ian Molton

I need to allocate some fairly large buffers which will be transferred via virtio to a hypervisor.

the pages dont have to be contiguous physically and aside from the first page int he transfer, the kernel wont really care about the contents of the buffer.

the pages do need to be mapped into userspace contiguously, however.

See drivers/firewire/core-iso.c, which uses fixed-size buffers.

Quoted 6 lines

They are also often dynamically resized.
...
my first thought (before realising how limited vmalloc space is) was to vmalloc() them in my mmap() function, but this approach ran into trouble when I discovered that the mmap() call does not get called if the vma grows, so I cant then hook in and allocate more vmalloc() space.

You can set vma->vm_ops.

Quoted 2 lines

the buffers will usually be filled all in one go, so it seems silly to fault them in a page at a time.

AFAICS you don't have a choice when resizing.

Regards,
Clemens

author
#2 lore raw

On 14/09/10 07:52, Clemens Ladisch wrote:

<>

Thanks!

I've decided to go for a fixed-buffer scheme in the end.

-Ian