Skip to contentSkip to conversation

linux-next: build warning after merge of the block tree

PATCH In review Stephen Rothwell 3 participants 4 messages Sep 16, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi Jens,

After merging the block tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning:

drivers/scsi/sg.c: In function 'sg_start_req':
drivers/scsi/sg.c:1660: warning: passing argument 2 of 'blk_rq_aligned' makes integer from pointer without a cast include/linux/blkdev.h:1045: note: expected 'long unsigned int' but argument is of type 'void *'

Introduced by commit 144177991ca624841ddbd1e7edff958fc0f6d1fe ("block:
fix an address space warning in blk-map.c").

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

PATCH 1/1 block: fix an warning of calling blk_rq_aligned()

2nd argument of blk_rq_aligned() has changed to 'unsigned long' by previous commit 'block: fix an address space warning in blk-map.c'. According to that change, its caller has to be modified. This also removes address space warnings from sparse.

---
 drivers/scsi/sg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/sg.c +1 -1
index 78d6163..655ab92 100644
@@ -1657,7 +1657,7 @@ static int sg_start_req(Sg_request *srp, unsigned char *cmd)
 	if (sg_allow_dio && hp->flags & SG_FLAG_DIRECT_IO &&
 	    dxfer_dir != SG_DXFER_UNKNOWN && !iov_count &&
 	    !sfp->parentdp->device->host->unchecked_isa_dma &&
-	    blk_rq_aligned(q, hp->dxferp, dxfer_len))
+	    blk_rq_aligned(q, (unsigned long)hp->dxferp, dxfer_len))
 		md = NULL;
 	else
 		md = &map_data;
Signature · 1 line
1.7.2.2
#2 lore raw

Re: [PATCH] block: fix an warning of calling blk_rq_aligned()

Quoted 4 lines · Namhyung Kim

2nd argument of blk_rq_aligned() has changed to 'unsigned long' by previous commit 'block: fix an address space warning in blk-map.c'. According to that change, its caller has to be modified. This also removes address space warnings from sparse.

Thanks, in the future please ensure that you have all{yes,mod}config tested patches you submit.

Signature · 1 line
Jens Axboe
#3 lore raw

Re: [PATCH] block: fix an warning of calling blk_rq_aligned()

2010-09-16 (목), 08:23 +0200, Jens Axboe:

Quoted 3 lines

Thanks, in the future please ensure that you have all{yes,mod}config tested patches you submit.

OK. Sorry for the inconvenience.

Signature · 2 lines
Regards,
Namhyung Kim