Skip to contentSkip to conversation

PM / Runtime: Use alloc_workqueue() for creating PM workqueue

RFC PATCH In review Rafael J. Wysocki 2 participants 6 messages Sep 15, 2010 – Sep 17, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 PM / Runtime: Use alloc_workqueue() for creating PM workqueue

From: Rafael J. Wysocki <[email protected]>
Subject: PM / Runtime: Use alloc_workqueue() for creating PM workqueue

Although we need the PM workqueue to be freezable, we don't need it to be singlethread. Also, the number of concurrent work items running on a single CPU need not be constrained. For these reasons use alloc_workqueue() directly, with suitable arguments, instead of create_freezeable_workqueue(), to create the runtime PM workqueue.

---

Tejun,

I'm not sure about that WQ_RESCUER thing. Can you please tell me what exactly it is for?

Thanks,
Rafael

---
 kernel/power/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/power/main.c +1 -1
Index: linux-2.6/kernel/power/main.c
===================================================================
@@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq);
 
 static int __init pm_start_workqueue(void)
 {
-	pm_wq = create_freezeable_workqueue("pm");
+	pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE | WQ_RESCUER, 0);
 
 	return pm_wq ? 0 : -ENOMEM;
 }
#1 lore raw

Hello, Rafael.

Quoted 2 lines · Rafael J. Wysocki

I'm not sure about that WQ_RESCUER thing. Can you please tell me what exactly it is for?

It's to guarantee forward progress for workqueues which process work items which may be used to reclaim memory. It reserves a rescue worker thread to be used under memory pressure. I finished workqueue documentation a few days ago and sent pull request to Linus.

http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER. alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Thanks for doing it.

Signature · 1 line
tejun
#2 lore raw
In reply to Rafael J. Wysocki

Hello, Rafael.

Quoted 2 lines · Rafael J. Wysocki

I'm not sure about that WQ_RESCUER thing. Can you please tell me what exactly it is for?

It's to guarantee forward progress for workqueues which process work items which may be used to reclaim memory. It reserves a rescue worker thread to be used under memory pressure. I finished workqueue documentation a few days ago and sent pull request to Linus.

http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER. alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Thanks for doing it.

Signature · 1 line
tejun
#3 lore raw
Quoted 11 lines · Tejun Heo

Hello, Rafael.

Quoted 2 lines · Rafael J. Wysocki

I'm not sure about that WQ_RESCUER thing. Can you please tell me what exactly it is for?

It's to guarantee forward progress for workqueues which process work items which may be used to reclaim memory. It reserves a rescue worker thread to be used under memory pressure. I finished workqueue documentation a few days ago and sent pull request to Linus.

Quoted 4 lines

http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER. alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Great, thanks!

Quoted 1 line

Thanks for doing it.

No big deal. Actually I should thank you for making it possible to use freezable workqueues that are not singlethread. :-)

Updated patch follows.

Thanks,
Rafael

---
From: Rafael J. Wysocki <[email protected]>
Subject: PM / Runtime: Use alloc_workqueue() for creating the PM workqueue

Although we need the PM workqueue to be freezable, we don't need it to be singlethread. Also, the number of concurrent work items running on a single CPU need not be constrained. For these reasons use alloc_workqueue() directly, with suitable arguments, instead of create_freezeable_workqueue(), to create the runtime PM workqueue.

---
 kernel/power/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/power/main.c +1 -1
Index: linux-2.6/kernel/power/main.c
===================================================================
@@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq);
 
 static int __init pm_start_workqueue(void)
 {
-	pm_wq = create_freezeable_workqueue("pm");
+	pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE, 0);
 
 	return pm_wq ? 0 : -ENOMEM;
 }
#4 lore raw
In reply to Tejun Heo
Quoted 11 lines · Tejun Heo

Hello, Rafael.

Quoted 2 lines · Rafael J. Wysocki

I'm not sure about that WQ_RESCUER thing. Can you please tell me what exactly it is for?

It's to guarantee forward progress for workqueues which process work items which may be used to reclaim memory. It reserves a rescue worker thread to be used under memory pressure. I finished workqueue documentation a few days ago and sent pull request to Linus.

Quoted 4 lines

http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER. alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Great, thanks!

Quoted 1 line

Thanks for doing it.

No big deal. Actually I should thank you for making it possible to use freezable workqueues that are not singlethread. :-)

Updated patch follows.

Thanks,
Rafael

---
From: Rafael J. Wysocki <[email protected]>
Subject: PM / Runtime: Use alloc_workqueue() for creating the PM workqueue

Although we need the PM workqueue to be freezable, we don't need it to be singlethread. Also, the number of concurrent work items running on a single CPU need not be constrained. For these reasons use alloc_workqueue() directly, with suitable arguments, instead of create_freezeable_workqueue(), to create the runtime PM workqueue.

---
 kernel/power/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/power/main.c +1 -1
Index: linux-2.6/kernel/power/main.c
===================================================================
@@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq);
 
 static int __init pm_start_workqueue(void)
 {
-	pm_wq = create_freezeable_workqueue("pm");
+	pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE, 0);
 
 	return pm_wq ? 0 : -ENOMEM;
 }
Acked-by
#5 lore raw
Quoted 10 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>
Subject: PM / Runtime: Use alloc_workqueue() for creating the PM workqueue

Although we need the PM workqueue to be freezable, we don't need it to be singlethread. Also, the number of concurrent work items running on a single CPU need not be constrained. For these reasons use alloc_workqueue() directly, with suitable arguments, instead of create_freezeable_workqueue(), to create the runtime PM workqueue.

Thanks.

Signature · 1 line
tejun