Fix warning at cpuset_syscall_test.c
Hi,
I found the following warning at cpuset_syscall_test.c.
===============
make[5]: Entering directory `/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/root/ltp/ltp-old/testcases/kernel/include -I../../../../../include -I../../../../../include -L/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib
-L/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../../libcontrollers -L../../../../../lib cpuset_syscall_test.c -lltp -lcpu_set
-lcontrollers -lltp -o cpuset_syscall_testcpuset_syscall_test.c: In function 'main':
cpuset_syscall_test.c:254: warning: control reaches end of non-void function
make[5]: Leaving directory `/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
===============
This warning appears because it doesn't have "return <num>" in main(). The attached patch will fix it.
===============
(quoted diff) +0 -0
b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c index 961d0f9..0d4fe87 100644
testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c +1 -0
@@ -251,5 +251,6 @@ int main(int argc, char *argv[])#else int main (void ) {printf ("System doesn't have required mempolicy support\n" ); +return -1 ; }#endif
===============
Thanks,
ERAMOTO
testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c +1 -0
@@ -251,5 +251,6 @@ int main(int argc, char *argv[])#else int main (void ) {printf ("System doesn't have required mempolicy support\n" ); +return -1 ; }#endif
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
2010/9/16 ERAMOTO Masaya <[email protected]>:
Quoted 26 lines
Hi,
I found the following warning at
cpuset_syscall_test.c.===============
make[5]: Entering directory `/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/root/ltp/ltp-old/testcases/kernel/include -I../../../../../include -I../../../../../include(quoted diff) +0
-3-L/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib -L/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../../libcontrollers -L../../../../../lib cpuset_syscall_test.c -lltp -lcpu_set -lcontrollers -lltp -o cpuset_syscall_test
cpuset_syscall_test.c: In function 'main':
cpuset_syscall_test.c:254: warning: control reaches end of non-void function
make[5]: Leaving directory `/root/ltp/ltp-old/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
===============This warning appears because it doesn't have "return <num>" in
main(). The attached patch will fix it.Signed-off-by ERAMOTO Masaya <[email protected]>===============
testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c +0
-0
testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c int main(int argc, char *argv[]) · line 256
Quoted 6 lines
testcases/kernel/controllers/cpuset/cpuset_syscall_test/cpuset_syscall_test.c +1
-0@@ -251,5 +251,6 @@ int main(int argc, char *argv[]) #else int main (void) { printf("System doesn't have required mempolicy support\n"); + return -1; } #endif
1. Negative return values from main are bad.
2. 0 would be better, otherwise it's going to cause more churn on the list because people without the support are going to start asking the
question: "why is this testcase failing"?
I'll implement return 0 instead.
Thanks for the heads up!
-Garrett
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Hi Garrett,
Quoted 6 lines
1. Negative return values from main are bad.
2. 0 would be better, otherwise it's going to cause more churn on the list because people without the support are going to start asking the
question: "why is this testcase failing"?I'll implement return 0 instead.
I ACK it.
Thanks you for your explanation,
ERAMOTO
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list