Skip to contentSkip to conversation

introducing transmission bittorrent client

PATCH New Marcus Osdoba 3 participants 8 messages Sep 19, 2010 – Sep 29, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 introducing transmission bittorrent client

the client has an excellent webinterface
and seems to be ideal for headless systems,
the statedirectory is stored in /var/transmission which links to tmp, the user should provide a writable config direcory

Based on work by: Kelvin Cheung <[email protected]>

---
 package/Config.in                    |    1 +
 package/transmission/Config.in       |   21 ++++++++
 package/transmission/S92transmission |   88 ++++++++++++++++++++++++++++++++++
 package/transmission/transmission.mk |   49 +++++++++++++++++++
 4 files changed, 159 insertions(+), 0 deletions(-)
 create mode 100644 package/transmission/Config.in
 create mode 100644 package/transmission/S92transmission
 create mode 100644 package/transmission/transmission.mk
package/Config.in +1 -0
index 2209b55..9a63828 100644
@@ -420,6 +420,7 @@ source "package/thttpd/Config.in"
 source "package/tinyhttpd/Config.in"
 endif
 source "package/tn5250/Config.in"
+source "package/transmission/Config.in"
 source "package/ttcp/Config.in"
 source "package/udpcast/Config.in"
 source "package/vpnc/Config.in"
package/transmission/Config.in new file +21 -0
new file mode 100644
index 0000000..f634f8b
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_TRANSMISSION
+	bool "transmission"
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_LIBEVENT
+	help
+	  Transmission is a cross-platform BitTorrent client.
+
+config BR2_PACKAGE_TRANSMISSION_CLI
+	bool "transmissioncli"
+	depends on BR2_PACKAGE_TRANSMISSION
+	help
+	  Install transmission command line interface.
+
+config BR2_PACKAGE_TRANSMISSION_REMOTE
+	bool "transmission-remote"
+	depends on BR2_PACKAGE_TRANSMISSION
+	default y
+	help
+	  Install transmission remote management tool.
package/transmission/S92transmission new file +88 -0

88 lines not on this page · raw message

package/transmission/transmission.mk new file +49 -0

49 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 introducing transmission bittorrent client

Am 19.09.2010 10:23, schrieb Marcus Osdoba:

Quoted 10 lines

the client has an excellent webinterface
and seems to be ideal for headless systems,
the statedirectory is stored in /var/transmission which links to tmp, the user should provide a writable config direcory

Based on work by: Kelvin Cheung<[email protected]>

---
[...]

Hi Marek and Kelvin,

Are you able to test the new patch for your targets and send some (hopefully) positive test results in reply to this patch on the mailinglist. Maybe this would fasten the inclusion into upcoming release 2010.11.

Regards,
Marcus

#2 lore raw

PATCH 1/1 introducing transmission bittorrent client

Hi Marcus,

I have tried the patch.
It works fine.

2010/9/19 Marcus Osdoba <[email protected]>

Quoted 22 lines

Am 19.09.2010 10:23, schrieb Marcus Osdoba:

Quoted 11 lines

the client has an excellent webinterface
and seems to be ideal for headless systems,
the statedirectory is stored in /var/transmission which links to tmp, the user should provide a writable config direcory

Based on work by: Kelvin Cheung<[email protected]>

---
[...]

Hi Marek and Kelvin,

Are you able to test the new patch for your targets and send some (hopefully) positive test results in reply to this patch on the mailinglist. Maybe this would fasten the inclusion into upcoming release 2010.11.

Regards,
Marcus

Signature · 5 lines
Best Regards!
Kelvin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100921/afbea320/attachment.html>
#3 lore raw

PATCH 1/1 introducing transmission bittorrent client

Am 21.09.2010 04:00, schrieb Kelvin Cheung:

Quoted 26 lines

Hi Marcus,

I have tried the patch.
It works fine.

2010/9/19 Marcus Osdoba <[email protected] <mailto:[email protected]>>

Am 19.09.2010 10:23, schrieb Marcus Osdoba:

the client has an excellent webinterface
and seems to be ideal for headless systems,
the statedirectory is stored in /var/transmission which links to tmp,
the user should provide a writable config direcory

Based on work by: Kelvin Cheung<[email protected] <mailto:[email protected]>>

<mailto:[email protected]>>
---
[...]

Hi Marek and Kelvin,

Quoted 13 lines

Are you able to test the new patch for your targets and send some (hopefully) positive test results in reply to this patch on the mailinglist. Maybe this would fasten the inclusion into upcoming release 2010.11.

Regards,
Marcus

Signature · 2 lines
Best Regards!
Kelvin

Hi Thomas and Peter,

Is a positive test sufficient for you to have a closer look at it?

Just for the protocol, transmission build breaks with activated config-cache. If I use it, I have to remove outbut/build/transmission-2.04 and run make flush;make.

I followed the cache discussion on the mailinglist and I know that this feature has been marked experimental (which is my preferred solution, too). But I still use it anyway to speed up the development cycle.

Regards,
Marcus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100922/e9dcdd98/attachment.html>

#4 lore raw

PATCH 1/1 introducing transmission bittorrent client

Quoted 1 line · On Wed, 22 Sep 2010 22:26:15 +0200 Marcus Osdoba…

Is a positive test sufficient for you to have a closer look at it?

Yes, of course! I just send a review.

Quoted 3 lines

Just for the protocol, transmission build breaks with activated config-cache. If I use it, I have to remove outbut/build/transmission-2.04 and run make flush;make.

The configuration cache has been disabled by default since just before the release of 2010.08. The current consensus seems to be that we should simply get rid of this option completely, because it cannot be really reliable.

Speed-up in the build process can come from parallel building of different packages, but this needs some quite heavy changes in our package infrastructure.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 1/1 introducing transmission bittorrent client

In reply to Kelvin Cheung

Am 21.09.2010 04:00, schrieb Kelvin Cheung:

Quoted 4 lines

Hi Marcus,

I have tried the patch.
It works fine.

Hi Kelvin,

I don't know why, but the transmission daemon is not able to create the temporary torrent and resume file.
All other config files were written without problems in the given config-dir. I haven't forwarded a specific port to the machine where embedded transmission runs on - until now.
Why won't transmssion write the temporary files? Or is it correct behaviour? I'm confused about "Couldn't save & Success" in the same status line.

Did you encounter similar errors with your installation?

Btw: Thomas preferres another solution for the init-d skript (without sleep 5 init). I wasn't able to figure out clearly, why and where the IP_ADDR variable is used, so I'm experimenting with the "official" init-d-skript from the transmission wiki.
Would this be a problem in your eyes?

Kind regards,
Marcus

$ /usr/bin/transmission-daemon -f -a 192.168.1.* --config-dir=/data
[23:32:24.095] Transmission 2.04 (11151) started (session.c:622)
[23:32:24.097] RPC Server Adding address to whitelist: 192.168.1.* 
(rpc-server.c:767)
[23:32:24.100] RPC Server Serving RPC and Web requests on port 9091 
(rpc-server.c:940)
[23:32:24.102] RPC Server Whitelist enabled (rpc-server.c:944)
[23:32:24.104] DHT Generating new id (tr-dht.c:378)
[23:32:24.106] Port Forwarding (NAT-PMP) initnatpmp succeeded (0) 
(natpmp.c:67)
[23:32:24.108] Port Forwarding (NAT-PMP) sendpublicaddressrequest 
succeeded (2) (natpmp.c:67)
[23:32:24.110] Using settings from "/data" (daemon.c:443)
[23:32:24.113] Saved "/data/settings.json" (bencode.c:1651)
[23:32:25.116] Port Forwarding (UPnP) Found Internet Gateway Device 
"http://192.168.1.1:49000/upnp/control/WANIPConn1" (upnp.c:113)
[23:32:25.118] Port Forwarding (UPnP) Local Address is "192.168.1.254" 
(upnp.c:115)
[23:32:25.120] Port Forwarding (UPnP) Port forwarding through 
"http://192.168.1.1:49000/upnp/control/WANIPConn1", service 
"urn:schemas-upnp-org:service:WANIPConnection:1".  (local address: 
192.168.1.254:51413) (upnp.c:202)
[23:32:25.123] Port Forwarding State changed from "Not forwarded" to 
"Starting" (port-forwarding.c:89)
[23:32:31.126] Port Forwarding State changed from "Starting" to "???" 
(port-forwarding.c:89)
[23:32:59.130] DHT Attempting bootstrap from dht.transmissionbt.com 
(tr-dht.c:234)
[23:33:16.135] Couldn't save file 
"/data/torrents/evbarmcd-5.0.2.iso.9fe3ef5b5a32e862.torrent": Success 
(bencode.c:1663)
[23:33:34.139] evbarmcd-5.0.2.iso Starting DHT announce (poor, 9 nodes) 
(tr-dht.c:669)
[23:34:23.146] Couldn't save file 
"/data/resume/evbarmcd-5.0.2.iso.9fe3ef5b5a32e862.resume": Success 
(bencode.c:1663)
[23:35:04.151] evbarmcd-5.0.2.iso Removing torrent (torrent.c:1557)
[23:35:04.154] evbarmcd-5.0.2.iso Pausing (torrent.c:1513)
Closing transmission session... done.
#6 lore raw

PATCH 1/1 introducing transmission bittorrent client

Quoted 5 lines · On Mon, 27 Sep 2010 23:46:52 +0200 Marcus Osdoba…

Btw: Thomas preferres another solution for the init-d skript (without sleep 5 init). I wasn't able to figure out clearly, why and where the IP_ADDR variable is used, so I'm experimenting with the "official" init-d-skript from the transmission wiki.
Would this be a problem in your eyes?

Well, for the moment, we can keep this loop. Fix the other problems mentionned in my latest review, and resend a new version. We'll merge that one.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#7 lore raw

PATCH 1/1 introducing transmission bittorrent client

In reply to Marcus Osdoba

package/transmission/S92transmission line 32

Quoted 8 lines · On Sun, 19 Sep 2010 10:23:24 +0200 Marcus Osdoba…
package/transmission/S92transmission new file +8 -0
+		IFCONFIG_OUTPUT=`ifconfig $NET_INTERFACE`
+		IP_ADDR=`expr match "$IFCONFIG_OUTPUT" '.*inet addr:\([0-9]*\.[0-9]*\.[0-9]*\.[0-9]*\).*'`
+		while [ -z "$IP_ADDR" ]
+		do
+			sleep 5
+			IFCONFIG_OUTPUT=`ifconfig $NET_INTERFACE`
+			IP_ADDR=`expr match "$IFCONFIG_OUTPUT" '.*inet addr:\([0-9]*\.[0-9]*\.[0-9]*\.[0-9]*\).*'`
+		done

I'm still not a big fan of this loop. There's really no other solution ?

package/transmission/S92transmission line 59

Quoted 11 lines
package/transmission/S92transmission new file +11 -0
+	start)
+		echo "Starting $DESC" "$NAME..."
+		do_start
+		case "$?" in
+			0) echo "   Start $DESC $NAME: SUCCESS" ;;
+			*)
+				echo "   Start $DESC $NAME: FAILED"
+				exit 3
+				;;
+		esac
+		;;

I don't think we have all this message printing handling in other S??* scripts, could you simplify this a little bit, for example to make it similar to package/dropbear/S50dropbear ?

package/transmission/transmission.mk line 27

Quoted 3 lines
package/transmission/transmission.mk new file +3 -0
+ifneq ($(BR2_PACKAGE_TRANSMISSION_REMOTE),y)
+TRANSMISSION_CONF_OPT += --disable-remote
+endif

Add a new line here.

package/transmission/transmission.mk line 29

Quoted 2 lines
package/transmission/transmission.mk new file +2 -0
+ifeq ($(BR2_PACKAGE_TRANSMISSION_REMOTE),y)
+define TRANSMISSION_INITDSKRIPT_INSTALL

INITDSKRIPT looks strange. INIT_SCRIPT instead ?

package/transmission/transmission.mk line 36

Quoted 7 lines
package/transmission/transmission.mk new file +7 -0
+	# install start/stop script
+	$(call MESSAGE,"Installing S92transmission init script")
+	if [ ! -f $(TARGET_DIR)/etc/init.d/S92transmission ]; then \
+		$(INSTALL) -m 0755 -D package/transmission/S92transmission \
+		$(TARGET_DIR)/etc/init.d/S92transmission; \
+	fi
+	$(Q)touch $@

The touch here is not needed.

Otherwise, looks good to me. Care to fix these and resend an updated version ?

Thanks a lot for all your efforts and your patience!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com