at91: drop at91x40 support
PATCH 1/1 at91: drop at91x40 support
as it's broken for releases and no one care about it
--- arch/arm/mach-at91/Kconfig | 20 --------- arch/arm/mach-at91/Makefile | 4 -- arch/arm/mach-at91/at91x40.c | 83 ------------------------------------- arch/arm/mach-at91/at91x40_time.c | 80 ----------------------------------- arch/arm/mach-at91/board-eb01.c | 44 ------------------- 5 files changed, 0 insertions(+), 231 deletions(-) delete mode 100644 arch/arm/mach-at91/at91x40.c delete mode 100644 arch/arm/mach-at91/at91x40_time.c delete mode 100644 arch/arm/mach-at91/board-eb01.c
arch/arm/mach-at91/Kconfig +0 -20
@@ -89,10 +89,6 @@ config ARCH_AT572D940HF select CPU_ARM926T select GENERIC_CLOCKEVENTS -config ARCH_AT91X40 - bool "AT91x40" - select ARCH_USES_GETTIMEOFFSET - endchoice config AT91_PMC_UNIT
@@ -432,22 +428,6 @@ endif # ---------------------------------------------------------- -if ARCH_AT91X40 - -comment "AT91X40 Board Type" - -config MACH_AT91EB01 - bool "Atmel AT91EB01 Evaluation Kit" - help - Select this if you are using Atmel's AT91EB01 Evaluation Kit. - It is also a popular target for simulators such as GDB's - ARM simulator (commonly known as the ARMulator) and the - Skyeye simulator. - -endif - -# ---------------------------------------------------------- - comment "AT91 Board Options" config MTD_AT91_DATAFLASH_CARD
arch/arm/mach-at91/Makefile +0 -4
@@ -20,7 +20,6 @@ obj-$(CONFIG_ARCH_AT91SAM9G20) += at91sam9260.o at91sam926x_time.o at91sam9260_d obj-$(CONFIG_ARCH_AT91SAM9G45) += at91sam9g45.o at91sam926x_time.o at91sam9g45_devices.o sam9_smc.o obj-$(CONFIG_ARCH_AT91CAP9) += at91cap9.o at91sam926x_time.o at91cap9_devices.o sam9_smc.o obj-$(CONFIG_ARCH_AT572D940HF) += at572d940hf.o at91sam926x_time.o at572d940hf_devices.o sam9_smc.o -obj-$(CONFIG_ARCH_AT91X40) += at91x40.o at91x40_time.o # AT91RM9200 board-specific support obj-$(CONFIG_MACH_ONEARM) += board-1arm.o
@@ -78,9 +77,6 @@ obj-$(CONFIG_MACH_AT91CAP9ADK) += board-cap9adk.o # AT572D940HF board-specific support obj-$(CONFIG_MACH_AT572D940HFEB) += board-at572d940hf_ek.o -# AT91X40 board-specific support -obj-$(CONFIG_MACH_AT91EB01) += board-eb01.o - # Drivers obj-y += leds.o
arch/arm/mach-at91/at91x40.c deleted +0 -83
83 lines not on this page · raw message
arch/arm/mach-at91/at91x40_time.c deleted +0 -80
80 lines not on this page · raw message
arch/arm/mach-at91/board-eb01.c deleted +0 -44
44 lines not on this page · raw message
Signature · 1 line
1.7.1
Greg Ungerer
NAKPATCH 1/1 at91: drop at91x40 support
Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
as it's broken for releases and no one care about it
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD<[email protected]>Cc Andrew Victor<[email protected]>Cc Nicolas Ferre<[email protected]>Cc Greg Ungerer<[email protected]>
NAK, I care. I sent a fix to this very list about a week ago to fix the current compile problem.
Regards
Greg
Quoted 296 lines
--- arch/arm/mach-at91/Kconfig | 20 --------- arch/arm/mach-at91/Makefile | 4 -- arch/arm/mach-at91/at91x40.c | 83 ------------------------------------- arch/arm/mach-at91/at91x40_time.c | 80 ----------------------------------- arch/arm/mach-at91/board-eb01.c | 44 ------------------- 5 files changed, 0 insertions(+), 231 deletions(-)delete mode 100644
arch/arm/mach-at91/at91x40.cdelete mode 100644arch/arm/mach-at91/at91x40_time.cdelete mode 100644arch/arm/mach-at91/board-eb01.carch/arm/mach-at91/Kconfig +0
-20@@ -89,10 +89,6 @@ config ARCH_AT572D940HF select CPU_ARM926T select GENERIC_CLOCKEVENTS -config ARCH_AT91X40 - bool "AT91x40" - select ARCH_USES_GETTIMEOFFSET - endchoice config AT91_PMC_UNIT@@ -432,22 +428,6 @@ endif # ---------------------------------------------------------- -if ARCH_AT91X40 - -comment "AT91X40 Board Type" - -config MACH_AT91EB01 - bool "Atmel AT91EB01 Evaluation Kit" - help - Select this if you are using Atmel's AT91EB01 Evaluation Kit. - It is also a popular target for simulators such as GDB's - ARM simulator (commonly known as the ARMulator) and the - Skyeye simulator. - -endif - -# ---------------------------------------------------------- - comment "AT91 Board Options" config MTD_AT91_DATAFLASH_CARDarch/arm/mach-at91/Makefile +0
-4@@ -20,7 +20,6 @@ obj-$(CONFIG_ARCH_AT91SAM9G20) += at91sam9260.o at91sam926x_time.o at91sam9260_d obj-$(CONFIG_ARCH_AT91SAM9G45) += at91sam9g45.o at91sam926x_time.o at91sam9g45_devices.o sam9_smc.o obj-$(CONFIG_ARCH_AT91CAP9) += at91cap9.o at91sam926x_time.o at91cap9_devices.o sam9_smc.o obj-$(CONFIG_ARCH_AT572D940HF) += at572d940hf.o at91sam926x_time.o at572d940hf_devices.o sam9_smc.o -obj-$(CONFIG_ARCH_AT91X40) += at91x40.o at91x40_time.o # AT91RM9200 board-specific support obj-$(CONFIG_MACH_ONEARM) += board-1arm.o@@ -78,9 +77,6 @@ obj-$(CONFIG_MACH_AT91CAP9ADK) += board-cap9adk.o # AT572D940HF board-specific support obj-$(CONFIG_MACH_AT572D940HFEB) += board-at572d940hf_ek.o -# AT91X40 board-specific support -obj-$(CONFIG_MACH_AT91EB01) += board-eb01.o - # Drivers obj-y += leds.oarch/arm/mach-at91/at91x40.c deleted +0
-83@@ -1,83 +0,0 @@ -/* -* arch/arm/mach-at91/at91x40.c -* -* (C) Copyright 2007, Greg Ungerer<[email protected]> -* Copyright (C) 2005 SAN People -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -*/ - -#include <linux/kernel.h> -#include <linux/init.h> -#include <linux/irq.h> -#include <asm/mach/arch.h> -#include <mach/at91x40.h> -#include <mach/at91_st.h> -#include <mach/timex.h> -#include "generic.h" - -/* -* Export the clock functions for the AT91X40. Some external code common -* to all AT91 family parts relys on this, like the gpio and serial support. -*/ -int clk_enable (struct clk *clk) -{ -return 0 ; -} - -void clk_disable (struct clk *clk) -{ -} - -unsigned long clk_get_rate (struct clk *clk) -{ -return AT91X40_MASTER_CLOCK ; -} - -struct clk *clk_get (struct device *dev,const char *id) -{ -return NULL ; -} - -void __init at91x40_initialize (unsigned long main_clock) -{ - at91_extern_irq = (1 <<AT91X40_ID_IRQ0 ) | (1 <<AT91X40_ID_IRQ1 ) - | (1 <<AT91X40_ID_IRQ2 ); -} - -/* -* The default interrupt priority levels (0 = lowest, 7 = highest). -*/ -static unsigned int at91x40_default_irq_priority[NR_AIC_IRQS ]__initdata = { -7 ,/* Advanced Interrupt Controller (FIQ) */ -0 ,/* System Peripherals */ -0 ,/* USART 0 */ -0 ,/* USART 1 */ -2 ,/* Timer Counter 0 */ -2 ,/* Timer Counter 1 */ -2 ,/* Timer Counter 2 */ -0 ,/* Watchdog timer */ -0 ,/* Parallel IO Controller A */ -0 ,/* Reserved */ -0 ,/* Reserved */ -0 ,/* Reserved */ -0 ,/* Reserved */ -0 ,/* Reserved */ -0 ,/* Reserved */ -0 ,/* Reserved */ -0 ,/* External IRQ0 */ -0 ,/* External IRQ1 */ -0 ,/* External IRQ2 */ -}; - -void __init at91x40_init_interrupts (unsigned int priority[NR_AIC_IRQS ]) -{ -if (!priority) - priority = at91x40_default_irq_priority; - -at91_aic_init (priority); -} -arch/arm/mach-at91/at91x40_time.c deleted +0
-80@@ -1,80 +0,0 @@ -/* -* arch/arm/mach-at91/at91x40_time.c -* -* (C) Copyright 2007, Greg Ungerer<[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -*/ - -#include <linux/kernel.h> -#include <linux/init.h> -#include <linux/interrupt.h> -#include <linux/irq.h> -#include <linux/time.h> -#include <linux/io.h> -#include <mach/hardware.h> -#include <asm/mach/time.h> -#include <mach/at91_tc.h> - -/* -* 3 counter/timer units present. -*/ -#define AT91_TC_CLK0BASE 0 -#define AT91_TC_CLK1BASE 0x40 -#define AT91_TC_CLK2BASE 0x80 - -static unsigned long at91x40_gettimeoffset (void ) -{ -return (at91_sys_read (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_CV ) *1000000 / (AT91X40_MASTER_CLOCK /128 )); -} - -static irqreturn_t at91x40_timer_interrupt (int irq,void *dev_id) -{ -at91_sys_read (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_SR ); -timer_tick (); -return IRQ_HANDLED ; -} - -static struct irqaction at91x40_timer_irq = { - .name ="at91_tick" , - .flags =IRQF_DISABLED |IRQF_TIMER , - .handler = at91x40_timer_interrupt -}; - -void __init at91x40_timer_init (void ) -{ -unsigned int v; - -at91_sys_write (AT91_TC +AT91_TC_BCR ,0 ); - v =at91_sys_read (AT91_TC +AT91_TC_BMR ); - v = (v& ~AT91_TC_TC1XC1S ) |AT91_TC_TC1XC1S_NONE ; -at91_sys_write (AT91_TC +AT91_TC_BMR , v); - -at91_sys_write (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_CCR ,AT91_TC_CLKDIS ); -at91_sys_write (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_CMR , (AT91_TC_TIMER_CLOCK4 |AT91_TC_CPCTRG )); -at91_sys_write (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_IDR ,0xffffffff ); -at91_sys_write (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_RC , (AT91X40_MASTER_CLOCK /128 ) /HZ -1 ); -at91_sys_write (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_IER , (1 <<4 )); - -setup_irq (AT91X40_ID_TC1 ,&at91x40_timer_irq); - -at91_sys_write (AT91_TC +AT91_TC_CLK1BASE +AT91_TC_CCR , (AT91_TC_SWTRG |AT91_TC_CLKEN )); -} - -struct sys_timer at91x40_timer = { - .init = at91x40_timer_init, - .offset = at91x40_gettimeoffset, -}; -arch/arm/mach-at91/board-eb01.c deleted +0
-44@@ -1,44 +0,0 @@ -/* -* arch/arm/mach-at91/board-eb01.c -* -* (C) Copyright 2007, Greg Ungerer<[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -*/ - -#include <linux/kernel.h> -#include <linux/init.h> -#include <linux/module.h> -#include <linux/platform_device.h> -#include <linux/irq.h> -#include <asm/mach-types.h> -#include <mach/hardware.h> -#include <asm/mach/arch.h> -#include <asm/mach/map.h> -#include <mach/board.h> -#include "generic.h" - -static void __init at91eb01_map_io (void ) -{ -at91x40_initialize (40000000 ); -} - -MACHINE_START (AT91EB01 ,"Atmel AT91 EB01" ) -/* Maintainer: Greg Ungerer<[email protected]> */ - .timer =&at91x40_timer, - .init_irq = at91x40_init_interrupts, - .map_io = at91eb01_map_io, -MACHINE_END -
Signature · 5 lines
------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg at snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close, FAX: +61 7 3891 3630 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
PATCH 1/1 at91: drop at91x40 support
Quoted 10 lines · Greg Ungerer
Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
as it's broken for releases and no one care about it
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD<[email protected]>Cc Andrew Victor<[email protected]>Cc Nicolas Ferre<[email protected]>Cc Greg Ungerer<[email protected]>NAK, I care. I sent a fix to this very list about a week ago to fix the current compile problem.
sorry but not see it
and I see it failled to build for at least 4 releases and no debug-macro.S for years
since what 4 or 5 years we just have the timer and irq
do you have plan to update it?
or I do not see the current implementation very usefull so I still prefer to drop it
Best Regards,
J.
PATCH 1/1 at91: drop at91x40 support
Quoted 4 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Greg Ungerer
Quoted 2 lines · Jean-Christophe PLAGNIOL-VILLARD
as it's broken for releases and no one care about it
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD<[email protected]>Cc Andrew Victor<[email protected]>Cc Nicolas Ferre<[email protected]>Cc Greg Ungerer<[email protected]>NAK, I care. I sent a fix to this very list about a week ago to fix the current compile problem.
sorry but not see it
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025404.html
Quoted 1 line
and I see it failled to build for at least 4 releases and
And this is not really due to the board support code (which you propose to remove) at all. It is almost always due to breakage of something else. The patch I reference above is a good example. Breakage in the non-MMU support code is another example (and I have another patch I need to send to fix a problem there too).
Quoted 2 lines
no
debug-macro.Sfor years
since what 4 or 5 years we just have the timer and irq
I don't follow. What is wrong witharch/arm/mach-at91/include/mach/debug-macro.S?
The AT91x40 parts are pretty simple, what else do you expect?
Quoted 1 line
do you have plan to update it?
I don't see anything to update. It does exactly what I want it to do. The board support code you point at causes me no troubles, and not very often do I need to fix/change/update it.
Quoted 2 lines
or I do not see the current implementation very usefull so I still prefer to drop it
Well, I am sorry, I still disagree.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg at snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
PATCH 1/1 at91: drop at91x40 support
Quoted 17 lines · Greg Ungerer
Quoted 4 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Greg Ungerer
Quoted 2 lines · Jean-Christophe PLAGNIOL-VILLARD
as it's broken for releases and no one care about it
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD<[email protected]>Cc Andrew Victor<[email protected]>Cc Nicolas Ferre<[email protected]>Cc Greg Ungerer<[email protected]>NAK, I care. I sent a fix to this very list about a week ago to fix the current compile problem.
sorry but not see it
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025404.html
Quoted 8 lines
Quoted 1 line
and I see it failled to build for at least 4 releases and
And this is not really due to the board support code (which you propose to remove) at all. It is almost always due to breakage of something else. The patch I reference above is a good example. Breakage in the non-MMU support code is another example (and I have another patch I need to send to fix a problem there too).
which means no one test it or used it
Quoted 7 lines
Quoted 4 lines
no
debug-macro.Sfor years
since what 4 or 5 years we just have the timer and irqI don't follow. What is wrong with
arch/arm/mach-at91/include/mach/debug-macro.S?
the at91x40 can not use it as it's not have DBGU support
Quoted 9 lines
The AT91x40 parts are pretty simple, what else do you expect?
Quoted 1 line
do you have plan to update it?
I don't see anything to update. It does exactly what I want it to do. The board support code you point at causes me no troubles, and not very often do I need to fix/change/update it.
you have no flash, no uart, no pio support, no watchdog supportm so tc support, the CPU type is no even selected in the Kconfig
so yes the current implementation is not really usefull for anything
Best Regards,
J.
PATCH 1/1 at91: drop at91x40 support
Quoted 20 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 19 lines · Greg Ungerer
Quoted 4 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Greg Ungerer
Quoted 2 lines · Jean-Christophe PLAGNIOL-VILLARD
as it's broken for releases and no one care about it
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD<[email protected]>Cc Andrew Victor<[email protected]>Cc Nicolas Ferre<[email protected]>Cc Greg Ungerer<[email protected]>NAK, I care. I sent a fix to this very list about a week ago to fix the current compile problem.
sorry but not see it
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025404.html
Quoted 1 line
and I see it failled to build for at least 4 releases and
Quoted 7 lines
Quoted 6 lines
And this is not really due to the board support code (which you propose to remove) at all. It is almost always due to breakage of something else. The patch I reference above is a good example. Breakage in the non-MMU support code is another example (and I have another patch I need to send to fix a problem there too).
which means no one test it or used it
I have a patch for it. I tested it. I just didn't get around to sending the patch. My bad. I have had it sitting around for a while. It happens.
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
no
debug-macro.Sfor years
since what 4 or 5 years we just have the timer and irqI don't follow. What is wrong with
arch/arm/mach-at91/include/mach/debug-macro.S?the at91x40 can not use it as it's not have DBGU support
Yes, thats right. But it causes no problems.
Quoted 8 lines
Quoted 7 lines
The AT91x40 parts are pretty simple, what else do you expect?
Quoted 1 line
do you have plan to update it?
I don't see anything to update. It does exactly what I want it to do. The board support code you point at causes me no troubles, and not very often do I need to fix/change/update it.
you have no flash,
Uh? That doesn't need to go into the board support file. (And my use case doesn't use flash anyway).
Quoted 1 line
no uart, no pio support, no watchdog supportm so tc support,
I don't need or want most of those. If someone else needs them they can add them.
Quoted 1 line
the CPU type is no even selected in the
Kconfig
What, you can't select "AT91x40" in menuconfig?
Quoted 1 line
so yes the current implementation is not really usefull for anything
I use it. I do my main work on non-MMU code on ARM using this base. It is very useful to me.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg at snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
PATCH 1/1 at91: drop at91x40 support
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
no
debug-macro.Sfor years
since what 4 or 5 years we just have the timer and irqI don't follow. What is wrong with
arch/arm/mach-at91/include/mach/debug-macro.S?the at91x40 can not use it as it's not have DBGU support
Yes, thats right. But it causes no problems.
just very hard to debug
Quoted 17 lines
Quoted 10 lines
Quoted 9 lines
The AT91x40 parts are pretty simple, what else do you expect?
Quoted 1 line
do you have plan to update it?
I don't see anything to update. It does exactly what I want it to do. The board support code you point at causes me no troubles, and not very often do I need to fix/change/update it.
you have no flash,
Uh? That doesn't need to go into the board support file. (And my use case doesn't use flash anyway).
Quoted 1 line
no uart, no pio support, no watchdog supportm so tc support,
Quoted 7 lines
I don't need or want most of those. If someone else needs them they can add them.
Quoted 1 line
the CPU type is no even selected in the
KconfigWhat, you can't select "AT91x40" in menuconfig?
cpu type ARM7TDMI
Quoted 6 lines
Quoted 3 lines
so yes the current implementation is not really usefull for anything
I use it. I do my main work on non-MMU code on ARM using this base. It is very useful to me.
as you use an emulator but for a real hardware it's not
have the uart debug-macro.S for the kernel is a minimal requirement in my mind
and could u send a defconfig please
Best Regards,
J.