Skip to contentSkip to conversation

Fix compilation: format string - acb->sector_num is long long

PATCH In review Peter Lemenkov 3 participants 3 messages Sep 22, 2010 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix compilation: format string - acb->sector_num is long long

---
 block/blkverify.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
block/blkverify.c +1 -1
index 4202685..033eab2 100644
@@ -58,7 +58,7 @@ static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)
     va_list ap;
 
     va_start(ap, fmt);
-    fprintf(stderr, "blkverify: %s sector_num=%ld nb_sectors=%d ",
+    fprintf(stderr, "blkverify: %s sector_num=%lld nb_sectors=%d ",
             acb->is_write ? "write" : "read", acb->sector_num,
             acb->nb_sectors);
     vfprintf(stderr, fmt, ap);
Signature · 1 line
1.7.2.3
#1 lore raw
Quoted 10 lines · Peter Lemenkov

---
 block/blkverify.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
block/blkverify.c +0 -0
index 4202685..033eab2 100644

block/blkverify.c static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...) · line 61

Quoted 5 lines
block/blkverify.c +1 -1
@@ -58,7 +58,7 @@ static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)
     va_list ap;
 
     va_start(ap, fmt);
-    fprintf(stderr, "blkverify: %s sector_num=%ld nb_sectors=%d ",
+    fprintf(stderr, "blkverify: %s sector_num=%lld nb_sectors=%d ",

It's not 'long long' but int64_t, so the correct format is ...sector_num=%" PRId64 " nb_sectors=...

#2 lore raw
In reply to Peter Lemenkov
Quoted 10 lines · Peter Lemenkov
---
  block/blkverify.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
block/blkverify.c +0 -0
index 4202685..033eab2 100644

block/blkverify.c static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...) · line 63

Quoted 7 lines
block/blkverify.c +1 -1
@@ -58,7 +58,7 @@ static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)
      va_list ap;
 
      va_start(ap, fmt);
-    fprintf(stderr, "blkverify: %s sector_num=%ld nb_sectors=%d ",
+    fprintf(stderr, "blkverify: %s sector_num=%lld nb_sectors=%d ",
              acb->is_write ? "write" : "read", acb->sector_num,
 

It's not a long long, it's a PRId64. I've updated appropriately.

Regards,

Anthony Liguori

Quoted 3 lines
block/blkverify.c +0 -0
              acb->nb_sectors);
      vfprintf(stderr, fmt, ap);