Skip to contentSkip to conversation

Potential race in irq_chip_set_defaults()?

DISCUSSION Jeremy Fitzhardinge 2 participants 2 messages Sep 24, 2010

lore
Share & tools
lore
#0 lore raw

irq_chip_set_defaults() modifies the irq_chip structure in-place when
setting up an irq. If that happens on multiple CPUs at once then it could leave the irq_chip structure in an inconsistent state.

Is there anything preventing that case from happening? There's no locking, and as far as I know there's no rule forbidding concurrent calls to set_irq_chip()/irq_chip_set_defaults().

Thanks,
J

#1 lore raw

Jeremy

Quoted 7 lines · Jeremy Fitzhardinge

irq_chip_set_defaults() modifies the irq_chip structure in-place when
setting up an irq. If that happens on multiple CPUs at once then it could leave the irq_chip structure in an inconsistent state.

Is there anything preventing that case from happening? There's no locking, and as far as I know there's no rule forbidding concurrent calls to set_irq_chip()/irq_chip_set_defaults().

that's true. Never thought about that. Will have a look.

Thanks,

tglx