Skip to contentSkip to conversation

inconsistent use of $TMP vs. $TMPDIR

DISCUSSION Eric Blake 2 participants 2 messages Sep 24, 2010 – Sep 26, 2010 KVM

lore
Share & tools
lore

Eric Blake

author
#0 lore raw

I noticed today that various kvm source files are inconsistent on the use of $TMP vs. $TMPDIR:

$ git grep -l '\$TMP\b' | cat
scripts/Kbuild.include
tools/perf/feature-tests.mak
$ git grep -l '\$TMPDIR\b' | cat
Documentation/lguest/extract

According to POSIX, you should probably be using $TMPDIR instead of $TMP when referring to the preferred temporary directory location.

http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03

Signature · 2 lines
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org
#1 lore raw
Quoted 8 lines · Eric Blake

I noticed today that various kvm source files are inconsistent on the use of $TMP vs. $TMPDIR:

$ git grep -l '\$TMP\b' | cat
scripts/Kbuild.include
tools/perf/feature-tests.mak
$ git grep -l '\$TMPDIR\b' | cat
Documentation/lguest/extract
Quoted 5 lines

According to POSIX, you should probably be using $TMPDIR instead of $TMP when referring to the preferred temporary directory location.

http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03

These are not kvm specific issues. Please use MAINTAINERS to report to the maintainer of the affected subsystems (lguest, kbuild).

Signature · 1 line
error compiling committee.c: too many arguments to function