Skip to contentSkip to conversation

Bump quagga to 0.99.17

PATCH Superseded Gustavo Zacarias 3 participants 8 messages Sep 30, 2010 – Oct 1, 2010

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

Bump quagga to version 0.99.17.
[SECURITY] Fixes remote crash in bgpd.
Other fixes for ospfd, ospf6d, zebra and isisd.
Fix conflicting options in the package, enhance help, reorder options.
Should fix most breakage with randpackageconfig (Peter: ring me if you
hit another one!).
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: buildroot-quagga-0.99.17.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100930/ad65b04b/attachment-0001.ksh>

#1 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Bump quagga to version 0.99.17.
Gustavo> [SECURITY] Fixes remote crash in bgpd.
Gustavo> Other fixes for ospfd, ospf6d, zebra and isisd.
Gustavo> Fix conflicting options in the package, enhance help, reorder options. Gustavo> Should fix most breakage with randpackageconfig (Peter: ring me if you Gustavo> hit another one!).

With this I still have the same bug:

make[3]: *** No rule to make target ../ospfd/libospf.la', needed by ospfclient

grep QUAGGA .config
BR2_PACKAGE_QUAGGA=y
# BR2_PACKAGE_QUAGGA_ZEBRA is not set
# BR2_PACKAGE_QUAGGA_BGPD is not set
# BR2_PACKAGE_QUAGGA_RIPD is not set
# BR2_PACKAGE_QUAGGA_OSPFD is not set
# BR2_PACKAGE_QUAGGA_WATCHQUAGGA is not set
# BR2_PACKAGE_QUAGGA_ISISD is not set
# BR2_PACKAGE_QUAGGA_BGP_ANNOUNCE is not set
# BR2_PACKAGE_QUAGGA_NETLINK is not set
# BR2_PACKAGE_QUAGGA_SNMP is not set
BR2_PACKAGE_QUAGGA_TCP_ZEBRA=y
BR2_PACKAGE_QUAGGA_OPAGUE_LSA=y

I also see that you removed the comment about snmp support being broken with external toolchains. Is that resolved?

And finally, how do you create your patches? Could you please use git format-patch for it, so I can apply them with git am?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

Quoted 27 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Bump quagga to version 0.99.17.
Gustavo> [SECURITY] Fixes remote crash in bgpd.
Gustavo> Other fixes for ospfd, ospf6d, zebra and isisd.
Gustavo> Fix conflicting options in the package, enhance help, reorder options. Gustavo> Should fix most breakage with randpackageconfig (Peter: ring me if you Gustavo> hit another one!).

With this I still have the same bug:

make[3]: *** No rule to make target ../ospfd/libospf.la', needed by ospfclient

grep QUAGGA .config
BR2_PACKAGE_QUAGGA=y
# BR2_PACKAGE_QUAGGA_ZEBRA is not set
# BR2_PACKAGE_QUAGGA_BGPD is not set
# BR2_PACKAGE_QUAGGA_RIPD is not set
# BR2_PACKAGE_QUAGGA_OSPFD is not set
# BR2_PACKAGE_QUAGGA_WATCHQUAGGA is not set
# BR2_PACKAGE_QUAGGA_ISISD is not set
# BR2_PACKAGE_QUAGGA_BGP_ANNOUNCE is not set
# BR2_PACKAGE_QUAGGA_NETLINK is not set
# BR2_PACKAGE_QUAGGA_SNMP is not set
BR2_PACKAGE_QUAGGA_TCP_ZEBRA=y
BR2_PACKAGE_QUAGGA_OPAGUE_LSA=y

Quoted 5 lines

I also see that you removed the comment about snmp support being broken with external toolchains. Is that resolved?

And finally, how do you create your patches? Could you please use git format-patch for it, so I can apply them with git am?

Did you make oldconfig to avoid OPAQUE_LSA? (heh, nice typo there, feel free to fix it). OPAQUE shouldn't be enabled unless OSPFD is enabled. I'm doing the usual git commit, git format-patch and attach it as text, can't do git send-email since git fails terribly at smtp auth. Regards.

#3 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

In reply to Peter Korsgaard
Quoted 2 lines · Peter Korsgaard

I also see that you removed the comment about snmp support being broken with external toolchains. Is that resolved?

Forgot about this point, snmp support with external toolchain was broken at the net-snmp package (bad staging), so i removed the kludge since it's supposedly fixed when i rewrote the net-snmp package for autotargets.

#4 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Quoted 2 lines · Peter Korsgaard
Quoted 2 lines

I also see that you removed the comment about snmp support being broken with external toolchains. Is that resolved?

Gustavo> Forgot about this point, snmp support with external toolchain Gustavo> was broken at the net-snmp package (bad staging), so i removed Gustavo> the kludge since it's supposedly fixed when i rewrote the Gustavo> net-snmp package for autotargets.

Ok, thanks.

Could someone using the external toolchain (Thomas?) give netsnmp a quick test?

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

Quoted 2 lines · On Thu, 30 Sep 2010 21:47:42 +0200 Peter Korsgaard <[email protected]> wrote:

Could someone using the external toolchain (Thomas?) give netsnmp a quick test?

I confirm that since Gustavo converted the package to autotargets, the previously existing build failures with external toolchain have disappeared. I just tested with a recent (a few days) Git, and net-snmp built just fine with an external ARM CodeSourcery toolchain.

Now, I have no idea if it actually works, since I don't know how to test it. But that's another story :-)

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> On Thu, 30 Sep 2010 21:47:42 +0200

Quoted 2 lines · Thomas> Peter Korsgaard <[email protected]> wrote:
Quoted 2 lines

Could someone using the external toolchain (Thomas?) give netsnmp a quick test?

Thomas> I confirm that since Gustavo converted the package to autotargets, the Thomas> previously existing build failures with external toolchain have Thomas> disappeared. I just tested with a recent (a few days) Git, and net-snmp Thomas> built just fine with an external ARM CodeSourcery toolchain.

Thomas> Now, I have no idea if it actually works, since I don't know how to Thomas> test it. But that's another story :-)

Thanks - Did you also build something using netsnmp
(E.G. BR2_PACKAGE_QUAGGA_SNMP)? The problem was afaik dependent packages not finding netsnmp.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH v2 1/1 Bump quagga to 0.99.17

In reply to Thomas Petazzoni
Quoted 11 lines · Thomas Petazzoni

I confirm that since Gustavo converted the package to autotargets, the previously existing build failures with external toolchain have disappeared. I just tested with a recent (a few days) Git, and net-snmp built just fine with an external ARM CodeSourcery toolchain.

Now, I have no idea if it actually works, since I don't know how to test it. But that's another story :-)

Regards,

Thomas

That's easy actually :)

Stick into say /tmp/snmpd.conf:
com2sec local localhost thepassword
group MyROGroup v1 local
group MyROGroup v2c local
group MyROGroup usm local
view all included .1 80
access MyROGroup "" any noauth exact all none none access MyRWGroup "" any noauth exact all all none syslocation Unknown
syscontact Unknown

Run "snmpd -c /tmp/snmpd.conf".
And then run "snmpwalk -v 1 -c thepassword localhost". You'll get loads of data if snmpd is working ok.
You can define additional ACLs (com2sec+group) to enable remote access.