Confusing dmx_pes_type_t in dmx.h
The file dmx.h declares dmx_pes_type_t which is ONLY used in this header file.
It is easy to make mistakes, as its member DMX_PES_OTHER resembles a similar symbol in demux.h from enum dmx_ts_pes: DMX_TS_PES_OTHER
One problem was found because of Hans' compiler upgrade.
I think it would be safer (because it is easy to make mistakes) to remove dmx_pes_type_t from dmx.h.
Who knows more on this driver ?
The found bug is fixed in the patch on:
http://linuxtv.org/hg/~jhoogenraad/ubuntu-firedtv/rev/44751f6fba2f
Signature · 4 lines
Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht
Quoted 9 lines · Jan Hoogenraad
The file
dmx.hdeclaresdmx_pes_type_twhich is ONLY used in this header file.
It is easy to make mistakes, as its memberDMX_PES_OTHERresembles a similar symbol indemux.hfrom enumdmx_ts_pes:DMX_TS_PES_OTHEROne problem was found because of Hans' compiler upgrade.
I think it would be safer (because it is easy to make mistakes) to remove
dmx_pes_type_tfromdmx.h.
The file dmx.h defines the interface for userspace applications, hence dmx_pes_type_t must not be removed. Instead, removing enum dmx_ts_pes from demux.h seems to be useful to me.
Regards,
Andreas