smc91111: add write_hwaddr
PATCH 1/1 smc91111: add write_hwaddr
Add smc_write_hwaddr() to set mac address.
Clear dev before use.
--- drivers/net/smc91111.c | 40 ++++++++++++++++++++++++---------------- 1 files changed, 24 insertions(+), 16 deletions(-)
drivers/net/smc91111.c +24 -16
@@ -654,6 +654,28 @@ again:return length; } +static int smc_write_hwaddr (struct eth_device *dev) +{ +int i; + +swap_to (ETHERNET ); +SMC_SELECT_BANK (dev,1 ); +#ifdef USE_32_BIT +for (i =0 ; i <6 ; i +=2 ) { +word address; + + address = dev->enetaddr[i +1 ] <<8 ; + address |= dev->enetaddr[i]; +SMC_outw (dev, address, (ADDR0_REG + i)); + } +#else +for (i =0 ; i <6 ; i++) +SMC_outb (dev, dev->enetaddr[i], (ADDR0_REG + i)); +#endif +swap_to (FLASH ); +return 0 ; +} +/* * Open and Initialize the board *
@@ -662,8 +684,6 @@ again:*/ static int smc_init (struct eth_device *dev,bd_t *bd) { -int i; -swap_to (ETHERNET );PRINTK2 ("%s: smc_init\n" ,SMC_DEV_NAME );
@@ -680,20 +700,6 @@ static int smc_init(struct eth_device *dev, bd_t *bd)/* conservative setting (10Mbps, HalfDuplex, no AutoNeg.) */ /* SMC_SELECT_BANK(dev, 0); */ /* SMC_outw(dev, 0, RPC_REG); */ -SMC_SELECT_BANK (dev,1 ); - -#ifdef USE_32_BIT -for (i =0 ; i <6 ; i +=2 ) { -word address; - - address = dev->enetaddr[i +1 ] <<8 ; - address |= dev->enetaddr[i]; -SMC_outw (dev, address, (ADDR0_REG + i)); - } -#else -for (i =0 ; i <6 ; i++) -SMC_outb (dev, dev->enetaddr[i], (ADDR0_REG + i)); -#endif printf (SMC_DEV_NAME ": MAC %pM\n" , dev->enetaddr);
@@ -1360,6 +1366,7 @@ int smc91111_initialize(u8 dev_num, int base_addr)return 0 ; } +memset (dev,0 ,sizeof (*dev)); priv->dev_num = dev_num; dev->priv = priv; dev->iobase = base_addr;
@@ -1374,6 +1381,7 @@ int smc91111_initialize(u8 dev_num, int base_addr) dev->halt = smc_halt; dev->send = smc_send; dev->recv = smc_rcv; + dev->write_hwaddr = smc_write_hwaddr;sprintf (dev->name,"%s-%hu" ,SMC_DEV_NAME , dev_num);eth_register (dev);
Signature · 1 line
1.7.1.86.g0e460
PATCH 1/1 smc91111: add write_hwaddr
Quoted 2 lines · On Tuesday, October 05, 2010 21:16:10 Thomas Chou wrote:
Add
smc_write_hwaddr()to set mac address.
Clear dev before use.
how is this different from the one sent earlier today ? when re-submitting, you should note what changed.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101005/f5b49162/attachment.pgp
PATCH 1/1 smc91111: add write_hwaddr
Quoted 7 lines · Mike Frysinger
Quoted 2 lines · On Tuesday, October 05, 2010 21:16:10 Thomas Chou wrote:
Add
smc_write_hwaddr()to set mac address.
Clear dev before use.how is this different from the one sent earlier today ? when re-submitting, you should note what changed.
-mike
Sorry. It is the same patch resend.
I was confused by the greylisting of denx mail server and wondered why the first mail was not received after 12 hours.
- Thomas
PATCH 1/1 smc91111: add write_hwaddr
Dear Thomas Chou,
Quoted 3 lines · In message <[email protected]> you wrote:
I was confused by the greylisting of denx mail server and wondered why the first mail was not received after 12 hours.
There is no greylisting on our side.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is is no reason for any individual to have a computer in their
home. -- Ken Olsen (President of Digital Equipment Corporation),
Convention of the World Future Society, in Boston, 1977PATCH 1/1 smc91111: add write_hwaddr
Hi Wolfgang,
Quoted 8 lines
Dear Thomas Chou,
Quoted 3 lines · In message <[email protected]> you wrote:
I was confused by the greylisting of denx mail server and wondered why the first mail was not received after 12 hours.
There is no greylisting on our side.
Well actually we do run postgrey. But as yet we did not get any complaints that this interferes with regular usage. The default values of the software should not intrude much on completely unfiltered traffic.
Cheers
Detlev
Signature · 6 lines
A change in language can transform our appreciation of the cosmos
-- Benjamin Lee Whorf
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH 1/1 smc91111: add write_hwaddr
Quoted 9 lines · Detlev Zundel
Hi Wolfgang,
Quoted 7 lines
Dear Thomas Chou,
Quoted 3 lines · In message<[email protected]> you wrote:
I was confused by the greylisting of denx mail server and wondered why the first mail was not received after 12 hours.
Quoted 6 lines
Quoted 1 line
There is no greylisting on our side.
Well actually we do run postgrey. But as yet we did not get any complaints that this interferes with regular usage. The default values of the software should not intrude much on completely unfiltered traffic.
Dear Wolfgang and Detlev,
The retransmission wait time on my first mail server is quite long and I forgot that there is postgrey on denx mail server, so I sent the patch again using another mail server. I wondered if my first mail server changed IP. Sorry for the noise.
Best regards,
Thomas
PATCH 1/1 smc91111: add write_hwaddr
Dear Thomas Chou,
Quoted 5 lines · In message <[email protected]> you wrote:
The retransmission wait time on my first mail server is quite long and I forgot that there is postgrey on denx mail server, so I sent the patch again using another mail server. I wondered if my first mail server changed IP. Sorry for the noise.
No problem. It was informative for me, too, as I learned that we're running postgrey. I didn't know that before.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The game of life is a game of boomerangs. Our thoughts, deeds and words return to us sooner or later with astounding accuracy.
Ben Warren
AppliedPATCH 1/1 smc91111: add write_hwaddr
In reply to Thomas ChouHi Thomas,
Quoted 7 lines · Thomas Chou
Add
smc_write_hwaddr()to set mac address.
Clear dev before use.Signed-off-by Thomas Chou<[email protected]>--- drivers/net/smc91111.c | 40 ++++++++++++++++++++++++---------------- 1 files changed, 24 insertions(+), 16 deletions(-)
Applied to net repo.
thanks,
Ben