Skip to contentSkip to conversation

pata_cmd640: implement sff_irq_check() method

PATCH In review Sergei Shtylyov 3 participants 3 messages Oct 8, 2010 – Oct 9, 2010 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 pata_cmd640: implement sff_irq_check() method

---
The patch is against the recent Linus' tree.

 drivers/ata/pata_cmd640.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/ata/pata_cmd640.c +12 -0
Index: linux-2.6/drivers/ata/pata_cmd640.c
===================================================================
@@ -161,6 +161,17 @@ static int cmd640_port_start(struct ata_
 	return 0;
 }
 
+static bool cmd640_sff_irq_check(struct ata_port *ap)
+{
+	struct pci_dev *pdev	= to_pci_dev(ap->host->dev);
+	int irq_reg		= ap->port_no ? ARTIM23 : CFR;
+	u8  irq_stat, irq_mask	= ap->port_no ? 0x10 : 0x04;
+
+	pci_read_config_byte(pdev, irq_reg, &irq_stat);
+
+	return irq_stat & irq_mask;
+}
+
 static struct scsi_host_template cmd640_sht = {
 	ATA_PIO_SHT(DRV_NAME),
 };
@@ -169,6 +180,7 @@ static struct ata_port_operations cmd640
 	.inherits	= &ata_sff_port_ops,
 	/* In theory xfer_noirq is not needed once we kill the prefetcher */
 	.sff_data_xfer	= ata_sff_data_xfer_noirq,
+	.sff_irq_check	= cmd640_sff_irq_check,
 	.qc_issue	= cmd640_qc_issue,
 	.cable_detect	= ata_cable_40wire,
 	.set_piomode	= cmd640_set_piomode,
#2 lore raw

Hello.

Quoted 6 lines · Alan Cox
Quoted 4 lines

---
The patch is against the recent Linus' tree.

Why is this needed

See
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=27943620cbd960f710a385ff4a538e14ed3f1922 for why this method was introduced.

Quoted 1 line

and what setups did you test ?

None. And given the usage of the method (it's called only for unexpected
interrupts now), it would be quite hard to test.

MBR, Sergei