vga: Mark VBE area as reserved in e820 tables
PATCH 1/1 vga: Mark VBE area as reserved in e820 tables
Otherwise the guest might try to use the range for device hotplug.
---
hw/vga.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
hw/vga.c +8 -0
@@ -2331,6 +2331,14 @@ void vga_init(VGACommonState *s)void vga_init_vbe (VGACommonState *s) {#ifdef CONFIG_BOCHS_VBE +#if defined (TARGET_I386 ) +if (e820_add_entry (VBE_DISPI_LFB_PHYSICAL_ADDRESS , +VGA_RAM_SIZE ,E820_RESERVED ) <0 ) { +fprintf (stderr, +"Warning: unable to register VBE range as e820 reserved\n" ); + } +#endif +/* XXX: use optimized standard vga accesses */ cpu_register_physical_memory (VBE_DISPI_LFB_PHYSICAL_ADDRESS ,VGA_RAM_SIZE , s->vram_offset);
Quoted 1 line · Alex Williamson
Otherwise the guest might try to use the range for device hotplug.
Aaaaarrgh.
/me tries to kill vga_init_vbe() usage for everything (but isa-vga) for *months* now. I want to zap the magic framebuffer @ VBE_DISPI_LFB_PHYSICAL_ADDRESS instead of trying to convince guests to not touch it using all kinds of voodoo.
Anthony, what is the status of the vgabios patches? Can we *please* finally merge them?
thanks,
Gerd
http://cgit.freedesktop.org/spice/qemu/log/?h=vgabios
http://cgit.freedesktop.org/~kraxel/vgabios/log/
Quoted 9 lines · Gerd Hoffmann
Quoted 1 line · Alex Williamson
Otherwise the guest might try to use the range for device hotplug.
Aaaaarrgh.
/me tries to kill
vga_init_vbe()usage for everything (but isa-vga) for *months* now. I want to zap the magic framebuffer @VBE_DISPI_LFB_PHYSICAL_ADDRESSinstead of trying to convince guests to not touch it using all kinds of voodoo.
Sorry I missed that. Sure, if we can zap it entirely and move it into the option ROM, that clearly seems like the way to go. Thanks,
Alex