Skip to contentSkip to conversation

Notification in Malloc

U-Boot Kostaras Nikolaos 2 participants 2 messages Oct 20, 2010

lore
Share & tools
lore
#0 lore raw

Hi,

During some tests with the u-boot-2010.09 source release, I discovered that when invoking malloc with size 0, the code proceeds and corrupts the malloc structures, thus totally breaking the malloc invocations from then on (malloc
will always fail after that). The cause of my problem was a burned flash chip,
that returned 0 in regions, in the "cfi_mtd_set_erasesize" call. My solution was
to modify the first check of malloc, in order not to freeze when there was an
error on the requested space. New condition includes the equal as well as the less:

                    if ((long)bytes <= 0) return 0;

This seems to fix the problems, after the malloc invocation with size 0. If there is
another way to deal with this, plz keep me posted.

Thanks,
Nik

#1 lore raw

Dear Kostaras Nikolaos,

Quoted 9 lines · In message <[email protected]> you wrote:

error on the requested space. New condition includes the equal as well as the less:

                    if ((long)bytes <= 0) return 0;

This seems to fix the problems, after the malloc invocation with size 0. If there is
another way to deal with this, plz keep me posted.

Makes sense.

Can you please provide a proper patch?

See http://www.denx.de/wiki/U-Boot/Patches for instructions.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be awake is to be alive.        - Henry David Thoreau, in "Walden"