RTC driver for PT7C4338 chip.
PATCH 1/1 RTC driver for PT7C4338 chip.
PT7C4338 chip is manufactured by Pericom Technology Inc. It is a serial real-time clock which provides:
1)Low-power clock/calendar.
2)Programmable square-wave output.
It has 56 bytes of nonvolatile RAM.
Freescale P1010RDB uses PT7C4338 as RTC.
--- drivers/rtc/Makefile | 1 + drivers/rtc/pt7c4338.c | 161 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 162 insertions(+), 0 deletions(-) create mode 100644 drivers/rtc/pt7c4338.c
drivers/rtc/Makefile +1 -0
@@ -62,6 +62,7 @@ COBJS-$(CONFIG_RTC_RX8025) += rx8025.o COBJS-$(CONFIG_RTC_S3C24X0) += s3c24x0_rtc.o COBJS-$(CONFIG_RTC_S3C44B0) += s3c44b0_rtc.o COBJS-$(CONFIG_RTC_X1205) += x1205.o +COBJS-$(CONFIG_RTC_PT7C4338) += pt7c4338.o COBJS := $(sort $(COBJS-y)) SRCS := $(COBJS:.o=.c)
drivers/rtc/pt7c4338.c new file +161 -0
161 lines not on this page · raw message
Signature · 1 line
1.6.5.6
PATCH 1/1 RTC driver for PT7C4338 chip.
Hello Priyanka,
Quoted 8 lines · Priyanka Jain
PT7C4338 chip is manufactured by Pericom Technology Inc. It is a serial real-time clock which provides:
1)Low-power clock/calendar.
2)Programmable square-wave output.
It has 56 bytes of nonvolatile RAM.Freescale P1010RDB uses PT7C4338 as RTC.
Quoted 7 lines
Signed-off-by Priyanka Jain <[email protected]>Acked-by Timur Tabi <[email protected]>--- drivers/rtc/Makefile | 1 + drivers/rtc/pt7c4338.c | 161 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 162 insertions(+), 0 deletions(-) create mode 100644 drivers/rtc/pt7c4338.c
just some nitpicking comments.
drivers/rtc/Makefile COBJS-$(CONFIG_RTC_RX8025) += rx8025.o · line 65
Quoted 9 lines
drivers/rtc/Makefile +1
-0@@ -62,6 +62,7 @@ COBJS-$(CONFIG_RTC_RX8025) += rx8025.o COBJS-$(CONFIG_RTC_S3C24X0) += s3c24x0_rtc.o COBJS-$(CONFIG_RTC_S3C44B0) += s3c44b0_rtc.o COBJS-$(CONFIG_RTC_X1205) += x1205.o +COBJS-$(CONFIG_RTC_PT7C4338) += pt7c4338.o
please keep lists sorted.
Quoted 23 lines
drivers/rtc/Makefile +0
-0COBJS := $(sort $(COBJS-y)) SRCS := $(COBJS:.o=.c)drivers/rtc/pt7c4338.c new file +15
-0@@ -0,0 +1,161 @@ +/* +* Copyright 2010 Freescale Semiconductor, Inc. +* +* Author: Priyanka Jain <[email protected]> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of
drivers/rtc/pt7c4338.c line 25
Quoted 10 lines
drivers/rtc/pt7c4338.c new file +10
-0+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +
only one new line.
Quoted 5 lines
drivers/rtc/pt7c4338.c new file +5
-0+/* +* This file provides Date & Time support (no alarms) for PT7C4338 chip. +* +* This file is based on drivers/rtc/ds1337.c +*
drivers/rtc/pt7c4338.c line 40
Quoted 10 lines
drivers/rtc/pt7c4338.c new file +10
-0+* PT7C4338 chip is manufactured by Pericom Technology Inc. +* It is a serial real-time clock which provides +* 1)Low-power clock/calendar. +* 2)Programmable square-wave output. +* It has 56 bytes of nonvolatile RAM. +* +* Freescale P1010RDB uses PT7C4338 as RTC. +*/ + +
here too, only one new line.
drivers/rtc/pt7c4338.c line 46
Quoted 6 lines
drivers/rtc/pt7c4338.c new file +6
-0+#include <common.h> +#include <command.h> +#include <rtc.h> +#include <i2c.h> + +
and here too.
Quoted 15 lines
drivers/rtc/pt7c4338.c new file +15
-0+/* RTC register addresses */ +#define RTC_SEC_REG_ADDR 0x0 +#define RTC_MIN_REG_ADDR 0x1 +#define RTC_HR_REG_ADDR 0x2 +#define RTC_DAY_REG_ADDR 0x3 +#define RTC_DATE_REG_ADDR 0x4 +#define RTC_MON_REG_ADDR 0x5 +#define RTC_YR_REG_ADDR 0x6 +#define RTC_CTL_STAT_REG_ADDR 0x7 + +/* RTC second register address bit */ +#define RTC_SEC_BIT_CH 0x80/* Clock Halt (in Register 0) */ + +/* RTC control and status register bits */ +#define RTC_CTL_STAT_BIT_RS0 0x1/* Rate select 0 */
drivers/rtc/pt7c4338.c line 71
Quoted 10 lines
drivers/rtc/pt7c4338.c new file +10
-0+#define RTC_CTL_STAT_BIT_RS1 0x2/* Rate select 1 */ +#define RTC_CTL_STAT_BIT_SQWE 0x10/* Square Wave Enable */ +#define RTC_CTL_STAT_BIT_OSF 0x20/* Oscillator Stop Flag */ +#define RTC_CTL_STAT_BIT_OUT 0x80/* Output Level Control */ + +/* RTC reset value */ +#define RTC_PT7C4338_RESET_VAL \ + (RTC_CTL_STAT_BIT_RS0 | RTC_CTL_STAT_BIT_RS1 | RTC_CTL_STAT_BIT_OUT) + +
and here too.
drivers/rtc/pt7c4338.c line 73
Quoted 2 lines
drivers/rtc/pt7c4338.c new file +2
-0+/****** Helper functions ****************************************/ +
no new line needed.
drivers/rtc/pt7c4338.c line 77
Quoted 4 lines
drivers/rtc/pt7c4338.c new file +4
-0+static u8 rtc_read (u8 reg) +{ +return i2c_reg_read (CONFIG_SYS_I2C_RTC_ADDR , reg); +}
[...]
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 RTC driver for PT7C4338 chip.
In reply to Priyanka JainDear Priyanka Jain,
Quoted 15 lines · In message <[email protected]> you…
PT7C4338 chip is manufactured by Pericom Technology Inc. It is a serial real-time clock which provides:
1)Low-power clock/calendar.
2)Programmable square-wave output.
It has 56 bytes of nonvolatile RAM.Freescale P1010RDB uses PT7C4338 as RTC.
Signed-off-by Priyanka Jain <[email protected]>Acked-by Timur Tabi <[email protected]>--- drivers/rtc/Makefile | 1 + drivers/rtc/pt7c4338.c | 161 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 162 insertions(+), 0 deletions(-) create mode 100644 drivers/rtc/pt7c4338.c
...
Quoted 15 lines
drivers/rtc/pt7c4338.c new file +15
-0+/* Get the current time from the RTC */ +int rtc_get (struct rtc_time *tmp) +{ +int ret =0 ; +u8 sec, min, hour, mday, wday, mon, year, ctl_stat; + + ctl_stat =rtc_read (RTC_CTL_STAT_REG_ADDR ); + sec =rtc_read (RTC_SEC_REG_ADDR ); + min =rtc_read (RTC_MIN_REG_ADDR ); + hour =rtc_read (RTC_HR_REG_ADDR ); + wday =rtc_read (RTC_DAY_REG_ADDR ); + mday =rtc_read (RTC_DATE_REG_ADDR ); + mon =rtc_read (RTC_MON_REG_ADDR ); + year =rtc_read (RTC_YR_REG_ADDR ); + debug("Get RTC year: %02x mon: %02x mday: %02x wday: %02x "
drivers/rtc/pt7c4338.c line 111
Quoted 10 lines
drivers/rtc/pt7c4338.c new file +10
-0+"hr: %02x min: %02x sec: %02x control_status: %02x\n" , + year, mon, mday, wday, hour, min, sec, ctl_stat); + +if (ctl_stat &RTC_CTL_STAT_BIT_OSF ) { +printf ("### Warning: RTC oscillator has stopped\n" ); +/* clear the OSF flag */ +rtc_write (RTC_CTL_STAT_REG_ADDR , +rtc_read (RTC_CTL_STAT_REG_ADDR )\ + & ~RTC_CTL_STAT_BIT_OSF ); + ret =-1 ;
I guess you want to return here, not fall through?
drivers/rtc/pt7c4338.c line 119
Quoted 8 lines
drivers/rtc/pt7c4338.c new file +8
-0+ } + +if (sec &RTC_SEC_BIT_CH ) { +printf ("### Warning: RTC oscillator has stopped\n" ); +/* clear the CH flag */ +rtc_write (RTC_SEC_REG_ADDR , +rtc_read (RTC_SEC_REG_ADDR ) & ~RTC_SEC_BIT_CH ); + ret =-1 ;
I guess you want to return here, not fall through?
Is it correct to have two different causes for the "Warning: RTC
oscillator has stopped" message? I would be a bit connnnnnnnnnnfused
what it means when I see this twice on a system.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Totally illogical, there was no chance. -- Spock, "The Galileo Seven", stardate 2822.3
PATCH 1/1 RTC driver for PT7C4338 chip.
Dear Wolfgang Denk,
Please find my answers to comments inline.
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Thursday, October 21, 2010 1:36 AM
To: Jain Priyanka-B32167
Cc: u-boot at lists.denx.de; Gala Kumar-B11780
Subject: Re: [U-Boot] [PATCH][v0] RTC driver for PT7C4338 chip.
Dear Priyanka Jain,
In message <[email protected]> you
Quoted 16 lines · wrote:
PT7C4338 chip is manufactured by Pericom Technology Inc. It is a serial real-time clock which provides:
1)Low-power clock/calendar.
2)Programmable square-wave output.
It has 56 bytes of nonvolatile RAM.Freescale P1010RDB uses PT7C4338 as RTC.
Signed-off-by Priyanka Jain <[email protected]>Acked-by Timur Tabi <[email protected]>--- drivers/rtc/Makefile | 1 + drivers/rtc/pt7c4338.c | 161 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 162 insertions(+), 0 deletions(-) create mode100644
drivers/rtc/pt7c4338.c
...
Quoted 14 lines
drivers/rtc/pt7c4338.c new file +14
-0+/* Get the current time from the RTC */ int rtc_get (struct rtc_time +*tmp) { +int ret =0 ; +u8 sec, min, hour, mday, wday, mon, year, ctl_stat; + + ctl_stat =rtc_read (RTC_CTL_STAT_REG_ADDR ); + sec =rtc_read (RTC_SEC_REG_ADDR ); + min =rtc_read (RTC_MIN_REG_ADDR ); + hour =rtc_read (RTC_HR_REG_ADDR ); + wday =rtc_read (RTC_DAY_REG_ADDR ); + mday =rtc_read (RTC_DATE_REG_ADDR ); + mon =rtc_read (RTC_MON_REG_ADDR ); + year =rtc_read (RTC_YR_REG_ADDR ); + debug("Get RTC year: %02x mon: %02x mday: %02x wday: %02x "
drivers/rtc/pt7c4338.c line 111
Quoted 10 lines
drivers/rtc/pt7c4338.c new file +10
-0+"hr: %02x min: %02x sec: %02x control_status: %02x\n" , + year, mon, mday, wday, hour, min, sec, ctl_stat); + +if (ctl_stat &RTC_CTL_STAT_BIT_OSF ) { +printf ("### Warning: RTC oscillator has stopped\n" ); +/* clear the OSF flag */ +rtc_write (RTC_CTL_STAT_REG_ADDR , +rtc_read (RTC_CTL_STAT_REG_ADDR )\ + & ~RTC_CTL_STAT_BIT_OSF ); + ret =-1 ;
I guess you want to return here, not fall through? [Priyanka] : It's a warning not an error. We can still continue with the functionality.
I hope this answer your query.
drivers/rtc/pt7c4338.c line 119
Quoted 8 lines
drivers/rtc/pt7c4338.c new file +8
-0+ } + +if (sec &RTC_SEC_BIT_CH ) { +printf ("### Warning: RTC oscillator has stopped\n" ); +/* clear the CH flag */ +rtc_write (RTC_SEC_REG_ADDR , +rtc_read (RTC_SEC_REG_ADDR ) & ~RTC_SEC_BIT_CH ); + ret =-1 ;
I guess you want to return here, not fall through? [Priyanka]: This check will be removed.
Is it correct to have two different causes for the "Warning: RTC
oscillator has stopped" message? I would be a bit connnnnnnnnnnfused
what it means when I see this twice on a system. [Priyanka]: I will merge both the condition checks into one.
Regards
Priyanka