Kirkwood: bugfix: broken early console messages
PATCH 1/1 Kirkwood: bugfix: broken early console messages
It has been observed that, the complete u-boot banner does not appear on the console when the system is booted from NAND/NOR/SPI flash.
This patch fixes this issue on all Marvell boards by adding board_early_init_f() support
--- board/Marvell/guruplug/guruplug.c | 6 +++++- board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 6 +++++- board/Marvell/openrd_base/openrd_base.c | 6 +++++- board/Marvell/rd6281a/rd6281a.c | 6 +++++- board/Marvell/sheevaplug/sheevaplug.c | 6 +++++- include/configs/mv-common.h | 1 + 6 files changed, 26 insertions(+), 5 deletions(-)
board/Marvell/guruplug/guruplug.c +5 -1
@@ -30,7 +30,7 @@DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {/* * default gpio configuration
@@ -96,7 +96,11 @@ int board_init(void) 0 };kirkwood_mpp_conf (kwmpp_config); +return 0 ; +} +int board_init (void ) +{/* * arch number of board */
board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c +5 -1
@@ -32,7 +32,7 @@DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {/* * default gpio configuration
@@ -98,7 +98,11 @@ int board_init(void) 0 };kirkwood_mpp_conf (kwmpp_config); +return 0 ; +} +int board_init (void ) +{/* * arch number of board */
board/Marvell/openrd_base/openrd_base.c +5 -1
@@ -35,7 +35,7 @@DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {/* * default gpio configuration
@@ -102,7 +102,11 @@ int board_init(void) };kirkwood_mpp_conf (kwmpp_config); +return 0 ; +} +int board_init (void ) +{/* * arch number of board */
board/Marvell/rd6281a/rd6281a.c +5 -1
@@ -31,7 +31,7 @@DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {/* * default gpio configuration
@@ -97,7 +97,11 @@ int board_init(void) 0 };kirkwood_mpp_conf (kwmpp_config); +return 0 ; +} +int board_init (void ) +{/* * arch number of board */
board/Marvell/sheevaplug/sheevaplug.c +5 -1
@@ -30,7 +30,7 @@DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {/* * default gpio configuration
@@ -96,7 +96,11 @@ int board_init(void) 0 };kirkwood_mpp_conf (kwmpp_config); +return 0 ; +} +int board_init (void ) +{/* * arch number of board */
include/configs/mv-common.h +1 -0
@@ -142,6 +142,7 @@#define CONFIG_CONSOLE_INFO_QUIET /* some code reduction */ #define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */ #define CONFIG_ARCH_MISC_INIT /* call arch_misc_init() */ +#define CONFIG_BOARD_EARLY_INIT_F /* call board_init_f for early inits*/ #define CONFIG_DISPLAY_CPUINFO/* Display cpu info */ #define CONFIG_NR_DRAM_BANKS 4#define CONFIG_STACKSIZE 0x00100000/* regular stack- 1M */
Signature · 1 line
1.5.3.3
PATCH 1/1 Kirkwood: bugfix: broken early console messages
Hello Prafulla,
Quoted 22 lines · Prafulla Wadaskar
It has been observed that, the complete u-boot banner does not appear on the console when the system is booted from NAND/NOR/SPI flash.
This patch fixes this issue on all Marvell boards by adding
board_early_init_f()supportSigned-off-by Prafulla Wadaskar <[email protected]>--- board/Marvell/guruplug/guruplug.c | 6 +++++- board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 6 +++++- board/Marvell/openrd_base/openrd_base.c | 6 +++++- board/Marvell/rd6281a/rd6281a.c | 6 +++++- board/Marvell/sheevaplug/sheevaplug.c | 6 +++++- include/configs/mv-common.h | 1 + 6 files changed, 26 insertions(+), 5 deletions(-)board/Marvell/guruplug/guruplug.c +0
-0
board/Marvell/guruplug/guruplug.c line 34
Quoted 6 lines
board/Marvell/guruplug/guruplug.c +1
-1@@ -30,7 +30,7 @@DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {
Maybe, you can make a mv-common.c which contains this (and maybe other mv common?) functions?
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 Kirkwood: bugfix: broken early console messages
Quoted 37 lines
-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Wednesday, October 20, 2010 4:42 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH] Kirkwood: bugfix: broken early console messagesHello Prafulla,
Quoted 17 lines · Prafulla Wadaskar
It has been observed that, the complete u-boot banner does not appear on the console when the system is booted from NAND/NOR/SPI flash.
This patch fixes this issue on all Marvell boards by adding
board_early_init_f()supportSigned-off-by Prafulla Wadaskar <[email protected]>--- board/Marvell/guruplug/guruplug.c | 6 +++++- board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c | 6 +++++- board/Marvell/openrd_base/openrd_base.c | 6 +++++- board/Marvell/rd6281a/rd6281a.c | 6 +++++- board/Marvell/sheevaplug/sheevaplug.c | 6 +++++- include/configs/mv-common.h | 1 + 6 files changed, 26 insertions(+), 5 deletions(-)Review
Quoted 1 line
(quoted diff) +0
-0
b/board/Marvell/guruplug/guruplug.cQuoted 5 lines
index 4df4e9b..1f0e67a 100644
board/Marvell/guruplug/guruplug.c +0
-0@@ -30,7 +30,7 @@
Quoted 8 lines
board/Marvell/guruplug/guruplug.c line 34
Quoted 5 lines
board/Marvell/guruplug/guruplug.c +1
-1DECLARE_GLOBAL_DATA_PTR ; -int board_init (void ) +int board_early_init_f (void ) {Maybe, you can make a
mv-common.cwhich contains this (and maybe other mv common?) functions?
I thought of it,
but specifically for this function, which is doing GPIOs and MPP configuration only, and generally it is very board specific.
But having mv-common.c is not a bad idea..
Let's check it out in next step :-)
Regards..
Prafulla . .