Skip to contentSkip to conversation

mx3: Enable PWM clock on mx31 and mx35

PATCH New Fabio Estevam 3 participants 3 messages Oct 22, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx3: Enable PWM clock on mx31 and mx35

mx3: Enable PWM clock on mx31 and mx35.

---
 arch/arm/mach-mx3/clock-imx31.c |    1 +
 arch/arm/mach-mx3/clock-imx35.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-mx3/clock-imx31.c +1 -0
index 109e98f..3926915 100644
@@ -612,6 +612,7 @@ int __init mx31_clocks_init(unsigned long fref)
 	clk_enable(&iim_clk);
 
 	clk_enable(&serial_pll_clk);
+	clk_enable(&pwm_clk);
 
 	mx31_read_cpu_rev();
 
arch/arm/mach-mx3/clock-imx35.c +2 -0
index 61e4a31..9796440 100644
@@ -536,6 +536,8 @@ int __init mx35_clocks_init()
 	__raw_writel(cgr3, CCM_BASE + CCM_CGR3);
 
 	clk_enable(&iim_clk);
+	clk_enable(&pwm_clk);
+
 	mx35_read_cpu_rev();
 
 #ifdef CONFIG_MXC_USE_EPIT
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 mx3: Enable PWM clock on mx31 and mx35

Hi Fabio,

Le 22/10/2010 13:13, Fabio Estevam a ?crit :

Quoted 2 lines

mx3: Enable PWM clock on mx31 and mx35.

Are you sure this in needed as when using the pwm.c driver in plat-mxc there are pwm_enable and pwm_disable functions ?

With your patch, platforms without PWM will have the pwm clock enabled.

Eric

#2 lore raw

PATCH 1/1 mx3: Enable PWM clock on mx31 and mx35

Quoted 9 lines · Eric B?nard

Hi Fabio,

Le 22/10/2010 13:13, Fabio Estevam a ?crit :

Quoted 2 lines

mx3: Enable PWM clock on mx31 and mx35.

Are you sure this in needed as when using the pwm.c driver in plat-mxc there are pwm_enable and pwm_disable functions ?

With your patch, platforms without PWM will have the pwm clock enabled.

Fabio, sorry if I have mislead you.

I wasn't properly using the plat-mxc/pwm.c driver (and hence the enable/disable functions were not getting called). I was just mucking about with the registers directly, first from userspace and then by putting some code in the driver probe function. So it was really strange for me that I couldn't do any writes.

If the plat-mxc/pwm.c driver is used properly I guess this patch won't be needed.

Regards,
Radoslav Kolev