Skip to contentSkip to conversation

XHCI: sleep inside atomic

DISCUSSION Jiri Slaby 2 participants 2 messages Oct 23, 2010 – Oct 25, 2010

lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

Hi,

Stanse found that commit
USB: xHCI: PCI power management implementation
added xhci_setup_msix->kmalloc(GFP_KERNEL) and request_irq inside xhci->lock spinlock. As these functions may sleep, this is deadlockable. Could you fix that?

thanks,

Signature · 1 line
js
#1 lore raw

Hmm....You're right. Thanks for catching this, I'll submit a patch later.

Thanks & Best regards,
Andiry

Quoted 5 lines

-----Original Message-----
From: Jiri Slaby [mailto:[email protected]]
Sent: Saturday, October 23, 2010 4:17 PM
To: Xu, Andiry
Cc: Nguyen, Dong; Yang, Libin; [email protected]; Greg KH;

USB

Quoted 9 lines

list; LKML
Subject: XHCI: sleep inside atomic

Hi,

Stanse found that commit
USB: xHCI: PCI power management implementation
added xhci_setup_msix->kmalloc(GFP_KERNEL) and request_irq inside xhci->lock spinlock. As these functions may sleep, this is

deadlockable.

Quoted 5 lines

Could you fix that?

thanks,
--
js