Skip to contentSkip to conversation

mmc: set tran_speed intead of hard setting

PATCH New Jaehoon Chung 2 participants 3 messages Oct 25, 2010 – Nov 17, 2010 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: set tran_speed intead of hard setting

This patch use card's tran_speed instead of hard setting value. I think mmc_set_clock(mmc, 52000000) is not good idea. because this is hard setting. we need use card's tran_speed.

So If card_caps did't support High speed, we need set card's speed value

---
 drivers/mmc/mmc.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/mmc/mmc.c +5 -4
index c543d83..f1b5552 100644
@@ -815,11 +815,12 @@ int mmc_startup(struct mmc *mmc)
 
 		if (mmc->card_caps & MMC_MODE_HS) {
 			if (mmc->card_caps & MMC_MODE_HS_52MHz)
-				mmc_set_clock(mmc, 52000000);
+				mmc->tran_speed = 52000000;
 			else
-				mmc_set_clock(mmc, 26000000);
-		} else
-			mmc_set_clock(mmc, 20000000);
+				mmc->tran_speed = 26000000;
+		}
+
+		mmc_set_clock(mmc, mmc->tran_speed);
 	}
 
 	/* fill in device description */
#1 lore raw

PATCH 1/1 mmc: set tran_speed intead of hard setting

Dear Wolfgang Denk,

Quoted 36 lines · Jaehoon Chung

This patch use card's tran_speed instead of hard setting value. I think mmc_set_clock(mmc, 52000000) is not good idea. because this is hard setting. we need use card's tran_speed.

So If card_caps did't support High speed, we need set card's speed value

---
?drivers/mmc/mmc.c | ? ?9 +++++----
?1 files changed, 5 insertions(+), 4 deletions(-)

drivers/mmc/mmc.c +1 -1
index c543d83..f1b5552 100644
@@ -815,11 +815,12 @@ int mmc_startup(struct mmc *mmc)
 
 ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS) {
 ? ? ? ? ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS_52MHz)
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 52000000);
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 52000000;

? ? ? ? ? ? ? ? ? ? ? ?else
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 26000000);
- ? ? ? ? ? ? ? } else
- ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 20000000);
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 26000000;
+ ? ? ? ? ? ? ? }
+
+ ? ? ? ? ? ? ? mmc_set_clock(mmc, mmc->tran_speed); ? ? ? ?}

Quoted 6 lines

? ? ? ?/* fill in device description */
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

This patch has already been reviewed by Andy.
http://lists.denx.de/pipermail/u-boot/2010-May/071213.html

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 1/1 mmc: set tran_speed intead of hard setting

Dear Wolfgang and Andy,

Quoted 39 lines · Minkyu Kang

Dear Wolfgang Denk,

Quoted 36 lines · Jaehoon Chung

This patch use card's tran_speed instead of hard setting value. I think mmc_set_clock(mmc, 52000000) is not good idea. because this is hard setting. we need use card's tran_speed.

So If card_caps did't support High speed, we need set card's speed value

---
?drivers/mmc/mmc.c | ? ?9 +++++----
?1 files changed, 5 insertions(+), 4 deletions(-)

drivers/mmc/mmc.c +1 -1
index c543d83..f1b5552 100644
@@ -815,11 +815,12 @@ int mmc_startup(struct mmc *mmc)
 
 ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS) {
 ? ? ? ? ? ? ? ? ? ? ? ?if (mmc->card_caps & MMC_MODE_HS_52MHz)
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 52000000);
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 52000000;

? ? ? ? ? ? ? ? ? ? ? ?else
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 26000000);
- ? ? ? ? ? ? ? } else
- ? ? ? ? ? ? ? ? ? ? ? mmc_set_clock(mmc, 20000000);
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc->tran_speed = 26000000;
+ ? ? ? ? ? ? ? }
+
+ ? ? ? ? ? ? ? mmc_set_clock(mmc, mmc->tran_speed); ? ? ? ?}

Quoted 1 line
Quoted 1 line

? ? ? ?/* fill in device description */

Is it NAK? or pending?

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net