Skip to contentSkip to conversation

Standalone Apps: Standalone apps should need only exports.h.

PATCH Superseded Mike Partington 4 participants 5 messages Oct 27, 2010 – Dec 7, 2011 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Standalone Apps: Standalone apps should need only exports.h.

From: Mike Partington <[email protected]>

Modify exports.h to remove its dependencies on other files, thus enabling standalone apps to require only exports.h from the U-Boot source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

---
 examples/standalone/atmel_df_pow2.c |    1 +
 examples/standalone/stubs.c         |    1 +
 include/exports.h                   |    5 +----
 3 files changed, 3 insertions(+), 4 deletions(-)
examples/standalone/atmel_df_pow2.c +1 -0
index b5b4503..2e14aba 100644
@@ -8,6 +8,7 @@
 
 #include <common.h>
 #include <exports.h>
+#include <spi.h>
 
 #define CMD_ID    0x9f
 #define CMD_STAT  0xd7
examples/standalone/stubs.c +1 -0
index 2d2e709..1ebe43b 100644
@@ -1,3 +1,4 @@
+#include <common.h>
 #include <exports.h>
 
 #ifndef GCC_VERSION
include/exports.h +1 -4
index 7404a7c..01b83dc 100644
@@ -3,8 +3,6 @@
 
 #ifndef __ASSEMBLY__
 
-#include <common.h>
-
 /* These are declarations of exported functions available in C code */
 unsigned long get_version(void);
 int  getc(void);
@@ -12,7 +10,7 @@ int  tstc(void);
 void putc(const char);
 void puts(const char*);
 int printf(const char* fmt, ...);
-void install_hdlr(int, interrupt_handler_t*, void*);
+void install_hdlr(int, void (*interrupt_handler_t)(void *), void*);
 void free_hdlr(int);
 void *malloc(size_t);
 void free(void*);
@@ -30,7 +28,6 @@ int ustrtoul(const char *cp, char **endp, unsigned int base);
 int i2c_write (uchar, uint, int , uchar* , int);
 int i2c_read (uchar, uint, int , uchar* , int);
 #endif
-#include <spi.h>
 
 void app_startup(char * const *);
 
Signature · 1 line
1.7.3.5.g4a3b
#1 lore raw

PATCH 1/1 Standalone Apps: Standalone apps should need only exports.h.

Quoted 8 lines · Mike Partington

From: Mike Partington <[email protected]>

Modify exports.h to remove its dependencies on other files, thus enabling standalone apps to require only exports.h from the U-Boot source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

You may want to tidy up your email address. I see you have a more generic email address that you sent the message from.

Rogan

#2 lore raw

PATCH v2 1/1 Standalone Apps: Standalone apps should need only exports.h.

Modify exports.h to remove its dependencies on other files, thus enabling standalone apps to require only exports.h from the U-Boot source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

---
Changes for v2:
- Replace domain specific email address with generic address

 examples/standalone/atmel_df_pow2.c |    1 +
 examples/standalone/stubs.c         |    1 +
 include/exports.h                   |    5 +----
 3 files changed, 3 insertions(+), 4 deletions(-)
examples/standalone/atmel_df_pow2.c +1 -0
index b5b4503..2e14aba 100644
@@ -8,6 +8,7 @@
 
 #include <common.h>
 #include <exports.h>
+#include <spi.h>
 
 #define CMD_ID    0x9f
 #define CMD_STAT  0xd7
examples/standalone/stubs.c +1 -0
index 2d2e709..1ebe43b 100644
@@ -1,3 +1,4 @@
+#include <common.h>
 #include <exports.h>
 
 #ifndef GCC_VERSION
include/exports.h +1 -4
index 7404a7c..01b83dc 100644
@@ -3,8 +3,6 @@
 
 #ifndef __ASSEMBLY__
 
-#include <common.h>
-
 /* These are declarations of exported functions available in C code */
 unsigned long get_version(void);
 int  getc(void);
@@ -12,7 +10,7 @@ int  tstc(void);
 void putc(const char);
 void puts(const char*);
 int printf(const char* fmt, ...);
-void install_hdlr(int, interrupt_handler_t*, void*);
+void install_hdlr(int, void (*interrupt_handler_t)(void *), void*);
 void free_hdlr(int);
 void *malloc(size_t);
 void free(void*);
@@ -30,7 +28,6 @@ int ustrtoul(const char *cp, char **endp, unsigned int base);
 int i2c_write (uchar, uint, int , uchar* , int);
 int i2c_read (uchar, uint, int , uchar* , int);
 #endif
-#include <spi.h>
 
 void app_startup(char * const *);
 
Signature · 1 line
1.7.3.5.g4a3b
#3 lore raw

PATCH v2 1/1 Standalone Apps: Standalone apps should need only exports.h.

Dear Mike Partington,

Quoted 6 lines · In message <[email protected]> you wrote:

Modify exports.h to remove its dependencies on other files, thus enabling standalone apps to require only exports.h from the U-Boot source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

Quoted 8 lines

---
Changes for v2:
- Replace domain specific email address with generic address

 examples/standalone/atmel_df_pow2.c |    1 +
 examples/standalone/stubs.c         |    1 +
 include/exports.h                   |    5 +----
 3 files changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lack of skill dictates economy of style.                - Joey Ramone
#4 lore raw

PATCH v2 1/1 Standalone Apps: Standalone apps should need only exports.h.

Quoted 18 lines · Wolfgang Denk

Dear Mike Partington,

Quoted 6 lines · In message <[email protected]> you wrote:

Modify exports.h to remove its dependencies on other files, thus enabling standalone apps to require only exports.h from the U-Boot source tree. This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

Quoted 8 lines

---
Changes for v2:
- Replace domain specific email address with generic address

examples/standalone/atmel_df_pow2.c |    1 +
examples/standalone/stubs.c         |    1 +
include/exports.h                   |    5 +----
3 files changed, 3 insertions(+), 4 deletions(-)
Quoted 5 lines

Applied, thanks.

Best regards,

Wolfgang Denk

This breaks builds:

In file included from qsort.c:19:0:
/local/home/galak/git/u-boot/include/exports.h:19:27: error: expected declaration specifiers or '...' before 'va_list' qsort.c: In function 'qsort':
qsort.c:30:3: warning: implicit declaration of function 'assert'

Simon has posted a patch that fixes:

http://patchwork.ozlabs.org/patch/129855/

- k