Are typedefs discouraged?
Hi All,
WARNING: do not add new typedefs
#64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19:
+typedef struct at91_shdwn {
total: 0 errors, 1 warnings, 45 lines checked
xx has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
I assume that "rule" does not apply to u-boot, and such warnings can be ignored?
However why would typedefs be discouraged in kernel?
Reinhard
Dear Reinhard Meyer,
Quoted 6 lines · In message <[email protected]> you wrote:
Hi All,
WARNING: do not add new typedefs
#64: FILE:arch/arm/include/asm/arch-at91/at91_shdwn.h:19:
+typedef structat91_shdwn{
Quoted 8 lines
total: 0 errors, 1 warnings, 45 lines checked
xx has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in
MAINTAINERS.I assume that "rule" does not apply to u-boot, and such warnings can be ignored?
No.
Quoted 1 line
However why would typedefs be discouraged in kernel?
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.Dear Wolfgang Denk,
Quoted 1 line
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Since no clause, not even (c) applies, I guess *ALL* at91 header files and drivers using them need a rework...
Best Regards,
Reinhard
Dear Reinhard Meyer,
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Since no clause, not even (c) applies, I guess *ALL* at91 header files and drivers using them need a rework...
Not really.
Just don't add new ones.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The universe is all a spin-off of the Big Bang.