Skip to contentSkip to conversation

Remove board_init_f function from nand_boot.c

PATCH Superseded Sughosh Ganu 3 participants 5 messages Nov 1, 2010

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 2/3 Remove board_init_f function from nand_boot.c

Remove the board_init_f function from nand_spl/nand_boot.c. This function is to be defined by all boards using the nand_spl functionality in their individual board directory.

Currently this function was being used by the smdk6400 board. Added the board specific function definition.

---
Changes since V4:
* Modified the subject line to indicate the correct function name being deleted
* Updated w.r.t mainline tot.

 board/samsung/smdk6400/smdk6400_nand_spl.c |   37 ++++++++++++++++++++++++++++
 nand_spl/board/samsung/smdk6400/Makefile   |    6 ++++-
 nand_spl/nand_boot.c                       |    8 ------
 3 files changed, 42 insertions(+), 9 deletions(-)
 create mode 100644 board/samsung/smdk6400/smdk6400_nand_spl.c
board/samsung/smdk6400/smdk6400_nand_spl.c new file +37 -0
new file mode 100644
index 0000000..a023284
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2002
+ * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
+ * Marius Groeger <[email protected]>
+ *
+ * (C) Copyright 2002
+ * David Mueller, ELSOFT AG, <[email protected]>
+ *
+ * (C) Copyright 2008
+ * Guennadi Liakhovetki, DENX Software Engineering, <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+
+void board_init_f(unsigned long bootflag)
+{
+	relocate_code(CONFIG_SYS_TEXT_BASE - TOTAL_MALLOC_LEN, NULL,
+			CONFIG_SYS_TEXT_BASE);
+}
nand_spl/board/samsung/smdk6400/Makefile +5 -1
index 2111e57..18cee10 100644
@@ -35,7 +35,7 @@ AFLAGS	+= -DCONFIG_NAND_SPL
 CFLAGS	+= -DCONFIG_NAND_SPL
 
 SOBJS	= start.o cpu_init.o lowlevel_init.o
-COBJS	= nand_boot.o nand_ecc.o s3c64xx.o
+COBJS	= nand_boot.o nand_ecc.o s3c64xx.o smdk6400_nand_spl.o
 
 SRCS	:= $(addprefix $(obj),$(SOBJS:.o=.S) $(COBJS:.o=.c))
 OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
@@ -93,6 +93,10 @@ $(obj)s3c64xx.c:
 	@rm -f $@
 	@ln -s $(TOPDIR)/drivers/mtd/nand/s3c64xx.c $@
 
+$(obj)smdk6400_nand_spl.c:
+	@rm -f $@
+	@ln -s $(TOPDIR)/board/samsung/smdk6400/smdk6400_nand_spl.c $@
+
 #########################################################################
 
 $(obj)%.o:	$(obj)%.S
nand_spl/nand_boot.c +0 -8
index d624418..b9fd6f5 100644
@@ -221,14 +221,6 @@ static int nand_load(struct mtd_info *mtd, unsigned int offs,
 	return 0;
 }
 
-#if defined(CONFIG_ARM)
-void board_init_f (ulong bootflag)
-{
-	relocate_code (CONFIG_SYS_TEXT_BASE - TOTAL_MALLOC_LEN, NULL,
-		       CONFIG_SYS_TEXT_BASE);
-}
-#endif
-
 /*
  * The main entry for NAND booting. It's necessary that SDRAM is already
  * configured and available since this code loads the main U-Boot image
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH v5 2/3 Remove board_init_f function from nand_boot.c

Le 01/11/2010 18:59, Sughosh Ganu a ?crit :

Quoted 3 lines

Remove the board_init_f function from nand_spl/nand_boot.c. This function is to be defined by all boards using the nand_spl functionality in their individual board directory.

Sorry, there's one thing I don't get, but I must admit I don't know the intricacies of NAND booting yet. Why should this be individualized? Seems to me that all boards using nand_spl will have the same board_init_f(), won't they?

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH v5 2/3 Remove board_init_f function from nand_boot.c

Quoted 4 lines · Albert ARIBAUD

Le 01/11/2010 18:59, Sughosh Ganu a ?crit :

Remove the board_init_f function from nand_spl/nand_boot.c. This

Quoted 9 lines
Quoted 3 lines

function is to be defined by all boards using the nand_spl functionality in their individual board directory.

Sorry, there's one thing I don't get, but I must admit I don't know the intricacies of NAND booting yet. Why should this be individualized? Seems to me that all boards using nand_spl will have the same board_init_f(), won't they?

This particular function in nand_boot.c was being used only by the
smdk6400. All other boards(notably freescale one's) define their own board_init_f under their board directory. I have made the change on similar lines, as different boards might want to do their own set of initialisations, e.g init console, which was not done here.

-sughosh

#3 lore raw

PATCH v5 2/3 Remove board_init_f function from nand_boot.c

In reply to Albert ARIBAUD
Quoted 10 lines · On Mon, 1 Nov 2010 19:08:36 +0100 Albert ARIBAUD <[email protected]> wrote:

Le 01/11/2010 18:59, Sughosh Ganu a ?crit :

Quoted 3 lines

Remove the board_init_f function from nand_spl/nand_boot.c. This function is to be defined by all boards using the nand_spl functionality in their individual board directory.

Sorry, there's one thing I don't get, but I must admit I don't know the intricacies of NAND booting yet. Why should this be individualized? Seems to me that all boards using nand_spl will have the same board_init_f(), won't they?

No, some boards could easily require board-specific init during the nand spl phase. There's lots of this on the powerpc side, but it hadn't been required on ARM yet (maybe they do more init in assembly?) -- until now.

-Scott

#4 lore raw

PATCH v5 2/3 Remove board_init_f function from nand_boot.c

Le 01/11/2010 19:14, Scott Wood a ?crit :

Quoted 14 lines
Quoted 10 lines · On Mon, 1 Nov 2010 19:08:36 +0100 Albert ARIBAUD<[email protected]> wrote:

Le 01/11/2010 18:59, Sughosh Ganu a ?crit :

Quoted 3 lines

Remove the board_init_f function from nand_spl/nand_boot.c. This function is to be defined by all boards using the nand_spl functionality in their individual board directory.

Sorry, there's one thing I don't get, but I must admit I don't know the intricacies of NAND booting yet. Why should this be individualized? Seems to me that all boards using nand_spl will have the same board_init_f(), won't they?

Quoted 4 lines

No, some boards could easily require board-specific init during the nand spl phase. There's lots of this on the powerpc side, but it hadn't been required on ARM yet (maybe they do more init in assembly?) -- until now.

That answers it -- thanks.

Amicalement,

Signature · 1 line
Albert.