Cleanup the test shm_open/2-1 to make a good format
PATCH 1/1 Cleanup the test shm_open/2-1 to make a good format
Although it's not important, but it makes a noise in the log.
----------------------------------------------------------------
Cleanup the test shm_open/2-1 to make a good format.
--- .../conformance/interfaces/shm_open/2-1.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +3 -1
@@ -17,7 +17,9 @@int main () { -printf ("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description." ); +printf ("Will not test that the shm_open() function create an open file" +"description that refers to the shared memory object and a file" +"descriptor that refers to that open file description.\n" );return PTS_UNTESTED ; }
Signature · 19 lines
1.7.0.4 -- Regards Bian Naimeng ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 16 lines · Bian Naimeng
Although it's not important, but it makes a noise in the log.
----------------------------------------------------------------
Cleanup the test shm_open/2-1 to make a good format.Signed-off-by Bian Naimeng <[email protected]>---
.../conformance/interfaces/shm_open/2-1.c | 4 +++-1 files changed, 3 insertions(+), 1 deletions(-)testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +0
-0
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c line 24
Quoted 9 lines
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +3
-1@@ -17,7 +17,9 @@ int main() { - printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description."); + printf("Will not test that the shm_open() function create an open file" + "description that refers to the shared memory object and a file" + "descriptor that refers to that open file description.\n"); return PTS_UNTESTED; }
Actually, that will look a lot worse because you just removed some
spaces in areas. description should be descriptor, etc.
I'll fix this up and give you credit for the note :).
Thanks,
-Garrett
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 10 lines
Quoted 10 lines
--- .../conformance/interfaces/shm_open/2-1.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +0
-0@@ -17,7 +17,9 @@
Quoted 11 lines
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c line 24
Quoted 8 lines
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +3
-1int main () { -printf ("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description." ); +printf ("Will not test that the shm_open() function create an open file" +"description that refers to the shared memory object and a file" +"descriptor that refers to that open file description.\n" );return PTS_UNTESTED ; }Actually, that will look a lot worse because you just removed some
spaces in areas. description should be descriptor, etc.
Yes, it's my mistake. Thank you for pointing out it. ^_^
Quoted 5 lines
Thanks,
-Garrett
Signature · 14 lines
Regards Bian Naimeng ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 22 lines · Bian Naimeng
Quoted 10 lines
Quoted 10 lines
---
.../conformance/interfaces/shm_open/2-1.c | 4 +++-1 files changed, 3 insertions(+), 1 deletions(-)testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +0
-0@@ -17,7 +17,9 @@Quoted 11 lines
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c line 24
Quoted 8 lines
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +3
-1int main() { - printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description."); + printf("Will not test that the shm_open() function create an open file" + "description that refers to the shared memory object and a file" + "descriptor that refers to that open file description.\n"); return PTS_UNTESTED; }Actually, that will look a lot worse because you just removed some spaces in areas. description should be descriptor, etc.
Quoted 1 line
Yes, it's my mistake. Thank you for pointing out it. ^_^
I'm tempted to just delete this test because it's a no-op. Anyone object?
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 21 lines · Garrett Cooper
Quoted 20 lines · Bian Naimeng
Quoted 20 lines
Quoted 9 lines
--- .../conformance/interfaces/shm_open/2-1.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +0
-0testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c line 24
Quoted 9 lines
testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c +3
-1@@ -17,7 +17,9 @@int main () { -printf ("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description." ); +printf ("Will not test that the shm_open() function create an open file" +"description that refers to the shared memory object and a file" +"descriptor that refers to that open file description.\n" );return PTS_UNTESTED ; }Actually, that will look a lot worse because you just removed some
spaces in areas. description should be descriptor, etc.
Quoted 4 lines
Quoted 1 line
Yes, it's my mistake. Thank you for pointing out it. ^_^
I'm tempted to just delete this test because it's a no-op. Anyone object?
It looks good to me.
Quoted 2 lines
Signature · 14 lines
Regards Bian Naimeng ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list