Skip to contentSkip to conversation

rds: Lost locking in loop connection freeing

PATCH New Pavel Emelyanov 1 participant 1 message Nov 2, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rds: Lost locking in loop connection freeing

The conn is removed from list in there and this requires proper lock protection.

---

net/rds/loop.c +4 -0
index c390156..aeec1d4 100644
@@ -134,8 +134,12 @@ static int rds_loop_conn_alloc(struct rds_connection *conn, gfp_t gfp)
 static void rds_loop_conn_free(void *arg)
 {
 	struct rds_loop_connection *lc = arg;
+	unsigned long flags;
+
 	rdsdebug("lc %p\n", lc);
+	spin_lock_irqsave(&loop_conns_lock, flags);
 	list_del(&lc->loop_node);
+	spin_unlock_irqrestore(&loop_conns_lock, flags);
 	kfree(lc);
 }
 
Signature · 1 line
1.5.5.6