Skip to contentSkip to conversation

Fix video support for vision2 board

PATCH New Renato Frias 2 participants 2 messages Nov 3, 2010

lore
Share & tools
lore
#0 lore raw

PATCH v2 3/3 Fix video support for vision2 board

From: Renato Frias <[email protected]>

Adds arguments to the mx51_fb_init call.

---
Changes for v2:
- Includes fix to vision2 (this commit) on the patch set

 board/ttcontrol/vision2/vision2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
board/ttcontrol/vision2/vision2.c +2 -2
index 071dad6..d818224 100644
@@ -43,7 +43,7 @@ DECLARE_GLOBAL_DATA_PTR;
 
 static u32 system_rev;
 
-extern int mx51_fb_init(struct fb_videomode *mode);
+extern int mx51_fb_init(struct fb_videomode *mode, u32 ipu_di, u32 pix_fmt);
 
 #ifdef CONFIG_HW_WATCHDOG
 #include <watchdog.h>
@@ -675,7 +675,7 @@ void lcd_enable(void)
 	mxc_gpio_set(2, 1);
 	mxc_request_iomux(MX51_PIN_GPIO1_2, IOMUX_CONFIG_ALT0);
 
-	ret = mx51_fb_init(&nec_nl6448bc26_09c);
+	ret = mx51_fb_init(&nec_nl6448bc26_09c, 0, 18);
 	if (ret)
 		puts("LCD cannot be configured\n");
 }
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH v2 3/3 Fix video support for vision2 board

board/ttcontrol/vision2/vision2.c void lcd_enable(void) · line 678

Quoted 11 lines · Renato Frias

From: Renato Frias <[email protected]>

Adds arguments to the mx51_fb_init call.

---
Changes for v2:
- Includes fix to vision2 (this commit) on the patch set

board/ttcontrol/vision2/vision2.c +1 -1
-	ret = mx51_fb_init(&nec_nl6448bc26_09c);
+	ret = mx51_fb_init(&nec_nl6448bc26_09c, 0, 18);

I think there is aa misunderstanding at this point. You introduce a new parameter (pix_fmt), that is used in the driver only to set up the vl_bpix field of the panel_info structure.The field vl_bpixis the number of bits x pixel that u-boot supports, in the range 1-4 (see defines LCD_COLOR* in lcd.h), as we can display in u-boot bitmaps up to 16 colors. The same apply for the previous patch for mx51evk.

The first question I have is if we really need this parameter. In the driver (bpp_to_pixfmt function) we do not support really less than 16 colors, so setting always panel_info.vl_bpix to LCD_COLOR16 seems to me correct.

And the driver itself does not use internally this parameter and instead of it takes interface_pix_fmt to set up the IPU.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================