Skip to contentSkip to conversation

scsi and megasas update

PATCH In review Hannes Reinecke 3 participants 4 messages Jun 15, 2010 – Nov 6, 2010

lore
Share & tools
lore
#0 lore raw

cover scsi and megasas update

Hi all,

I've run an I/O exerciser against the megasas emulation and found quite some issues, both with the HBA and the SCSI emulation.

- SG_IO returns -EDOM if the internal queue is exhausted; we should be mapping this to QUEUE_FULL.
- Codingstyle fixes for megasas as suggested by blueswirl
- We should be using the status codes as defined by SAM, not the linux ones (which are shifted by one)
- Each driver has it's own mechanism of storing the sense data, so we should be implementing an accessor scsi_req_sense() to retrieve it.
- And, of course, a rather largish megasas update

Patches are relative to nab's qemu-kvm git tree at
git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git

Nab, I think this patchset should make Windows happy.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
#1 lore raw
Quoted 16 lines · Hannes Reinecke

Hi all,

I've run an I/O exerciser against the megasas emulation and found quite some issues, both with the HBA and the SCSI emulation.

- SG_IO returns -EDOM if the internal queue is exhausted; we should be mapping this to QUEUE_FULL.
- Codingstyle fixes for megasas as suggested by blueswirl
- We should be using the status codes as defined by SAM, not the linux ones (which are shifted by one)
- Each driver has it's own mechanism of storing the sense data, so we should be implementing an accessor scsi_req_sense() to retrieve it.
- And, of course, a rather largish megasas update

Quoted 4 lines

Patches are relative to nab's qemu-kvm git tree at
git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git

Nab, I think this patchset should make Windows happy.

Got an updated version? :)
I'd also love to see some performance numbers on this. How well does it perform against virtio?

Alex

#2 lore raw
Quoted 19 lines · Alexander Graf
Quoted 16 lines · Hannes Reinecke

Hi all,

I've run an I/O exerciser against the megasas emulation and found quite some issues, both with the HBA and the SCSI emulation.

- SG_IO returns -EDOM if the internal queue is exhausted; we should be mapping this to QUEUE_FULL.
- Codingstyle fixes for megasas as suggested by blueswirl
- We should be using the status codes as defined by SAM, not the linux ones (which are shifted by one)
- Each driver has it's own mechanism of storing the sense data, so we should be implementing an accessor scsi_req_sense() to retrieve it.
- And, of course, a rather largish megasas update

Quoted 6 lines
Quoted 4 lines

Patches are relative to nab's qemu-kvm git tree at
git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git

Nab, I think this patchset should make Windows happy.

Got an updated version? :)

Sadly, no. I've got a git repository setup at kernel.org, but so far failed to do anything with it.
Real life intercepting as per normal.

But on the good side I have the patchset cleaned up to avoid the contested SCSI update.
IE the megasas emulation is now using the 'standard' SCSI callback mechanism.

I see to have the patchset pushed to kernel.org and will send a pointer then.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
#3 lore raw
Quoted 6 lines · Hannes Reinecke
Quoted 2 lines · Alexander Graf

Got an updated version? :)

I see to have the patchset pushed to kernel.org
and will send a pointer then.

I'm also interested in seeing the latest and greatest megasas :).

Stefan