rtc: jz4740: signedness bug

PATCH In review Dan Carpenter 2 participants 2 messages Nov 13, 2010

Subsystems (3)

Kernel janitors Real time clock (RTC) Ingenic JZ47xx SoCs

lore

Share & tools

lore

Dan Carpenter

author

2010-11-13 18:26 UTC #0 lore raw

PATCH 1/1 rtc: jz4740: signedness bug

platform_get_irq() can return negatives so the rtc->irq should be signed to handle it.

Signed-off-by Dan Carpenter <[email protected]>

drivers/rtc/rtc-jz4740.c +1 -1

index 2e16f72..cfcd2da 100644
@@ -42,7 +42,7 @@ struct jz4740_rtc {
 
 	struct rtc_device *rtc;
 
-	unsigned int irq;
+	int irq;
 
 	spinlock_t lock;
 };

Lars-Peter Clausen

Acked-by on v1 1/1

2010-11-13 20:02 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

platform_get_irq() can return negatives so the rtc->irq should be signed to handle it.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Lars-Peter Clausen <[email protected]>

Thanks.

Quoted 14 lines

drivers/rtc/rtc-jz4740.c +1 -1

index 2e16f72..cfcd2da 100644
@@ -42,7 +42,7 @@ struct jz4740_rtc {
 
 	struct rtc_device *rtc;
 
-	unsigned int irq;
+	int irq;
 
 	spinlock_t lock;
 };