Skip to contentSkip to conversation

ixgbe dump

DISCUSSION Yinghai Lu 3 participants 8 messages Nov 18, 2010 – Nov 23, 2010

Subsystems (2)
lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw
[ 1546.287521] md: stopping all md devices.
[ 1547.283729] kvm: exiting hardware virtualization
[ 1547.292876] sd 2:2:1:0: [sdb] Synchronizing SCSI cache
[ 1547.293831] sd 2:2:0:0: [sda] Synchronizing SCSI cache
[ 1547.299627] BUG: unable to handle kernel NULL pointer dereference at 0000000000000033
[ 1547.315819] IP: [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.316448] PGD 3ff4487067 PUD 3ff216b067 PMD 0 
[ 1547.335626] Oops: 0000 [#1] SMP 
[ 1547.335941] last sysfs file: /sys/kernel/kexec_loaded
[ 1547.336381] CPU 0 
[ 1547.336548] Modules linked in:
[ 1547.355798] 
[ 1547.355968] Pid: 25630, comm: kexec Not tainted 2.6.37-rc2-tip-yh-01961-g6034289-dirty #281      /Sun Fire X4800
[ 1547.375849] RIP: 0010:[<ffffffff81746273>]  [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.395543] RSP: 0018:ffff881fb9d49ce8  EFLAGS: 00010287
[ 1547.396080] RAX: 0000000000000000 RBX: ffff88dffe5a0940 RCX: ffff88dffe5a0940
[ 1547.415635] RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffffc90077780000
[ 1547.416299] RBP: ffff881fb9d49d48 R08: 0000000000000000 R09: 0000000000000000
[ 1547.435860] R10: 000000000000a608 R11: 0000000000000000 R12: 0000000000000000
[ 1547.455516] R13: ffff88dffe5a0000 R14: 0000000000003400 R15: ffff881fb9d49db7
[ 1547.456257] FS:  00000000006e0850(0063) GS:ffff88207d600000(0000) knlGS:0000000000000000
[ 1547.475937] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 1547.495330] CR2: 0000000000000033 CR3: 0000003ffa77e000 CR4: 00000000000006f0
[ 1547.496009] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1547.515594] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 1547.516229] Process kexec (pid: 25630, threadinfo ffff881fb9d48000, task ffff881f8a57a2d0)
[ 1547.536039] Stack:
[ 1547.536244]  0000000000000040 0000002b00000000 ffff881ffedc1000 0000000000000006
[ 1547.555894]  ffff88dffe5a1b40 0b00000081454ec8 ffff881fb9d49d48 ffff88dffe5a0940
[ 1547.575411]  ffff881ffedc1000 000000000000001e 0000000000000000 ffff881fb9d49db7
[ 1547.576131] Call Trace:
[ 1547.595251]  [<ffffffff8174a8f4>] __ixgbe_shutdown+0x9d/0x153
[ 1547.595770]  [<ffffffff8174a9c4>] ixgbe_shutdown+0x1a/0x43
[ 1547.615250]  [<ffffffff814574bb>] pci_device_shutdown+0x2c/0x40
[ 1547.615887]  [<ffffffff8151c5e9>] device_shutdown+0x75/0xb0
[ 1547.635268]  [<ffffffff8108f461>] kernel_restart_prepare+0x2c/0x33
[ 1547.635927]  [<ffffffff810bc821>] kernel_kexec+0x38/0x6b
[ 1547.655252]  [<ffffffff8108f618>] sys_reboot+0x156/0x194
[ 1547.655765]  [<ffffffff8114422a>] ? __d_free+0x59/0x5e
[ 1547.675145]  [<ffffffff81144283>] ? d_free+0x54/0x66
[ 1547.675612]  [<ffffffff8114439d>] ? d_kill+0x3b/0x43
[ 1547.695025]  [<ffffffff81144a1c>] ? dput+0x40/0x140
[ 1547.695539]  [<ffffffff811351a9>] ? fput+0x1d7/0x1e6
[ 1547.696045]  [<ffffffff81036c0c>] ? sysret_check+0x27/0x62
[ 1547.715426]  [<ffffffff81cd9772>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 1547.734897]  [<ffffffff81036bdb>] system_call_fastpath+0x16/0x1b
[ 1547.735428] Code: d2 e9 81 00 00 00 48 8b 83 00 12 00 00 8b 80 88 50 00 00 0d 00 00 00 80 e9 a7 00 00 00 48 8b 81 00 0a 00 00 48 8b bb 00 12 00 00 <0f> b6 40 33 83 f8 3f 7f 0d 89 c6 c1 e6 06 81 c6 28 10 00 00 eb 
[ 1547.775262] RIP  [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.775909]  RSP <ffff881fb9d49ce8>
[ 1547.794997] CR2: 0000000000000033
[ 1547.795987] ---[ end trace 4ed9616adc45007c ]---
#1 lore raw
Quoted 77 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Yinghai Lu
Sent: Wednesday, November 17, 2010 5:22 PM
To: Brandeburg, Jesse; David Miller
Cc: NetDev
Subject: ixgbe dump

[ 1546.287521] md: stopping all md devices.
[ 1547.283729] kvm: exiting hardware virtualization
[ 1547.292876] sd 2:2:1:0: [sdb] Synchronizing SCSI cache
[ 1547.293831] sd 2:2:0:0: [sda] Synchronizing SCSI cache
[ 1547.299627] BUG: unable to handle kernel NULL pointer dereference at
0000000000000033
[ 1547.315819] IP: [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.316448] PGD 3ff4487067 PUD 3ff216b067 PMD 0
[ 1547.335626] Oops: 0000 [#1] SMP
[ 1547.335941] last sysfs file: /sys/kernel/kexec_loaded
[ 1547.336381] CPU 0
[ 1547.336548] Modules linked in:
[ 1547.355798]
[ 1547.355968] Pid: 25630, comm: kexec Not tainted 2.6.37-rc2-tip-yh-01961-
g6034289-dirty #281      /Sun Fire X4800
[ 1547.375849] RIP: 0010:[<ffffffff81746273>]  [<ffffffff81746273>]
ixgbe_set_rx_mode+0x265/0x38e
[ 1547.395543] RSP: 0018:ffff881fb9d49ce8  EFLAGS: 00010287
[ 1547.396080] RAX: 0000000000000000 RBX: ffff88dffe5a0940 RCX:
ffff88dffe5a0940
[ 1547.415635] RDX: 0000000000000000 RSI: 0000000000000001 RDI:
ffffc90077780000
[ 1547.416299] RBP: ffff881fb9d49d48 R08: 0000000000000000 R09:
0000000000000000
[ 1547.435860] R10: 000000000000a608 R11: 0000000000000000 R12:
0000000000000000
[ 1547.455516] R13: ffff88dffe5a0000 R14: 0000000000003400 R15:
ffff881fb9d49db7
[ 1547.456257] FS:  00000000006e0850(0063) GS:ffff88207d600000(0000)
knlGS:0000000000000000
[ 1547.475937] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 1547.495330] CR2: 0000000000000033 CR3: 0000003ffa77e000 CR4:
00000000000006f0
[ 1547.496009] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
0000000000000000
[ 1547.515594] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7:
0000000000000400
[ 1547.516229] Process kexec (pid: 25630, threadinfo ffff881fb9d48000, task
ffff881f8a57a2d0)
[ 1547.536039] Stack:
[ 1547.536244]  0000000000000040 0000002b00000000 ffff881ffedc1000
0000000000000006
[ 1547.555894]  ffff88dffe5a1b40 0b00000081454ec8 ffff881fb9d49d48
ffff88dffe5a0940
[ 1547.575411]  ffff881ffedc1000 000000000000001e 0000000000000000
ffff881fb9d49db7
[ 1547.576131] Call Trace:
[ 1547.595251]  [<ffffffff8174a8f4>] __ixgbe_shutdown+0x9d/0x153
[ 1547.595770]  [<ffffffff8174a9c4>] ixgbe_shutdown+0x1a/0x43
[ 1547.615250]  [<ffffffff814574bb>] pci_device_shutdown+0x2c/0x40
[ 1547.615887]  [<ffffffff8151c5e9>] device_shutdown+0x75/0xb0
[ 1547.635268]  [<ffffffff8108f461>] kernel_restart_prepare+0x2c/0x33
[ 1547.635927]  [<ffffffff810bc821>] kernel_kexec+0x38/0x6b
[ 1547.655252]  [<ffffffff8108f618>] sys_reboot+0x156/0x194
[ 1547.655765]  [<ffffffff8114422a>] ? __d_free+0x59/0x5e
[ 1547.675145]  [<ffffffff81144283>] ? d_free+0x54/0x66
[ 1547.675612]  [<ffffffff8114439d>] ? d_kill+0x3b/0x43
[ 1547.695025]  [<ffffffff81144a1c>] ? dput+0x40/0x140
[ 1547.695539]  [<ffffffff811351a9>] ? fput+0x1d7/0x1e6
[ 1547.696045]  [<ffffffff81036c0c>] ? sysret_check+0x27/0x62
[ 1547.715426]  [<ffffffff81cd9772>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 1547.734897]  [<ffffffff81036bdb>] system_call_fastpath+0x16/0x1b
[ 1547.735428] Code: d2 e9 81 00 00 00 48 8b 83 00 12 00 00 8b 80 88 50 00
00 0d 00 00 00 80 e9 a7 00 00 00 48 8b 81 00 0a 00 00 48 8b bb 00 12 00 00
<0f> b6 40 33 83 f8 3f 7f 0d 89 c6 c1 e6 06 81 c6 28 10 00 00 eb
[ 1547.775262] RIP  [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.775909]  RSP <ffff881fb9d49ce8>
[ 1547.794997] CR2: 0000000000000033
[ 1547.795987] ---[ end trace 4ed9616adc45007c ]---
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks for the dump.

I believe I've found the problem and will get a patch to Jeff shortly.

Thanks again,
-Don Skidmore <[email protected]>

author
#2 lore raw
Quoted 82 lines · Donald C
Quoted 77 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Yinghai Lu
Sent: Wednesday, November 17, 2010 5:22 PM
To: Brandeburg, Jesse; David Miller
Cc: NetDev
Subject: ixgbe dump

[ 1546.287521] md: stopping all md devices.
[ 1547.283729] kvm: exiting hardware virtualization
[ 1547.292876] sd 2:2:1:0: [sdb] Synchronizing SCSI cache
[ 1547.293831] sd 2:2:0:0: [sda] Synchronizing SCSI cache
[ 1547.299627] BUG: unable to handle kernel NULL pointer dereference at
0000000000000033
[ 1547.315819] IP: [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.316448] PGD 3ff4487067 PUD 3ff216b067 PMD 0
[ 1547.335626] Oops: 0000 [#1] SMP
[ 1547.335941] last sysfs file: /sys/kernel/kexec_loaded
[ 1547.336381] CPU 0
[ 1547.336548] Modules linked in:
[ 1547.355798]
[ 1547.355968] Pid: 25630, comm: kexec Not tainted 2.6.37-rc2-tip-yh-01961-
g6034289-dirty #281      /Sun Fire X4800
[ 1547.375849] RIP: 0010:[<ffffffff81746273>]  [<ffffffff81746273>]
ixgbe_set_rx_mode+0x265/0x38e
[ 1547.395543] RSP: 0018:ffff881fb9d49ce8  EFLAGS: 00010287
[ 1547.396080] RAX: 0000000000000000 RBX: ffff88dffe5a0940 RCX:
ffff88dffe5a0940
[ 1547.415635] RDX: 0000000000000000 RSI: 0000000000000001 RDI:
ffffc90077780000
[ 1547.416299] RBP: ffff881fb9d49d48 R08: 0000000000000000 R09:
0000000000000000
[ 1547.435860] R10: 000000000000a608 R11: 0000000000000000 R12:
0000000000000000
[ 1547.455516] R13: ffff88dffe5a0000 R14: 0000000000003400 R15:
ffff881fb9d49db7
[ 1547.456257] FS:  00000000006e0850(0063) GS:ffff88207d600000(0000)
knlGS:0000000000000000
[ 1547.475937] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 1547.495330] CR2: 0000000000000033 CR3: 0000003ffa77e000 CR4:
00000000000006f0
[ 1547.496009] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
0000000000000000
[ 1547.515594] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7:
0000000000000400
[ 1547.516229] Process kexec (pid: 25630, threadinfo ffff881fb9d48000, task
ffff881f8a57a2d0)
[ 1547.536039] Stack:
[ 1547.536244]  0000000000000040 0000002b00000000 ffff881ffedc1000
0000000000000006
[ 1547.555894]  ffff88dffe5a1b40 0b00000081454ec8 ffff881fb9d49d48
ffff88dffe5a0940
[ 1547.575411]  ffff881ffedc1000 000000000000001e 0000000000000000
ffff881fb9d49db7
[ 1547.576131] Call Trace:
[ 1547.595251]  [<ffffffff8174a8f4>] __ixgbe_shutdown+0x9d/0x153
[ 1547.595770]  [<ffffffff8174a9c4>] ixgbe_shutdown+0x1a/0x43
[ 1547.615250]  [<ffffffff814574bb>] pci_device_shutdown+0x2c/0x40
[ 1547.615887]  [<ffffffff8151c5e9>] device_shutdown+0x75/0xb0
[ 1547.635268]  [<ffffffff8108f461>] kernel_restart_prepare+0x2c/0x33
[ 1547.635927]  [<ffffffff810bc821>] kernel_kexec+0x38/0x6b
[ 1547.655252]  [<ffffffff8108f618>] sys_reboot+0x156/0x194
[ 1547.655765]  [<ffffffff8114422a>] ? __d_free+0x59/0x5e
[ 1547.675145]  [<ffffffff81144283>] ? d_free+0x54/0x66
[ 1547.675612]  [<ffffffff8114439d>] ? d_kill+0x3b/0x43
[ 1547.695025]  [<ffffffff81144a1c>] ? dput+0x40/0x140
[ 1547.695539]  [<ffffffff811351a9>] ? fput+0x1d7/0x1e6
[ 1547.696045]  [<ffffffff81036c0c>] ? sysret_check+0x27/0x62
[ 1547.715426]  [<ffffffff81cd9772>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 1547.734897]  [<ffffffff81036bdb>] system_call_fastpath+0x16/0x1b
[ 1547.735428] Code: d2 e9 81 00 00 00 48 8b 83 00 12 00 00 8b 80 88 50 00
00 0d 00 00 00 80 e9 a7 00 00 00 48 8b 81 00 0a 00 00 48 8b bb 00 12 00 00
<0f> b6 40 33 83 f8 3f 7f 0d 89 c6 c1 e6 06 81 c6 28 10 00 00 eb
[ 1547.775262] RIP  [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.775909]  RSP <ffff881fb9d49ce8>
[ 1547.794997] CR2: 0000000000000033
[ 1547.795987] ---[ end trace 4ed9616adc45007c ]---
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Quoted 3 lines

Thanks for the dump.

I believe I've found the problem and will get a patch to Jeff shortly.

Did you have that patch posted already?

Thanks

Yinghai

#3 lore raw
Quoted 86 lines · Yinghai Lu
Quoted 84 lines · Donald C
Quoted 77 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Yinghai Lu
Sent: Wednesday, November 17, 2010 5:22 PM
To: Brandeburg, Jesse; David Miller
Cc: NetDev
Subject: ixgbe dump

[ 1546.287521] md: stopping all md devices.
[ 1547.283729] kvm: exiting hardware virtualization
[ 1547.292876] sd 2:2:1:0: [sdb] Synchronizing SCSI cache
[ 1547.293831] sd 2:2:0:0: [sda] Synchronizing SCSI cache
[ 1547.299627] BUG: unable to handle kernel NULL pointer dereference at
0000000000000033
[ 1547.315819] IP: [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.316448] PGD 3ff4487067 PUD 3ff216b067 PMD 0
[ 1547.335626] Oops: 0000 [#1] SMP
[ 1547.335941] last sysfs file: /sys/kernel/kexec_loaded
[ 1547.336381] CPU 0
[ 1547.336548] Modules linked in:
[ 1547.355798]
[ 1547.355968] Pid: 25630, comm: kexec Not tainted 2.6.37-rc2-tip-yh-01961-
g6034289-dirty #281      /Sun Fire X4800
[ 1547.375849] RIP: 0010:[<ffffffff81746273>]  [<ffffffff81746273>]
ixgbe_set_rx_mode+0x265/0x38e
[ 1547.395543] RSP: 0018:ffff881fb9d49ce8  EFLAGS: 00010287
[ 1547.396080] RAX: 0000000000000000 RBX: ffff88dffe5a0940 RCX:
ffff88dffe5a0940
[ 1547.415635] RDX: 0000000000000000 RSI: 0000000000000001 RDI:
ffffc90077780000
[ 1547.416299] RBP: ffff881fb9d49d48 R08: 0000000000000000 R09:
0000000000000000
[ 1547.435860] R10: 000000000000a608 R11: 0000000000000000 R12:
0000000000000000
[ 1547.455516] R13: ffff88dffe5a0000 R14: 0000000000003400 R15:
ffff881fb9d49db7
[ 1547.456257] FS:  00000000006e0850(0063) GS:ffff88207d600000(0000)
knlGS:0000000000000000
[ 1547.475937] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 1547.495330] CR2: 0000000000000033 CR3: 0000003ffa77e000 CR4:
00000000000006f0
[ 1547.496009] DR0: 0000000000000000 DR1: 0000000000000000 DR2:
0000000000000000
[ 1547.515594] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7:
0000000000000400
[ 1547.516229] Process kexec (pid: 25630, threadinfo ffff881fb9d48000, task
ffff881f8a57a2d0)
[ 1547.536039] Stack:
[ 1547.536244]  0000000000000040 0000002b00000000 ffff881ffedc1000
0000000000000006
[ 1547.555894]  ffff88dffe5a1b40 0b00000081454ec8 ffff881fb9d49d48
ffff88dffe5a0940
[ 1547.575411]  ffff881ffedc1000 000000000000001e 0000000000000000
ffff881fb9d49db7
[ 1547.576131] Call Trace:
[ 1547.595251]  [<ffffffff8174a8f4>] __ixgbe_shutdown+0x9d/0x153
[ 1547.595770]  [<ffffffff8174a9c4>] ixgbe_shutdown+0x1a/0x43
[ 1547.615250]  [<ffffffff814574bb>] pci_device_shutdown+0x2c/0x40
[ 1547.615887]  [<ffffffff8151c5e9>] device_shutdown+0x75/0xb0
[ 1547.635268]  [<ffffffff8108f461>] kernel_restart_prepare+0x2c/0x33
[ 1547.635927]  [<ffffffff810bc821>] kernel_kexec+0x38/0x6b
[ 1547.655252]  [<ffffffff8108f618>] sys_reboot+0x156/0x194
[ 1547.655765]  [<ffffffff8114422a>] ? __d_free+0x59/0x5e
[ 1547.675145]  [<ffffffff81144283>] ? d_free+0x54/0x66
[ 1547.675612]  [<ffffffff8114439d>] ? d_kill+0x3b/0x43
[ 1547.695025]  [<ffffffff81144a1c>] ? dput+0x40/0x140
[ 1547.695539]  [<ffffffff811351a9>] ? fput+0x1d7/0x1e6
[ 1547.696045]  [<ffffffff81036c0c>] ? sysret_check+0x27/0x62
[ 1547.715426]  [<ffffffff81cd9772>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[ 1547.734897]  [<ffffffff81036bdb>] system_call_fastpath+0x16/0x1b
[ 1547.735428] Code: d2 e9 81 00 00 00 48 8b 83 00 12 00 00 8b 80 88 50 00
00 0d 00 00 00 80 e9 a7 00 00 00 48 8b 81 00 0a 00 00 48 8b bb 00 12 00 00
<0f> b6 40 33 83 f8 3f 7f 0d 89 c6 c1 e6 06 81 c6 28 10 00 00 eb
[ 1547.775262] RIP  [<ffffffff81746273>] ixgbe_set_rx_mode+0x265/0x38e
[ 1547.775909]  RSP <ffff881fb9d49ce8>
[ 1547.794997] CR2: 0000000000000033
[ 1547.795987] ---[ end trace 4ed9616adc45007c ]---
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks for the dump.

Quoted 7 lines
Quoted 1 line

I believe I've found the problem and will get a patch to Jeff shortly.

Did you have that patch posted already?

Thanks

Yinghai

It is not posted yet. Don got the patch to our testers and they are doing a quick validation on the patch before I post it to netdev.

I can send you the patch, so that you can assist in letting us know if it resolves the issue.

Cheers,
Jeff

author
#4 lore raw
Quoted 6 lines · Jeff Kirsher

It is not posted yet. Don got the patch to our testers and they are doing a quick validation on the patch before I post it to netdev.

I can send you the patch, so that you can assist in letting us know if it resolves the issue.

sure. please send that to me.

Thanks

#5 lore raw

Hi Yinghai,

I was hoping we could have had this patch pushed upstream sooner, but we have quite a few in our internal queue right now.

If this doesn't solve your issue please let me know.

Thanks,
-Don Skidmore <[email protected]>

After freeing the rings we were not zeroing out the ring count values. This patch now clears these counts correctly.

---

 drivers/net/ixgbe/ixgbe_main.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +3 -0
index fbad4d8..eee0b29 100644
@@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter)
 		adapter->rx_ring[i] = NULL;
 	}
 
+	adapter->num_tx_queues = 0;
+	adapter->num_rx_queues = 0;
+
 	ixgbe_free_q_vectors(adapter);
 	ixgbe_reset_interrupt_capability(adapter);
 }
Quoted 20 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Yinghai Lu
Sent: Monday, November 22, 2010 3:28 PM
To: Kirsher, Jeffrey T
Cc: Skidmore, Donald C; Brandeburg, Jesse; David Miller; NetDev
Subject: Re: ixgbe dump

Quoted 6 lines · Jeff Kirsher

It is not posted yet. Don got the patch to our testers and they are doing a quick validation on the patch before I post it to netdev.

I can send you the patch, so that you can assist in letting us know if it resolves the issue.

sure. please send that to me.

Thanks

author
#6 lore raw
Quoted 28 lines · Donald C

Hi Yinghai,

I was hoping we could have had this patch pushed upstream sooner, but we have quite a few in our internal queue right now.

If this doesn't solve your issue please let me know.

Thanks,
-Don Skidmore <[email protected]>

After freeing the rings we were not zeroing out the ring count values. This patch now clears these counts correctly.

---

 drivers/net/ixgbe/ixgbe_main.c |    3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +0 -0
index fbad4d8..eee0b29 100644

drivers/net/ixgbe/ixgbe_main.c void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter) · line 4779

Quoted 9 lines
drivers/net/ixgbe/ixgbe_main.c +3 -0
@@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter)
                adapter->rx_ring[i] = NULL;
        }
 
+       adapter->num_tx_queues = 0;
+       adapter->num_rx_queues = 0;
+
        ixgbe_free_q_vectors(adapter);
        ixgbe_reset_interrupt_capability(adapter);
  }

OK, that fix the problem.

Thanks

Yinghai

#7 lore raw
Quoted 53 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Yinghai Lu
Sent: Monday, November 22, 2010 8:16 PM
To: Skidmore, Donald C
Cc: Kirsher, Jeffrey T; Brandeburg, Jesse; David Miller; NetDev
Subject: Re: ixgbe dump

Quoted 4 lines · Donald C

Hi Yinghai,

I was hoping we could have had this patch pushed upstream sooner, but we

have quite a few in our internal queue right now.

Quoted 12 lines

If this doesn't solve your issue please let me know.

Thanks,
-Don Skidmore <[email protected]>

After freeing the rings we were not zeroing out the ring count values. This patch now clears these counts correctly.

Review

Quoted 8 lines

---

 drivers/net/ixgbe/ixgbe_main.c |    3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_main.c

drivers/net/ixgbe/ixgbe_main.c void ixgbe_clear_interrupt_scheme(struct

Quoted 4 lines

index fbad4d8..eee0b29 100644

drivers/net/ixgbe/ixgbe_main.c +0 -0
@@ -4771,6 +4771,9 @@ void ixgbe_clear_interrupt_scheme(struct

ixgbe_adapter *adapter)

drivers/net/ixgbe/ixgbe_main.c void ixgbe_clear_interrupt_scheme(struct ixgbe_adapter *adapter) · line 4779

Quoted 9 lines
drivers/net/ixgbe/ixgbe_main.c +3 -0
                adapter->rx_ring[i] = NULL;
        }
 
+       adapter->num_tx_queues = 0;
+       adapter->num_rx_queues = 0;
+
        ixgbe_free_q_vectors(adapter);
        ixgbe_reset_interrupt_capability(adapter);
  }
Quoted 5 lines

OK, that fix the problem.

Thanks

Yinghai

That great to hear. Hopefully we will be able to get the patch submitted soon.

Thanks,
-Don