patch "Staging: iio: adis16220: fix up some sysfs attribute permissions" added to staging tree
A message that is not in the archive (sent off-list or not yet received): 12899355293477@site
Quoted 18 lines · On 11/16/10 19:25, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
Staging: iio: adis16220: fix up some sysfs attribute permissions
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
in the staging-linus branch.The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also will be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 6 lines
Quoted 1 line
Quoted 1 line
From
1d904e8950c86e670ace237eaea1d48cd81e94dfMon Sep 17 00:00:00 2001From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Nov 2010 11:19:53 -0800
Subject: Staging: iio: adis16220: fix up some sysfs attribute permissionsThey should not be writable by any user
Sorry Greg, it may be jet lag related, but I really don't see how this change makes sense... Doesn't this take a write only parameter and make it read only with no read function defined? Was the intent to restrict who could write to this attribute?
Quoted 23 lines
Reported-by Linus Torvalds <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Barry Song <[email protected]>Cc stable <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/staging/iio/accel/adis16220_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/staging/iio/accel/adis16220_core.c +1
-1@@ -507,7 +507,7 @@ static IIO_DEVICE_ATTR(reset, S_IWUSR, NULL, adis16220_write_reset, 0);#define IIO_DEV_ATTR_CAPTURE (_store) \ - IIO_DEVICE_ATTR(capture, S_IWUGO, NULL, _store, 0) + IIO_DEVICE_ATTR(capture, S_IRUSR, NULL, _store, 0)static IIO_DEV_ATTR_CAPTURE (adis16220_write_capture);
Quoted 24 lines · Jonathan Cameron
Quoted 23 lines · On 11/16/10 19:25, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
Staging: iio: adis16220: fix up some sysfs attribute permissions
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
in the staging-linus branch.The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also will be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
1d904e8950c86e670ace237eaea1d48cd81e94dfMon Sep 17 00:00:00 2001From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Nov 2010 11:19:53 -0800
Subject: Staging: iio: adis16220: fix up some sysfs attribute permissions
Quoted 5 lines
Quoted 1 line
They should not be writable by any user
Sorry Greg, it may be jet lag related, but I really don't see how this change makes sense... Doesn't this take a write only parameter and make it read only with no read function defined? Was the intent to restrict who could write to this attribute?
Ah crap.
Quoted 3 lines
Review
Quoted 3 lines
#define
IIO_DEV_ATTR_CAPTURE(_store)\(quoted diff) +1
-1- IIO_DEVICE_ATTR(capture, S_IWUGO, NULL, _store, 0) + IIO_DEVICE_ATTR(capture, S_IRUSR, NULL, _store, 0)
This should be S_IWUSR, right?
Did I just get all of these wrong? I'll go verify them...
thanks,
greg k-h
Jonathan Cameron
Acked-byQuoted 31 lines · Greg KH
Quoted 24 lines · Jonathan Cameron
Quoted 23 lines · On 11/16/10 19:25, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
Staging: iio: adis16220: fix up some sysfs attribute permissions
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
in the staging-linus branch.The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also will be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
1d904e8950c86e670ace237eaea1d48cd81e94dfMon Sep 17 00:00:00 2001From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Nov 2010 11:19:53 -0800
Subject: Staging: iio: adis16220: fix up some sysfs attribute permissionsQuoted 5 lines
Quoted 1 line
They should not be writable by any user
Sorry Greg, it may be jet lag related, but I really don't see how this change makes sense... Doesn't this take a write only parameter and make it read only with no read function defined? Was the intent to restrict who could write to this attribute?
Quoted 7 lines
Ah crap.
Quoted 3 lines
Review
Quoted 3 lines
#define
IIO_DEV_ATTR_CAPTURE(_store)\(quoted diff) +1
-1- IIO_DEVICE_ATTR(capture, S_IWUGO, NULL, _store, 0) + IIO_DEVICE_ATTR(capture, S_IRUSR, NULL, _store, 0)This should be
S_IWUSR, right?
Equivalent with that in and I'm happy to add my ack.
Thanks,
Jonathan
Quoted 7 lines
Did I just get all of these wrong? I'll go verify them...
thanks,
greg k-h
Quoted 34 lines · Jonathan Cameron
Quoted 33 lines · Greg KH
Quoted 24 lines · Jonathan Cameron
Quoted 23 lines · On 11/16/10 19:25, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
Staging: iio: adis16220: fix up some sysfs attribute permissions
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
in the staging-linus branch.The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also will be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
1d904e8950c86e670ace237eaea1d48cd81e94dfMon Sep 17 00:00:00 2001From: Greg Kroah-Hartman <[email protected]>
Date: Tue, 16 Nov 2010 11:19:53 -0800
Subject: Staging: iio: adis16220: fix up some sysfs attribute permissionsQuoted 5 lines
Quoted 1 line
They should not be writable by any user
Sorry Greg, it may be jet lag related, but I really don't see how this change makes sense... Doesn't this take a write only parameter and make it read only with no read function defined? Was the intent to restrict who could write to this attribute?
Ah crap.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Review
Quoted 3 lines
#define
IIO_DEV_ATTR_CAPTURE(_store)\(quoted diff) +1
-1- IIO_DEVICE_ATTR(capture, S_IWUGO, NULL, _store, 0) + IIO_DEVICE_ATTR(capture, S_IRUSR, NULL, _store, 0)This should be
S_IWUSR, right?Equivalent with that in and I'm happy to add my ack.
Acked-by Jonathan Cameron <[email protected]>
Thanks.
And yes, I got all 7 of these patches wrong, I'll go redo them :(
thanks for verifying and actually reviewing them, I appreciate it.
greg k-h