Skip to contentSkip to conversation

ALSA: HDA: Add Front control for ALC887

PATCH In review David Henningsson 2 participants 2 messages Nov 19, 2010 – Nov 22, 2010 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 ALSA: HDA: Add Front control for ALC887

HP and Line out share DAC, so we need a switch to turn line out off.

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
Quoted 1 line

From 955438a1e0f21218d207196456d8e46295f5feec Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Wed, 17 Nov 2010 15:06:15 +0100
Subject: [PATCH 3/3] ALSA: HDA: Add Front control for ALC887

HP and Line out share DAC, so we need a switch to turn line out off.

---
 sound/pci/hda/patch_realtek.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
sound/pci/hda/patch_realtek.c +9 -1
index 4cc7bb2..86df37c 100644
@@ -10836,8 +10836,16 @@ static int alc882_parse_auto_config(struct hda_codec *codec)
 	err = alc880_auto_fill_dac_nids(spec, &spec->autocfg);
 	if (err < 0)
 		return err;
-	if (codec->vendor_id == 0x10ec0887)
+	if (codec->vendor_id == 0x10ec0887) {
 		err = alc861vd_auto_create_multi_out_ctls(spec, &spec->autocfg);
+		if (err < 0)
+			return err;
+		/* We need something to switch that doesn't affect headphones */
+		if (spec->autocfg.line_out_pins[0])
+			err = add_pb_sw_ctrl(spec, ALC_CTL_WIDGET_MUTE, "Front",
+				  HDA_COMPOSE_AMP_VAL(spec->autocfg.line_out_pins[0], 3, 0, HDA_OUTPUT));
+
+        }
 	else
 		err = alc880_auto_create_multi_out_ctls(spec, &spec->autocfg);
 	if (err < 0)
Signature · 1 line
1.7.1

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Fri, 19 Nov 2010 10:31:20 +0100,

Quoted 7 lines · David Henningsson
Quoted 2 lines

From 955438a1e0f21218d207196456d8e46295f5feec Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Wed, 17 Nov 2010 15:06:15 +0100
Subject: [PATCH 3/3] ALSA: HDA: Add Front control for ALC887

HP and Line out share DAC, so we need a switch to turn line out off.

I suppose this patch depending on your second patch, so let's postpone.

thanks,

Takashi

Quoted 31 lines
---
 sound/pci/hda/patch_realtek.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
sound/pci/hda/patch_realtek.c +9 -1
index 4cc7bb2..86df37c 100644
@@ -10836,8 +10836,16 @@ static int alc882_parse_auto_config(struct hda_codec *codec)
 	err = alc880_auto_fill_dac_nids(spec, &spec->autocfg);
 	if (err < 0)
 		return err;
-	if (codec->vendor_id == 0x10ec0887)
+	if (codec->vendor_id == 0x10ec0887) {
 		err = alc861vd_auto_create_multi_out_ctls(spec, &spec->autocfg);
+		if (err < 0)
+			return err;
+		/* We need something to switch that doesn't affect headphones */
+		if (spec->autocfg.line_out_pins[0])
+			err = add_pb_sw_ctrl(spec, ALC_CTL_WIDGET_MUTE, "Front",
+				  HDA_COMPOSE_AMP_VAL(spec->autocfg.line_out_pins[0], 3, 0, HDA_OUTPUT));
+
+        }
 	else
 		err = alc880_auto_create_multi_out_ctls(spec, &spec->autocfg);
 	if (err < 0)
Signature · 1 line
1.7.1