power: gpio-charger: fix potential NULL dereference
PATCH 1/1 power: gpio-charger: fix potential NULL dereference
kzalloc() result is not compared with NULL. It might lead to NULL pointer dereference in OOM situation.
Signed-off-by Vasiliy Kulikov <[email protected]>
---
Compile tested only.
drivers/power/gpio-charger.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/power/gpio-charger.c +4 -0
@@ -87,6 +87,10 @@ static int __devinit gpio_charger_probe(struct platform_device *pdev) } gpio_charger =kzalloc (sizeof (*gpio_charger),GFP_KERNEL ); +if (!gpio_charger) { +dev_err (&pdev->dev,"kzalloc failed\n" ); +return -ENOMEM ; + } charger = &gpio_charger->charger;
Signature · 1 line
1.7.0.4
Quoted 15 lines · Vasiliy Kulikov
kzalloc()result is not compared with NULL. It might lead to NULL pointer dereference in OOM situation.Signed-off-by Vasiliy Kulikov <[email protected]>---
Compile tested only.drivers/power/gpio-charger.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)drivers/power/gpio-charger.c +0
-0
drivers/power/gpio-charger.c static int __devinit gpio_charger_probe(struct platform_device *pdev) · line 96
Quoted 10 lines
drivers/power/gpio-charger.c +4
-0@@ -87,6 +87,10 @@ static int __devinit gpio_charger_probe(struct platform_device *pdev) } gpio_charger =kzalloc (sizeof (*gpio_charger),GFP_KERNEL ); +if (!gpio_charger) { +dev_err (&pdev->dev,"kzalloc failed\n" ); +return -ENOMEM ; + } charger = &gpio_charger->charger;
Hi
I already send a similar patch yesterday.
See http://lkml.org/lkml/2010/11/18/632
- Lars