Add function for clearing the requested VCPUs' mce registers.
PATCH 1/1 Add function for clearing the requested VCPUs' mce registers.
In some case of mce test, the injected data can be remained in the registers and ca affect to the result of following test cases. So add codes for clearing mce registers of given VCPU.
mce registers of give VCPU could be cleared from kernel by calling the function in this patch. What need to be paid attention is that the status and mcg_status of mce must be set with 0. If not, mce registers will not be cleared.
--- arch/x86/kvm/x86.c | 28 +++++++++++++++++++++++++++- 1 files changed, 27 insertions(+), 1 deletions(-)
arch/x86/kvm/x86.c +27 -1
@@ -2246,6 +2246,25 @@ out:return r; } +static void kvm_vcpu_x86_clear_mce (struct kvm_vcpu *vcpu, +struct kvm_x86_mce *mce) +{ +u64 *banks = vcpu->arch.mce_banks; +u64 mcg_cap = vcpu->arch.mcg_cap; + +unsigned bank_num = mcg_cap &0xff ; +int i =0 ; + +for (i =0 ; i < bank_num; i++) { + banks[1 ] =0 ; + banks[2 ] =0 ; + banks[3 ] =0 ; + banks +=4 ; + } + + vcpu->arch.mcg_status =0 ; +} +static int kvm_vcpu_ioctl_x86_set_mce (struct kvm_vcpu *vcpu,struct kvm_x86_mce *mce) {
@@ -2253,8 +2272,15 @@ static int kvm_vcpu_ioctl_x86_set_mce(struct kvm_vcpu *vcpu,unsigned bank_num = mcg_cap &0xff ;u64 *banks = vcpu->arch.mce_banks; -if (mce->bank >= bank_num || !(mce->status &MCI_STATUS_VAL )) +if (mce->bank >= bank_num)return -EINVAL ; +if (!(mce->status &MCI_STATUS_VAL )) { +if (!mce->status && !mce->mcg_status) { +kvm_vcpu_x86_clear_mce (vcpu, mce); +return 0 ; + } +return -EINVAL ; + }/* * if IA32_MCG_CTL is not all 1s, the uncorrected error * reporting is disabled
Signature · 1 line
1.7.1.1
Hi, Dongming,
Quoted 8 lines · Jin Dongming
In some case of mce test, the injected data can be remained in the registers and ca affect to the result of following test cases. So add codes for clearing mce registers of given VCPU.
mce registers of give VCPU could be cleared from kernel by calling the function in this patch. What need to be paid attention is that the status and
mcg_statusof mce must be set with 0. If not, mce registers will not be cleared.
Why do you need this? To use "mce=3" in guest Linux MCE testing?
If it is, why not use full reboot? MCE registers are not cleared in real machine too. And it is not so pain to reboot the guest.
Best Regards,
Huang Ying
Hi, Huang-san
Quoted 7 lines · Huang Ying
Hi, Dongming,
Quoted 4 lines · Jin Dongming
In some case of mce test, the injected data can be remained in the registers and ca affect to the result of following test cases. So add codes for clearing mce registers of given VCPU.
Quoted 6 lines
Quoted 4 lines
mce registers of give VCPU could be cleared from kernel by calling the function in this patch. What need to be paid attention is that the status and
mcg_statusof mce must be set with 0. If not, mce registers will not be cleared.Why do you need this? To use "mce=3" in guest Linux MCE testing?
When I set fake_panic==1 on Guest OS and tested mce via qemu-monitor, I got the wrong result sometimes. The reason why I got the wrong result was that mce registers were not cleared. So I made this patch.
Quoted 3 lines
If it is, why not use full reboot? MCE registers are not cleared in real machine too. And it is not so pain to reboot the guest.
Though we know that mce registers could be cleared by rebooting the Guest Machine and the reboot of Guest Machine could save much more time than the reboot of Host Machine, it is still slower than setting fake_panic==1 to mce test.
Best Regards,
Jin Dongming
Quoted 11 lines
Best Regards,
Huang Ying--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 15 lines · Jin Dongming
Hi, Huang-san
Quoted 12 lines · Huang Ying
Hi, Dongming,
Quoted 8 lines · Jin Dongming
In some case of mce test, the injected data can be remained in the registers and ca affect to the result of following test cases. So add codes for clearing mce registers of given VCPU.
mce registers of give VCPU could be cleared from kernel by calling the function in this patch. What need to be paid attention is that the status and
mcg_statusof mce must be set with 0. If not, mce registers will not be cleared.
Quoted 4 lines
Quoted 1 line
Why do you need this? To use "mce=3" in guest Linux MCE testing?
When I set fake_panic==1 on Guest OS and tested mce via qemu-monitor, I got the wrong result sometimes. The reason why I got the wrong result was that mce registers were not cleared. So I made this patch.
This can be done in QEMU via KVM_SET_MSRS too.
Quoted 6 lines
Quoted 2 lines
If it is, why not use full reboot? MCE registers are not cleared in real machine too. And it is not so pain to reboot the guest.
Though we know that mce registers could be cleared by rebooting the Guest Machine and the reboot of Guest Machine could save much more time than the reboot of Host Machine, it is still slower than setting fake_panic==1 to mce test.
Best Regards,
Huang Ying
Hi, Huang-san
Quoted 16 lines · Huang Ying
Quoted 15 lines · Jin Dongming
Hi, Huang-san
Quoted 12 lines · Huang Ying
Hi, Dongming,
Quoted 8 lines · Jin Dongming
In some case of mce test, the injected data can be remained in the registers and ca affect to the result of following test cases. So add codes for clearing mce registers of given VCPU.
mce registers of give VCPU could be cleared from kernel by calling the function in this patch. What need to be paid attention is that the status and
mcg_statusof mce must be set with 0. If not, mce registers will not be cleared.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Why do you need this? To use "mce=3" in guest Linux MCE testing?
When I set fake_panic==1 on Guest OS and tested mce via qemu-monitor, I got the wrong result sometimes. The reason why I got the wrong result was that mce registers were not cleared. So I made this patch.
This can be done in QEMU via
KVM_SET_MSRStoo.
Yes, it could be done in Guest OS with APL. So I will cancel this patch.
Best Regards,
Jin Dongming
Quoted 18 lines
Quoted 7 lines
Quoted 3 lines
If it is, why not use full reboot? MCE registers are not cleared in real machine too. And it is not so pain to reboot the guest.
Though we know that mce registers could be cleared by rebooting the Guest Machine and the reboot of Guest Machine could save much more time than the reboot of Host Machine, it is still slower than setting fake_panic==1 to mce test.
Best Regards,
Huang Ying--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html