Skip to contentSkip to conversation

scripts/checkpatch.pl: add ata_port_operations to the list of ops that ought to be const.

PATCH In review Lionel Debroux 2 participants 2 messages Nov 8, 2010 – Nov 25, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/checkpatch.pl: add ata_port_operations to the list of ops that ought to be const.

Patch against mainline.

---

Subject: [PATCH] scripts/checkpatch.pl: add ata_port_operations to the list of ops that ought to be const.

I noticed that many ata_port_operations instances are constified by the grsecurity patch, so it may be desirable to reduce the introduction of non-const instances through checkpatch.pl.

---
 scripts/checkpatch.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/checkpatch.pl +1 -0
index e3c7fc0..33fab2e 100755
@@ -2810,6 +2810,7 @@ sub process {
 # check for various ops structs, ensure they are const.
 		my $struct_ops = qr{acpi_dock_ops|
 				address_space_operations|
+				ata_port_operations|
 				backlight_ops|
 				block_device_operations|
 				dentry_operations|
Signature · 1 line
1.7.3.2.161.g3089c
#1 lore raw

Added Andy and Joe to CC. Lionel, you should consult the MAINTAINERS file and/or the get_maintainer.pl script and/or the git history to find suitable addresses to CC.

Michal

Quoted 27 lines · Lionel Debroux

Patch against mainline.

---

Subject: [PATCH] scripts/checkpatch.pl: add ata_port_operations to the list of ops that ought to be const.

I noticed that many ata_port_operations instances are constified by the grsecurity patch, so it may be desirable to reduce the introduction of non-const instances through checkpatch.pl.

---
 scripts/checkpatch.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/checkpatch.pl +1 -0
index e3c7fc0..33fab2e 100755
@@ -2810,6 +2810,7 @@ sub process {
 # check for various ops structs, ensure they are const.
 		my $struct_ops = qr{acpi_dock_ops|
 				address_space_operations|
+				ata_port_operations|
 				backlight_ops|
 				block_device_operations|
 				dentry_operations|