xen: Restrict build to x86 targets
PATCH 1/1 xen: Restrict build to x86 targets
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
--- Makefile.objs | 4 ++-- Makefile.target | 4 ++-- configure | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
Makefile.objs +2 -2
@@ -148,8 +148,8 @@ slirp-obj-y += tcp_subr.o tcp_timer.o udp.o bootp.o tftp.o common-obj-$(CONFIG_SLIRP) += $(addprefix slirp/, $(slirp-obj-y)) # xen backend driver support -common-obj-$(CONFIG_XEN) += xen_backend.o xen_devconfig.o -common-obj-$(CONFIG_XEN) += xen_console.o xenfb.o xen_disk.o xen_nic.o +common-obj-$(CONFIG_XEN_HOST) += xen_backend.o xen_devconfig.o +common-obj-$(CONFIG_XEN_HOST) += xen_console.o xenfb.o xen_disk.o xen_nic.o ###################################################################### # libuser
Makefile.target +2 -2
@@ -203,8 +203,8 @@ QEMU_CFLAGS += $(VNC_SASL_CFLAGS) QEMU_CFLAGS += $(VNC_JPEG_CFLAGS) QEMU_CFLAGS += $(VNC_PNG_CFLAGS) -# xen backend driver support -obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o +# xen target support +obj-$(CONFIG_XEN_TARGET) += xen_machine_pv.o xen_domainbuild.o # USB layer obj-$(CONFIG_USB_OHCI) += usb-ohci.o
configure +2 -2
@@ -2565,7 +2565,7 @@ if test "$bluez" = "yes" ; then echo "BLUEZ_CFLAGS=$bluez_cflags" >> $config_host_mak fi if test "$xen" = "yes" ; then - echo "CONFIG_XEN=y" >> $config_host_mak + echo "CONFIG_XEN_HOST=y" >> $config_host_mak fi if test "$io_thread" = "yes" ; then echo "CONFIG_IOTHREAD=y" >> $config_host_mak
@@ -2903,7 +2903,7 @@ echo "TARGET_ABI_DIR=$TARGET_ABI_DIR" >> $config_target_mak case "$target_arch2" in i386|x86_64) if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then - echo "CONFIG_XEN=y" >> $config_target_mak + echo "CONFIG_XEN_TARGET=y" >> $config_target_mak fi esac case "$target_arch2" in
Signature · 1 line
1.7.1
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as _HOST are target specific.
Alex
Quoted 9 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.
At least so far, the HOST part is build once for all targets into the host backend library. As this step injected CONFIG_XEN into all target builds, even non-x86 targets built xen_machine_pv and xen_domainbuild. That's addressed by the patch.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.
I still don't understand the need for that split. The device drivers should be built only once, as do the xen_machine_pv parts. Both are useless on non-x86. CONFIG_XEN should simply always be a target specific option.
Alex
Quoted 12 lines · Alexander Graf
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.I still don't understand the need for that split.
Enable Xen and build some non-x86 targets, then you see the need.
Quoted 1 line
The device drivers should be built only once, as do the
xen_machine_pvparts. Both are useless on non-x86.CONFIG_XENshould simply always be a target specific option.
Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
Quoted 22 lines · Jan Kiszka
Quoted 12 lines · Alexander Graf
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.I still don't understand the need for that split.
Quoted 7 lines
Enable Xen and build some non-x86 targets, then you see the need.
Quoted 1 line
The device drivers should be built only once, as do the
xen_machine_pvparts. Both are useless on non-x86.CONFIG_XENshould simply always be a target specific option.Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix.
Should be enough to just replace obj-$(CONFIG_XEN) by obj-i386-$(CONFIG_XEN). Unless it's very urgent, please wait with this patch until qemu-dm and xenner are in. It's pretty suboptimal to have 3 patches flying around that hit the exact same code spot :).
Alex
Quoted 27 lines · Alexander Graf
Quoted 24 lines · Jan Kiszka
Quoted 12 lines · Alexander Graf
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.I still don't understand the need for that split.
Enable Xen and build some non-x86 targets, then you see the need.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
The device drivers should be built only once, as do the
xen_machine_pvparts. Both are useless on non-x86.CONFIG_XENshould simply always be a target specific option.Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix.
Should be enough to just replace obj-$(CONFIG_XEN) by obj-i386-$(CONFIG_XEN).
Indeed (as long as qemu's xen remains x86-only).
Quoted 1 line
Unless it's very urgent, please wait with this patch until qemu-dm and xenner are in. It's pretty suboptimal to have 3 patches flying around that hit the exact same code spot :).
It isn't urgent. If patches series refactor the stuff and fix the dependency, I'm happy to wait for them.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
Quoted 30 lines · Jan Kiszka
Quoted 29 lines · Alexander Graf
Quoted 26 lines · Jan Kiszka
Quoted 12 lines · Alexander Graf
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.I still don't understand the need for that split.
Enable Xen and build some non-x86 targets, then you see the need.
Quoted 1 line
The device drivers should be built only once, as do the
xen_machine_pvparts. Both are useless on non-x86.CONFIG_XENshould simply always be a target specific option.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix.
Should be enough to just replace obj-$(CONFIG_XEN) by obj-i386-$(CONFIG_XEN).
Indeed (as long as qemu's xen remains x86-only).
I'm 99.9% sure it will :).
Quoted 4 lines
Quoted 1 line
Unless it's very urgent, please wait with this patch until qemu-dm and xenner are in. It's pretty suboptimal to have 3 patches flying around that hit the exact same code spot :).
It isn't urgent. If patches series refactor the stuff and fix the dependency, I'm happy to wait for them.
They don't really refactor it, but add a lot more dependencies. Anthony, since you probably need yet another round for the 4.0 compile stuff, feel like putting this on your TODO list too? (Sorry this takes so long :( - I'll try to review stuff quicker next time around)
Alex
Quoted 41 lines · Alexander Graf
Quoted 30 lines · Jan Kiszka
Quoted 29 lines · Alexander Graf
Quoted 26 lines · Jan Kiszka
Quoted 12 lines · Alexander Graf
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.I still don't understand the need for that split.
Enable Xen and build some non-x86 targets, then you see the need.
Quoted 1 line
The device drivers should be built only once, as do the
xen_machine_pvparts. Both are useless on non-x86.CONFIG_XENshould simply always be a target specific option.Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix.
Should be enough to just replace obj-$(CONFIG_XEN) by obj-i386-$(CONFIG_XEN).
Indeed (as long as qemu's xen remains x86-only).
Quoted 8 lines
I'm 99.9% sure it will :).
Quoted 4 lines
Quoted 1 line
Unless it's very urgent, please wait with this patch until qemu-dm and xenner are in. It's pretty suboptimal to have 3 patches flying around that hit the exact same code spot :).
It isn't urgent. If patches series refactor the stuff and fix the dependency, I'm happy to wait for them.
They don't really refactor it, but add a lot more dependencies. Anthony, since you probably need yet another round for the 4.0 compile stuff, feel like putting this on your TODO list too? (Sorry this takes so long :( - I'll try to review stuff quicker next time around)
OK, but I will go a little further by putting all Xen stuff in x86 only target, not only xenpv.
Signature · 1 line
Anthony PERARD
Quoted 47 lines · Anthony PERARD
Quoted 45 lines · Alexander Graf
Quoted 30 lines · Jan Kiszka
Quoted 29 lines · Alexander Graf
Quoted 26 lines · Jan Kiszka
Quoted 12 lines · Alexander Graf
Quoted 9 lines · Jan Kiszka
Quoted 8 lines · Alexander Graf
Quoted 4 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Xen target bits in qemu are intended for x86. Let the build system reflect this and avoid useless building/linking for other targets.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Not sure I understand the split. Xen is x86 only, yes. But why split it into host and target? Target usually defines the guest. The piece you marked as
_HOSTare target specific.At least so far, the HOST part is build once for all targets into the host backend library. As this step injected
CONFIG_XENinto all target builds, even non-x86 targets builtxen_machine_pvandxen_domainbuild. That's addressed by the patch.I still don't understand the need for that split.
Enable Xen and build some non-x86 targets, then you see the need.
Quoted 1 line
The device drivers should be built only once, as do the
xen_machine_pvparts. Both are useless on non-x86.CONFIG_XENshould simply always be a target specific option.Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Maybe the split-up between the "generic" host-side interfaces and xen_machine_pv/xen_domainbuild is the problem. You know the dependencies better than me, maybe you find a better fix.
Should be enough to just replace obj-$(CONFIG_XEN) by obj-i386-$(CONFIG_XEN).
Indeed (as long as qemu's xen remains x86-only).
I'm 99.9% sure it will :).
Quoted 2 lines
Quoted 1 line
Unless it's very urgent, please wait with this patch until qemu-dm and xenner are in. It's pretty suboptimal to have 3 patches flying around that hit the exact same code spot :).
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
It isn't urgent. If patches series refactor the stuff and fix the dependency, I'm happy to wait for them.
They don't really refactor it, but add a lot more dependencies. Anthony, since you probably need yet another round for the 4.0 compile stuff, feel like putting this on your TODO list too? (Sorry this takes so long :( - I'll try to review stuff quicker next time around)
OK, but I will go a little further by putting all Xen stuff in x86 only target, not only xenpv.
Yes, please. That's perfect :).
Alex